Commit graph

56 commits

Author SHA1 Message Date
Thomas Horstmeyer
d9d3d7ba8e Fix nil pointer exception in codespace selection 2022-05-10 16:27:25 +01:00
Jose Garcia
cd6386cf64 Update order 2022-05-05 15:07:29 -04:00
Jose Garcia
ea7d9288e3 Handle star in display name 2022-05-05 08:21:12 -04:00
JP Ungaretti
2dd81671a9
Remove empty return 2022-05-03 09:40:07 -07:00
Caleb Brose
55bce59ab7
Add command to open codespaces in JupyterLab
Add command to open codespaces in JupyterLab
2022-04-28 16:11:14 -05:00
JP Ungaretti
3526d25a1e Remove mention of function 2022-04-28 20:55:43 +00:00
JP Ungaretti
8aa132e6c6 Use named return values 2022-04-28 18:42:05 +00:00
JP Ungaretti
6ddd3360d8 Update auth error message 2022-04-28 18:10:14 +00:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
JP Ungaretti
fce69a5350 Add context to errors 2022-04-21 15:03:07 -07:00
JP Ungaretti
3216d1bb3a Remove function return 2022-04-21 14:29:30 -07:00
JP Ungaretti
4452f37819 Clarify session helper 2022-04-14 17:10:11 -05:00
JP Ungaretti
322fae53b1 Clean up more errors 2022-04-14 16:14:29 -05:00
JP Ungaretti
eaf8f84baf Merge branch 'trunk' into add-cs-jupyter 2022-04-14 15:27:40 -05:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Jake Shorty
41719f7624 Location is an optional flag when creating codespaces 2022-04-05 20:19:19 +00:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Charlie Andrews
8bf0cb8f13 Refactor the getOrChooseCodespace to always check for pending ops 2022-03-16 08:56:17 -04:00
JP Ungaretti
fba5fb4eec Refactor liveshare setup to a new function 2022-03-04 00:54:15 +00:00
Patrick Veverka
cd8d653285
Merge pull request #5211 from cli/edit_codspaces
Allow Editing Codespaces
2022-03-03 18:22:01 -05:00
Mark Phelps
590acaa1d6 WIP 2022-02-15 19:35:53 -05:00
Patrick Veverka
0635514ddf first stab
wip

move to method param

flushing out
2022-02-15 20:13:30 +00:00
Patrick Veverka
f6f8ba8b7b
Add display name for codespaces (#5044) 2022-02-09 16:15:03 +01:00
Caleb Brose
eeeb73a3e3
Repo name suggestions for cs create (#5108)
Co-authored-by: Alan Donovan <alan@alandonovan.net>
2022-01-31 10:20:49 +00:00
Jeff Hubbard
5cee9e16f3 Add interactive prompt to choose from list of available devcontainer files 2022-01-21 14:11:52 -08:00
Mislav Marohnić
3b7e5fc246 Store Executable() information on codespaces App
This is to avoid having to explicitly pass it to each subcommand that
needs it. Each codespaces command runs in the context of App, so that's
a point of shared context that we can store state in.
2021-12-21 14:03:10 +01:00
Jason Lunz
37f8039f76
merge ensureAuthorizedKeys into checkAuthorizedKeys 2021-12-20 13:57:52 -07:00
Jose Garcia
bbea5ac95e
codespace: progress indication, logging (#4555)
* Rework logging, showing progress, and printing from `codespace` commands
* Change rendering of the general progress indicator so that it's visible on both dark and light backgrounds
* The progress indicator now "spins" faster

Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 18:04:04 +02:00
Jose Garcia
4504e49e96 Update running method 2021-10-14 20:02:02 -04:00
Jose Garcia
1aec892326
Merge pull request #4520 from cli/jg/new-api-shape
codespace: implement new API payload
2021-10-14 19:59:59 -04:00
Jose Garcia
b0905a415f
Merge pull request #4508 from cli/jg/codespace-stop
codespace stop: new command to stop a running codespace
2021-10-14 11:22:25 -04:00
Jose Garcia
3544275c2f Implement new API payload for a Codespace 2021-10-14 09:10:15 -04:00
Jose Garcia
4fb4a21efd Rename + docs 2021-10-13 10:57:50 -04:00
Jose Garcia
97b52b30fc Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive 2021-10-13 10:45:40 -04:00
Jose Garcia
ea0d0a543f Initial StopCodespace implementation
- API
- Command
2021-10-13 07:45:54 -04:00
Jose Garcia
5170a2931f Switch to standard lib log.Logger & support dfile
- --debug-file flag can now be used in conjuction with --debug to
  specify the debug file path
- Push out logger concerns to callers of liveshare
2021-10-12 15:45:05 -04:00
Mateusz Urbanek
cedbbe3c2a
Add limit flag to codespace list (#4453)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-11 18:32:40 +00:00
Jose Garcia
bdc9ad30e7 Revert other rename changes 2021-10-06 13:46:04 -04:00
Jose Garcia
771ac714ac Update docs 2021-10-06 11:47:18 -04:00
Jose Garcia
3a28643630 Keep codespace struct in API for now
- Use a private codespace structure in the cmd pkg to encapsulate common
  behavior
2021-10-06 11:44:26 -04:00
Jose Garcia
017632d63d Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 09:57:39 -04:00
Jose Garcia
8135fdbd99 Switch GetCodespace to new API endpoint
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
  details in the GET request. Ommitting to do so results in a faster
  response
2021-10-06 08:50:42 -04:00
Jose Garcia
1971292175 Fixes bug there are +2 codespaces with a conflict
- Tracks conflicting name going forward for other records
- Moves the git status dirty star into a constant so we can reference it
2021-10-05 13:24:47 -04:00
Jose Garcia
a8d1718f21 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-05 12:57:11 -04:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public
codespace machine: switch `API.GetCodespacesMachines` to use new API
2021-10-05 12:44:38 -04:00
Jose Garcia
975bd7c08a Change choose codespace prompt
- Repo + branch is favored
- Codespace name is included to disambiguate between two codespaces
- Move Codespace model out of out API into its own package
- Update call sites and group behavior under codespace.Codespace
2021-10-05 11:23:12 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public
codespace create: update `API.StartCodespace` to use new API endpoint
2021-10-05 09:20:33 -04:00
Jose Garcia
a2e6df18e7
Merge pull request #4432 from cli/jg/rename-pkg
codespace: rename the cmd pkg to codespace
2021-10-05 08:23:36 -04:00
Jose Garcia
d02876e6ea Rename the cmd pkg to codespace 2021-10-04 14:16:04 -04:00