Commit graph

8815 commits

Author SHA1 Message Date
Meredith Lancaster
4967eaff8b Merge branch 'update-attestation-verify-table-output' of github.com:malancas/cli into update-attestation-verify-table-output 2025-01-15 14:13:22 -07:00
Meredith Lancaster
555c9b65f5 drop unused handler method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-15 14:13:16 -07:00
Meredith Lancaster
2ffce8ae9f print attestation output info as bullet points instead of table
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-15 14:11:54 -07:00
dependabot[bot]
2757d22b4b
Bump google.golang.org/protobuf from 1.36.2 to 1.36.3
Bumps google.golang.org/protobuf from 1.36.2 to 1.36.3.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 14:49:31 +00:00
William Martin
e7ffb1e435 Fix typo in secret base repo selection comment 2025-01-15 14:55:18 +01:00
William Martin
88a64d2a11 Change wording on secret repo prompt 2025-01-15 14:55:17 +01:00
William Martin
b382b24728 Print informative message before prompting for secret repo 2025-01-15 14:55:17 +01:00
William Martin
a47327aee6 Secret base repo prompting should not use resolved remote
This is because the secret commands don't use the SmartBaseRepo behaviour, and therefore
don't care about the resolved remote.
2025-01-15 14:55:17 +01:00
William Martin
ce47fabc27 Move secret base repo prompting earlier 2025-01-15 14:55:17 +01:00
William Martin
5630252f78 Add acceptance test for secrets remote disambiguation 2025-01-15 14:55:17 +01:00
William Martin
d831e3e1db Remove validated TODO and add review warning 2025-01-15 14:55:17 +01:00
William Martin
4da4c82090 Rename secret BaseRepo func 2025-01-15 14:55:17 +01:00
William Martin
870da79886 Use smarter base repo funcs for secret commands 2025-01-15 14:55:17 +01:00
William Martin
73244c010e Move secret repo validation into secrets subpackage 2025-01-15 14:55:17 +01:00
William Martin
df8bb51c9c Always prompt on secret set when multiple remotes 2025-01-15 14:55:17 +01:00
Wing
0be5720c1c Update setdefault test 2025-01-15 14:55:17 +01:00
Wing
cad59036f5 Update docs for set-default
NOTE: gh does not use the default repository for managing repository and environment secrets.
2025-01-15 14:55:17 +01:00
Wing
3de2fd94b3 Prompt for secret commands
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Wing
57c9ee0ad2 Add tests for secret commands
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Wing
88988374b5 Add remote check to secret commands
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Tyler McGoffin
adc5f01d23
Merge pull request #10214 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.3
Bump github.com/sigstore/protobuf-specs from 0.3.2 to 0.3.3
2025-01-14 16:08:39 -08:00
Tyler McGoffin
12ee8b7a86
Merge pull request #10154 from danochoa/gh-gist-delete-prompt
gh gist delete: prompt for gist id
2025-01-14 14:42:13 -08:00
Tyler McGoffin
3feeb9a826 Add tests for deleteGist 2025-01-14 14:21:49 -08:00
Rajhans Jadhao
10d4d27d8c
Merge branch 'trunk' into rerun-err-msg 2025-01-14 15:04:15 +05:30
Daniel A. Ochoa
3370bc8a04
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-13 21:17:23 -06:00
Andy Feller
bc8c46b0b1 Make extension update check non-blocking
Fixes #10235

This commit updates the Cobra command logic around extension upgrade checks to be non-blocking.

Previously, we were waiting for 1 second after the extension completed to allow the update checking logic complete, however users want the GitHub CLI to run as far as possible.
2025-01-13 20:38:03 -05:00
Meredith Lancaster
ab26df324f
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-13 14:46:54 -07:00
Meredith Lancaster
2ddfe865f4
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Phill MV <phillmv@github.com>
2025-01-13 13:02:05 -07:00
AMS21
960f533234
add install instructions for Manjaro Linux 2025-01-13 20:01:28 +01:00
Tyler McGoffin
6fe21d8f52
Merge pull request #10197 from cli/jtmcg/remove-named-returns
Remove naked return values from `ReadBranchConfig` and `prSelectorForCurrentBranch`
2025-01-13 09:55:17 -08:00
dependabot[bot]
7300f0d568
Bump github.com/gabriel-vasile/mimetype from 1.4.7 to 1.4.8
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases)
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.7...v1.4.8)

---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-13 15:23:32 +00:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Mateus Marquezini
4eb0e8138f
Merge branch 'trunk' into fix/issue_10042 2025-01-13 11:47:52 -03:00
Mateus Marquezini
c0f6eb0598 #10042: Attempt to add a new test scenario for handling error messages when TTY is unavailable 2025-01-13 11:39:48 -03:00
Andy Feller
41e99b9eab
Merge pull request #9934 from cli/andyfeller/cli-cli-8183-timeout-pt2
Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices
2025-01-13 09:12:32 -05:00
Mateus Marquezini
977e2326a2 #10042: Applied code review suggestions to view_test.go 2025-01-13 11:06:13 -03:00
Rajhans Jadhao
9035f651c7
Merge branch 'trunk' into rerun-err-msg 2025-01-13 19:24:09 +05:30
Rajhans Jadhao
b41b77165b
show error message for rerun workflow older than a month ago 2025-01-13 19:21:58 +05:30
Andy Feller
3ada5af872 Enhance help docs on ext upgrade notices
- update `gh help environment` to include that upgrade notices only happen when gh or extensions are executed
- update `gh ext --help` to include reference to upgrade notices and points to `gh help environment` for info on disabling
2025-01-13 08:41:10 -05:00
Andy Feller
8a2be52be0
Merge pull request #10225 from zhuhaicity/fix_func_name
chore: fix some function names in comment
2025-01-13 08:08:18 -05:00
danochoa
1d9b4e4464 fix tests 2025-01-12 19:36:44 -06:00
danochoa
08f7706c42 fix tests 2025-01-12 19:18:24 -06:00
danochoa
7885167c70 gist delete - check no gists 2025-01-12 17:01:45 -06:00
Mateus Marquezini
24e9fed7e0 removed unnecessary space 2025-01-12 14:57:24 -03:00
Mateus Marquezini
c5d6ae6cf6
Update pkg/cmd/gist/edit/edit.go
Update pkg/cmd/gist/edit/edit.go after code review

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-01-12 14:53:20 -03:00
Mateus Marquezini
f65ac161ee
Merge branch 'trunk' into fix/issue_10042 2025-01-12 14:50:41 -03:00
zhuhaicity
13211af256 chore: fix some function names in comment
Signed-off-by: zhuhaicity <zhuhai@52it.net>
2025-01-12 15:07:04 +08:00
danochoa
5de282c970 drop description from prompts, fix tests 2025-01-11 01:35:12 -06:00
Andy Feller
0a1c9be656 Expand docs on cleaning extension update dir
This summarizes a conversation within cli/cli#9934 PR regarding how the new extension update directory metadata would affect gh if not cleaned up.
2025-01-10 14:57:10 -05:00
Andy Feller
97eb8a194e Simplifying cleanExtensionUpdateDir logic
This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not.
2025-01-10 14:29:55 -05:00