vilmibm
15bfb5447b
split auth flow code into new internal package
2020-09-10 12:13:48 -05:00
vilmibm
ecd1b34b39
Add prompt config setting and support in CanPrompt
2020-09-10 12:13:48 -05:00
vilmibm
5119d21137
support Config in IOStreams
2020-09-10 12:12:47 -05:00
Nate Smith
33e11f02e4
Merge pull request #1611 from dhleong/dhleong/pr-prepend-commit-bodies
...
Prepend PR body defaults to the selected template (if any)
2020-09-09 16:57:27 -05:00
Mislav Marohnić
50d5813182
Indicate that title is optional in release create
2020-09-09 17:45:55 +02:00
Mislav Marohnić
9040f6adc6
Fix view tests
2020-09-09 17:40:04 +02:00
Mislav Marohnić
1ce61d4b80
Allow specifying multiple patterns in release download
2020-09-09 17:36:49 +02:00
Mislav Marohnić
7614ffee30
Add docs to release create/upload
2020-09-09 17:36:25 +02:00
Mislav Marohnić
202d11146d
Add success message to release upload
2020-09-09 17:09:49 +02:00
Mislav Marohnić
fda9659e4a
Consistently print browsed URL across commands
2020-09-09 17:02:02 +02:00
Mislav Marohnić
3d58fa785f
Add the release view --web flag
2020-09-09 17:01:29 +02:00
Mislav Marohnić
ad0bbde351
Merge remote-tracking branch 'origin' into release-cmd
2020-09-09 15:27:49 +02:00
Daniel Leong
c7e702203b
Update template test to reflect inclusion of "default" text
...
Also, avoid excessive amounts of newlines separating the two
2020-09-08 20:25:52 -04:00
Daniel Leong
41543b564d
"Check" the error value of ioutil.WriteFile
...
We could, alternatively, use t.Fatal... this matches the MkdirAll
invocation from github_template_test, however...
2020-09-08 20:12:28 -04:00
Daniel Leong
a33124414c
Add a test to verify the behavior of prepending commit body to message
2020-09-08 20:12:28 -04:00
Daniel Leong
c4227455e3
Prepend PR body defaults to the selected template (if any)
...
See #1570
2020-09-08 20:12:28 -04:00
Nate Smith
74614b13da
Merge pull request #1627 from giacomoalbe/add-commit-headline-to-pr-merge
...
Add PR Title to CommitHeadline during merge PR
2020-09-08 17:05:26 -05:00
Nate Smith
c2d7cbf51f
Merge pull request #1582 from AliabbasMerchant/interactiveCreationTests
...
Interactive template selection test for issue create
2020-09-08 16:55:04 -05:00
Nate Smith
ab2c38eb82
Merge pull request #1563 from cli/checks
...
gh pr checks
2020-09-08 15:58:38 -05:00
Mislav Marohnić
72e9747662
Merge pull request #1626 from cli/ghe-auth-tweaks
...
Make GitHub remote parsing and authentication stricter
2020-09-08 10:14:29 +02:00
Mislav Marohnić
d77a8c2e61
Scope pr merge commit headline to only squash method
2020-09-07 22:27:27 +02:00
Mislav Marohnić
fae66a62e4
Fix measuring terminal width for output
2020-09-07 22:03:54 +02:00
Mislav Marohnić
ece17c4ce2
Add GITHUB_ENTERPRISE_TOKEN mention to api help
2020-09-07 21:37:55 +02:00
Mislav Marohnić
c80292c2e8
Extend Config object with GITHUB_TOKEN support
...
Adding GITHUB_TOKEN & GITHUB_ENTERPRISE_TOKEN support orthogonal to
Config was getting out of hand, especially in `auth` commands that
adjust their messaging and error status based on the presence of these
environment variables.
The new approach builds in support for tokens from environment straight
into Config object by composition. Thus, commands need not ever be
concerned with any specific environment variables.
2020-09-07 21:33:26 +02:00
Mislav Marohnić
feadf684fb
Merge remote-tracking branch 'origin' into ghe-auth-tweaks
2020-09-07 17:37:16 +02:00
Mislav Marohnić
9109b68344
Merge pull request #1625 from cli/api-no-accept
...
Avoid setting a default `Accept` header in `hub api`
2020-09-07 17:30:12 +02:00
Mislav Marohnić
5e11fe8fa0
Merge pull request #1623 from bdougie/bdougie-filter-credit-bots
...
Filter gh credits for humans
2020-09-07 11:44:59 +02:00
Brian 'bdougie' Douglas
d83c99f87f
filter by contributor type
2020-09-06 22:02:02 -07:00
Mislav Marohnić
995828abf8
Avoid setting a default Accept header in hub api
...
Due to our HTTP client default behavior, an `Accept` header is added to
all API requests. This is fine for all commands except `gh api`, where
the user should ideally have fine-grained control over most aspects of
HTTP requests and where there should be little to no defaults in general.
2020-09-04 17:42:57 +02:00
Mislav Marohnić
2bb5e052d8
Send GITHUB_TOKEN to github.com and GITHUB_ENTERPRISE_TOKEN to GHES
2020-09-04 17:25:37 +02:00
vilmibm
eb132a1ae6
Merge remote-tracking branch 'origin/trunk' into checks
2020-09-03 14:48:32 -05:00
Mislav Marohnić
a470d49c64
Fix reporting release URL when creating with assets
2020-09-03 16:06:28 +02:00
Mislav Marohnić
1ad9b0b14e
Have FindDraftRelease be truer to its name
2020-09-03 15:35:07 +02:00
Mislav Marohnić
d4b45c68e2
Allow downloading assets from the latest release
2020-09-03 15:34:10 +02:00
Mislav Marohnić
151a7340a6
Fix .zip and .js overrides for Windows
2020-09-03 11:44:54 +02:00
Mislav Marohnić
02a057a709
Try fixing Windows tests
2020-09-02 22:11:46 +02:00
Mislav Marohnić
1f86e7cd04
Fix display width of common punctuation characters
...
These characters get classified as "East Asian Mixed" by Go's
`text/width` package, and thus assumed that their printed version
occupies a width of 2 characters, whereas they each only occupy one.
I'm not sure why they are classified as East Asian, but I did not have
the energy to dive into Go's Unicode tables, so here is a workaround
based on an exclusion list.
2020-09-02 20:59:11 +02:00
vilmibm
2961c655fb
review feedback
2020-09-02 11:33:39 -05:00
Mislav Marohnić
abf83c02c0
Merge pull request #1606 from cli/ghe-oauth-422-response
...
Handle HTTP 422 response to OAuth Device flow detection
2020-09-02 13:12:11 +02:00
AliabbasMerchant
9e7279604d
Fix failing tests for Windows (due to line-ending issues)
2020-09-02 10:03:56 +05:30
AliabbasMerchant
51c5595cad
Interactive template selection test for PR create
2020-09-02 09:56:28 +05:30
Mislav Marohnić
4976bd75e1
Fix date-based release output and tests
2020-09-01 19:09:10 +02:00
Mislav Marohnić
0f42c7af4d
Add tests for release create, delete, download, view
2020-09-01 18:56:30 +02:00
nate smith
49ab3ec5bf
check for tty before creating colorables
2020-09-01 11:18:34 -05:00
Nate Smith
734959c39d
Merge pull request #1603 from cli/create-pr-metadata-failure
...
Be transparent about which part of `pr create` flow failed
2020-09-01 10:51:55 -05:00
Mislav Marohnić
9ef1791fdb
Provide machine-readable release view output
2020-09-01 15:23:43 +02:00
Mislav Marohnić
d0d9cc2f9b
View latest release if no tag provided
2020-09-01 14:16:59 +02:00
Mislav Marohnić
48a827ee34
Tweak gh config set -h output format on auth login
2020-09-01 13:19:30 +02:00
Mislav Marohnić
0de3f678bc
Only validate --hostname when flag was provided
2020-09-01 13:19:19 +02:00
Mislav Marohnić
b029397d32
Validate the --hostname flag value
2020-09-01 13:06:13 +02:00