Kynan Ware
e30244686c
Merge pull request #10680 from cli/kw/update-go-gh-and-document-sprig-funcs
...
Update go-gh and document available sprig funcs
2025-03-28 12:22:14 -06:00
Kynan Ware
c1fbc2f05b
test(many): fix whitespace in tests expectations
...
Due to https://github.com/charmbracelet/glamour/pull/334 , the margin
used for markdown rendering has changed by a couple spaces. This
corrects the relevant tests to accomodate that change.
2025-03-27 14:21:13 -06:00
Andy Feller
79f1b07fb1
Implement and fix tests for table headers
2025-03-25 15:29:05 -04:00
Andy Feller
6355e54e3c
Ensure table headers are thematically contrasting
...
This commit refactors the color format around table headers to ensure the GitHub CLI uses thematically appropriate colors based on dark background, light background, or no color at all.
In order to do so, `ColorScheme` needs information from the terminal about the background appearance (dark, light, none) to determine appropriate muted color.
2025-03-21 11:51:03 -04:00
Tyler McGoffin
0bb92c5980
Separate partitioning from globbing in cmdutil/args package and consumers ( #3 )
...
* Separate partitioning from globbing in cmdutil/args package and consumers
In the previous commit, GlobPaths was overloaded, containing logic
specific to command use-cases. This commit removes that functionality from
GlobPaths and back into the commands that have the special use-cases.
To do this, I've introduced a new Partition util in cmdutil/args.go that
will separate a slice into two slices given a predicate. This functionality
is leveraged by both the special use-cases described above to separate the
command-specific syntax from the globable filepaths.
* Add test to validate that the order of '-' in gh gist create args doesn't matter
2025-03-04 07:05:23 +05:00
Azeem Sajid
db3df04068
Merge branch 'trunk' into 5099-gh-release-create-upload-expand-glob-patterns-on-windows
2025-02-27 19:20:44 +05:00
Andy Feller
f9d50d86ac
Merge pull request #10508 from iamazeem/10449-inconsistent-examples-format
...
Inconsistent format of examples in help text
2025-02-27 09:15:14 -05:00
Azeem Sajid
33c30d5bd1
Inconsistent format of examples in help text
2025-02-27 16:26:25 +05:00
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) ( #10507 )
2025-02-27 11:40:21 +01:00
Azeem Sajid
f4b65b785e
Add exclude callback function
2025-02-26 12:46:56 +05:00
Azeem Sajid
8ace163608
Remove slicing
2025-02-25 10:49:28 +05:00
Azeem Sajid
092eb7e962
Support globbing for all platforms
2025-02-22 12:16:42 +05:00
Tyler McGoffin
8748bb0b1a
Add testing to GlobWindowsPaths ( #2 )
2025-02-21 22:33:19 +05:00
Azeem Sajid
0fb87903e5
Update usage to lower-kebab-case
2025-02-14 22:12:22 +05:00
Azeem Sajid
8b7fb231ec
Remove trailing whitespace
2025-02-13 11:06:27 +05:00
Azeem Sajid
d9bfa606cc
Fix gh gist create for multiple filenames and glob patterns
2025-02-11 12:56:32 +05:00
Otto Kekäläinen
b19e682455
Update test to be compatible with latest Glamour v0.8.0
...
Latest Glamour has slightly changed logic in line length / wrapping,
resulting test failures due to string mismatch. Update tests and bump
dependency to v0.8.0, and others to the bare minimal level as generated
by `go mod tidy`.
This was detected then building the GitHub cli package `gh` in Debian
started to fail with src:golang-github-charmbracelet-glamour 0.8.0-1.
Closes : #10179
2025-01-22 20:13:40 -08:00
Kynan Ware
facd0caa29
Fix: accidental whitespace in gist edit
2025-01-16 11:44:46 -07:00
Kynan Ware
5b6fd53a88
Fix: gist edit test name
2025-01-16 11:36:48 -07:00
Kynan Ware
dec46670bb
Fix: gist edit/view tests var name consistency
2025-01-16 11:14:33 -07:00
Kynan Ware
a2dce589d6
Merge 'trunk' into fix/issue_10042
2025-01-16 11:06:36 -07:00
Kynan Ware
35d81e3ff5
Fix: Gist edit tests for interactivity
...
This changes the gist edit tests to use the positive `istty` instead of the previous inverse `nontty`, which is consistent with the way other commands are written.
2025-01-16 10:46:07 -07:00
Tyler McGoffin
3feeb9a826
Add tests for deleteGist
2025-01-14 14:21:49 -08:00
Mateus Marquezini
c0f6eb0598
#10042 : Attempt to add a new test scenario for handling error messages when TTY is unavailable
2025-01-13 11:39:48 -03:00
Mateus Marquezini
977e2326a2
#10042 : Applied code review suggestions to view_test.go
2025-01-13 11:06:13 -03:00
danochoa
1d9b4e4464
fix tests
2025-01-12 19:36:44 -06:00
danochoa
08f7706c42
fix tests
2025-01-12 19:18:24 -06:00
danochoa
7885167c70
gist delete - check no gists
2025-01-12 17:01:45 -06:00
Mateus Marquezini
24e9fed7e0
removed unnecessary space
2025-01-12 14:57:24 -03:00
Mateus Marquezini
c5d6ae6cf6
Update pkg/cmd/gist/edit/edit.go
...
Update pkg/cmd/gist/edit/edit.go after code review
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-01-12 14:53:20 -03:00
danochoa
5de282c970
drop description from prompts, fix tests
2025-01-11 01:35:12 -06:00
danochoa
7f71681ace
gist delete - use in confirmation and success info
2025-01-10 01:07:11 -06:00
Mateus Marquezini
4c2ba5681d
#10042 removed unnecessary field
2025-01-09 13:14:27 -03:00
Mateus Marquezini
f4f8840c3f
#10042 : Add error messages for 'gh gist view/edit' prompts when no TTY is detected
2025-01-09 12:07:15 -03:00
danochoa
dccbc99fdf
fix gist description in tests
2025-01-08 20:47:50 -06:00
danochoa
9c65a32ef8
gist delete prompt with gist description
2025-01-08 17:56:02 -06:00
danochoa
a8f0aaeb3d
tentative updates for acceptance criteria
...
- pending confirmation re description in prompt
2025-01-08 02:22:21 -06:00
danochoa
75ace410a3
cleanup
2025-01-03 13:09:32 -06:00
danochoa
f87d9f98f1
gist delete prompt for confirmation
2025-01-03 12:51:09 -06:00
danochoa
61ffbe157d
undo extra move
2024-12-31 01:43:39 -06:00
danochoa
8390b4154b
rearrange struct vals for consistency
2024-12-30 18:18:50 -06:00
danochoa
8f19d3b102
add gist delete tests for blank gist id
2024-12-30 17:24:10 -06:00
danochoa
049332d844
gh gist delete: prompt for gist id
2024-12-30 15:41:18 -06:00
Mateus Marquezini
b740486b13
#10042 fixed test
2024-12-09 10:59:09 -03:00
Mateus Marquezini
cbaaf77822
fixing gh gist view prompts with no TTY
2024-12-09 08:35:01 -03:00
Tyler McGoffin
7aef6ec391
Merge pull request #9728 from heaths/issue9704
...
Supporting filtering on `gist list`
2024-10-15 16:26:13 -07:00
Heath Stewart
446f66070a
Add filtered content output to docs
2024-10-15 14:39:21 -07:00
Tyler McGoffin
ddf90c78c2
Remove IsTenancy and relevant tests from gists as they are unsupported
2024-10-15 12:41:23 -07:00
Tyler McGoffin
e1a39d8e2b
Add ghe.com to tests describing ghec data residency
2024-10-15 12:24:41 -07:00
Tyler McGoffin
81591a09b8
Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname
2024-10-15 11:56:43 -07:00
