Commit graph

3711 commits

Author SHA1 Message Date
Gowtham Munukutla
cc94dc762d shift gist validation to server rather than client 2021-05-07 14:12:00 +02:00
Cristian Dominguez
2f94adabb2
Use T.TempDir for temporary dirs in tests (#3580) 2021-05-07 12:21:26 +02:00
Gowtham Munukutla
97f80740aa remove extra quotes 2021-05-07 11:17:23 +05:30
Gowtham Munukutla
0437a69967 add column headers and age column in listing runs 2021-05-04 10:51:07 +05:30
Mislav Marohnić
25d79c4e16
Merge pull request #3525 from cristiand391/improve-issue-status-detection
Improve issue status detection
2021-05-03 21:04:35 +02:00
Cristian Dominguez
796d2e24ef Bring back Closed field 2021-04-30 17:32:16 -03:00
Mislav Marohnić
9bdc63c4ca Eliminate API overfetching in pr commands
This completely rewrites the PR lookup mechanism so that the caller
must specify the GraphQL fields to query for each PR. Additionally, this
fixes some export problems with `pr view --json`.

Features:

- Each pr command now gets assigned a concept of a Finder. This makes it
  easier to stub the PR in tests without having to stub the underlying
  HTTP calls or git invocations.

- `pr view --web` is much faster since it only fetches the "url" field.

- `pr diff 123` now skips a whole API call where a whole PR was
  unnecessarily preloaded just to access its diff in a subsequent call.

- PullRequestGraphQL query builder is now used to construct queries.

- A bunch of individual commands are now freed of having to know about
  concepts such as BaseRepo, Branch, Config, or Remotes.
2021-04-30 20:34:36 +02:00
Mislav Marohnić
011e455b73
Merge pull request #3536 from rneatherway/rneatherway/placeholder-syntax
Support standard path variable replacement syntax
2021-04-30 14:29:10 +02:00
Mislav Marohnić
6a57dcfd7d 💅 cleanup placeholder implementation 2021-04-30 14:22:25 +02:00
Robin Neatherway
59b4d5cb7c Support standard path variable replacement syntax
Add support for the following synonyms:

{owner} for :owner
{repo} for :repo
{branch} for :branch
2021-04-30 14:22:25 +02:00
Mislav Marohnić
d478a65254
Merge pull request #3530 from tklauser/x-term
Use golang.org/x/term
2021-04-30 11:57:01 +02:00
Nate Smith
6b9a8608f6
Merge pull request #3537 from cli/incorrect-function
catch mintty error and add help for it
2021-04-29 16:11:58 -05:00
nate smith
9f451d9eef review feedback 2021-04-29 16:06:26 -05:00
nate smith
f4592e3f94 Revert "ignore gh.exe"
This reverts commit 15c16bd12a.
2021-04-29 16:01:15 -05:00
nate smith
15c16bd12a ignore gh.exe 2021-04-29 10:59:56 -05:00
nate smith
9110db7f7e fill in help topic 2021-04-29 10:58:40 -05:00
Mislav Marohnić
d1d49c1810
Merge pull request #3529 from cli/milestone-export-fix
Fix exporting `milestone` for issues and PRs
2021-04-29 11:52:15 +02:00
nate smith
02e9fa086d start on incorrect function error handling 2021-04-28 13:59:54 -05:00
Nate Smith
d5954e2e94
Merge pull request #3499 from cli/secret-prompt
tweak secret set to allow prompting
2021-04-28 13:28:33 -05:00
Nate Smith
cc7c2f2c9d
Merge pull request #3517 from cli/watch-404
handle 404 for annotations
2021-04-28 13:27:04 -05:00
Tobias Klauser
b586d51778 Use golang.org/x/term
The golang.org/x/crypto/ssh/terminal package is deprecated and merely a
wrapper around golang.org/x/term. Use the latter directly.
2021-04-28 18:44:36 +02:00
Mislav Marohnić
a8e025291f Fix exporting milestone for issues and PRs
There was a weird pointer bug which would cause a null milestone to
erase "milestone" fields for previous entries in the list.
2021-04-28 18:28:18 +02:00
Cristian Dominguez
6b49e21295 Improve issue status detection 2021-04-28 00:30:21 -03:00
Mislav Marohnić
9436990e18
Merge pull request #3524 from sgerrand/cmd-docs-updates
Fixes typo in `pr create` docs
2021-04-27 18:38:23 +02:00
Sasha Gerrand
f70bdcf982
Corrects a typo in pr create docs 2021-04-27 11:57:42 +01:00
vilmibm
00da7f9fc1 handle 404 for annotations 2021-04-26 16:55:08 -05:00
Nate Smith
ac0fe6bf71
Merge pull request #3490 from heaths/issue3487
Optionally read stdin for `gh alias set`
2021-04-26 16:40:07 -05:00
Heath Stewart
aaa5a9e949 Use - to read from stdin instead
Resolves PR feedback.
2021-04-23 17:23:27 -07:00
vilmibm
3e36596269 ability to paste secrets in a prompt 2021-04-23 13:07:20 -05:00
Nate Smith
5a2ec54685
Merge pull request #3494 from cli/pr-list-example
add some more examples for pr list
2021-04-23 11:51:07 -05:00
Nate Smith
bf7ed68aa8
Merge pull request #3495 from cli/release-create-eg
add some more examples for release create
2021-04-23 11:50:46 -05:00
vilmibm
47ed41bfcd add some more examples for release create 2021-04-22 15:26:26 -05:00
vilmibm
c69f210807 add some more examples for pr list 2021-04-22 14:45:19 -05:00
Mislav Marohnić
9ee580de86
Merge pull request #3491 from junjieyuan/trunk
using filepath.Join() instead of path.Join() to fix wrong filepath on Windows
2021-04-22 13:33:40 +02:00
Mislav Marohnić
c57e30fff0 Fix stubbing config in tests on Windows 2021-04-22 11:42:51 +02:00
Mislav Marohnić
c6c3e72f43 Unexport StubConfig 2021-04-22 11:42:28 +02:00
Junjie Yuan
927e4c7e4d
using filepath.Join() instead of path.Join() to fix wrong filepath on Windows:
PS C:\Users\Junjie Yuan> gh auth status
github.com
  ✓ Logged in to github.com as junjieyuan (C:\Users\Junjie Yuan\.config\gh/hosts.yml)
  ✓ Git operations for github.com configured to use https protocol.
  ✓ Token: *******************

Signed-off-by: Junjie Yuan <yuan@junjie.pro>
2021-04-22 15:19:16 +08:00
Heath Stewart
bd2738379b Optionally read stdin for gh alias set
Resolves #3487
2021-04-21 22:16:41 -07:00
Nate Smith
5821065ac0
Merge pull request #3419 from zxaos/patch-1
add Debian install variant without add-apt-repository
2021-04-20 12:13:59 -05:00
Nate Smith
f65af1473e
Merge pull request #3438 from invakid404/trunk
Add Funtoo Linux install instructions
2021-04-20 11:54:00 -05:00
Nate Smith
67d179ee84
Merge pull request #3465 from darkRaspberry/patch-1
linuxbrew details added in linux installation docs.
2021-04-20 11:52:38 -05:00
Mislav Marohnić
a3a7deadb8
Merge pull request #3400 from embano1/patch-1
Add note on supported value types in raw-fields
2021-04-20 18:49:41 +02:00
Mislav Marohnić
47b7987772
Merge pull request #3402 from cristiand391/remove-unused-embedded-struct
Remove unused embedded struct
2021-04-20 18:48:19 +02:00
Nate Smith
929b584003
Update docs/install_linux.md 2021-04-20 11:47:22 -05:00
Nate Smith
2872e79a4f
Update docs/install_linux.md 2021-04-20 11:47:17 -05:00
Nate Smith
d09896468d
Merge pull request #3351 from cristiand391/fix-pr-reopen
Fix detecting PR status when passing branch as arg
2021-04-20 11:41:16 -05:00
Nate Smith
882c08104d
Merge pull request #3472 from cli/issue-create-web-fix
Fix `issue create --web`
2021-04-20 11:39:48 -05:00
Nate Smith
754dc109d0
Merge pull request #3468 from cli/actions-remote
include magic repo resolution magic for workflow and run
2021-04-20 10:30:11 -05:00
Sam
aea6163a83
Merge pull request #3445 from adamslc/log_fix
Fix `run view --log` when steps have slashes
2021-04-20 08:13:26 -07:00
Sam Coe
75227f44d1
linter 2021-04-20 08:05:19 -07:00