Commit graph

32 commits

Author SHA1 Message Date
Babak K. Shandiz
37896d613a
fix(featuredetection): remove redundant AdvancedIssueSearchWebInIssuesTab field
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-08 18:46:28 +01:00
Babak K. Shandiz
43bedab2dc
docs(featuredetection): remove unknown dates
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-08 18:39:55 +01:00
Babak K. Shandiz
d56a902a07
docs(featuredetection): add godoc for min GHES version for advanced issue search
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-02 12:09:38 +01:00
Babak K. Shandiz
87bd76c5aa
docs: add cleanup/future TODO marks for advanced issue search changes
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-01 13:55:49 +01:00
Babak K. Shandiz
0104d8c0db
refactor: improve mock feature detector names
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 13:57:47 +01:00
Babak K. Shandiz
e9b3ac364a
test(featuredetection): add tests for advanced issue search detection
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-30 15:51:57 +01:00
Babak K. Shandiz
f16c267bad
fix(featuredetection): add feature detection for advanced issue search
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-30 15:51:16 +01:00
Andy Feller
d10251211c
Update feature_detection.go 2025-08-12 21:18:47 -04:00
Andy Feller
3bafd883b5 Update v1 project detection logic
This change updates the v1 project detection logic to retrieve the API version of GHES host to determine support.
2025-08-11 14:50:07 -04:00
Andy Feller
65c7ebc79e v1 project feature detection spike using version
These changes are demonstrating how `gh` commands that support v1 classic projects can determine if support exists by checking the GHES server version.
2025-07-28 17:16:56 -04:00
Kynan Ware
73e5589059 doc(issue): comment why assignable actors disabled 2025-05-12 11:37:37 -06:00
Kynan Ware
8ebbd1d4bf feat(fd): add ActorIsAssignable to IssueFeatures 2025-05-07 12:23:18 -06:00
William Martin
5ec2160bc6 Avoid requesting projectCards for issue view 2025-04-17 15:37:48 +02:00
Tyler McGoffin
e1a39d8e2b Add ghe.com to tests describing ghec data residency 2024-10-15 12:24:41 -07:00
Tyler McGoffin
81591a09b8 Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname 2024-10-15 11:56:43 -07:00
Tyler McGoffin
3a8417f6c7 Add test coverage to places where IsEnterprise incorrectly covers Tenancy
IsEnterprise currently returns `true` when `IsTenancy` returns true. We
prefer that this behavior is orthogonal. This commit adds failing tests to
the instances where IsEnterprise should not behave the same as IsTenancy.

These test cases are expected to pass with the inclusion of the coming
improvements to go-gh to handle the orthogonality of IsEnterprise and
IsTenancy.
2024-10-15 11:56:43 -07:00
Viktor Szépe
6d9dd57774 Fix typos 2024-05-09 20:15:27 +00:00
Sam Coe
ad283cff72
Fix pr checks command for GHES versions older than 3.9 (#7725) 2023-07-19 09:25:07 -07:00
William Martin
505c954544 Remove unused emptyIntrospectionFor test helper 2023-05-23 17:13:48 +02:00
William Martin
b02d5efb18 Use two queries in one request for PR feature detection 2023-05-23 15:42:38 +02:00
William Martin
42b61ad53e Inject fake detector into PR status tests 2023-05-22 18:44:51 +02:00
William Martin
bfd3c7b20b Short circuit status check GQL introspection for GitHub.com 2023-05-17 18:45:25 +02:00
William Martin
c2e3dae602 Add support for detecting status and check counts in GQL 2023-05-17 18:45:25 +02:00
William Martin
7e2bac89bd
Remove old, unused detector fields (#7458) 2023-05-17 14:50:28 +02:00
Sam Coe
e14d14cef2
Add support for issue state reason (#6245) 2022-09-14 12:39:15 +04:00
Sam Coe
45f1a71c8b
Remove all direct calls to shurcool-graphql 2022-08-18 21:40:41 +03:00
Sam Coe
074ed50b8a
Integrate go-gh API package (#5614) 2022-06-23 04:05:31 +01:00
Mislav Marohnić
9351f272dc pr merge: fix merge queue API access for PAT consumers
The github.com API right now doesn't seem to make merge queue APIs
available to people who use PAT to authenticate gh requests. This
switches the conditional request strategy to also do feature-detection
for dotcom (instead of just for Enterprise).
2022-06-09 14:38:58 +02:00
Mislav Marohnić
4c6358dcbf Guard PR merge queue queries behind feature detection 2022-06-08 12:25:22 +02:00
Mislav Marohnić
80f130184c repo edit: fix interactive mode in GHES < 3.3 2022-06-07 17:54:52 +02:00
Sam Coe
33975a95e4
Allow repo list to work with GHES earlier than 3.3 2022-06-06 12:45:55 -05:00
Sam Coe
539b150833
Extract feature detection package (#5494) 2022-05-17 19:07:44 +00:00