Nate Smith
e91b97b4c5
fully restore fork remote renaming behavior ( #2982 )
...
* fully restore fork remote renaming behavior
* catch blank remote name and error + arg tests
* hard wrap fork usage
* do not rename if remote-name supplied
* tweak error text
2021-02-17 12:33:22 -06:00
ulwlu
95a8f926ab
Remove unnecessary Sprint
2021-02-13 18:10:38 +09:00
ulwlu
16be90c538
Fix unnecessary Sprintf with Sprint
2021-02-13 17:20:39 +09:00
ulwlu
e461baa217
Fix prompt string when creating remote repository
...
If you are in git project not pushed to remote yet,
prompt says 'This will create {reponame} in current directory. Continue?',
however, it doesn't create while it only adds remote origin.
I was going to create PR to avoid creating new directory before I knew
this behavior.
This behavior is already ideal, so I changed prompt not to scare users
like I got scared.
2021-02-13 17:11:08 +09:00
Mislav Marohnić
ab21dbeaf0
Improve repo create docs
...
- Clarify what will happen when in the git directory vs. out;
- List requirements for non-interactive use;
- Demonstrate how to turn issues/wiki off.
- Misc. formatting tweaks
2021-02-03 22:05:06 +01:00
Devon Romanko
2964895a77
fix test behavior changes from migration to run.Stub
2021-01-27 18:46:29 -05:00
Devon Romanko
696cbfc8d1
use Stub instead of SetPrepareCmd in 'repo create' tests
2021-01-27 07:59:32 -05:00
Nate Smith
6152d8a419
Merge pull request #2825 from cli/rename-fork
...
restore fork rename behavior for nontty case
2021-01-25 11:29:52 -08:00
vilmibm
26f6761481
add note about future behavior
2021-01-25 11:29:26 -08:00
Mislav Marohnić
f46bab256c
Rename to SuccessIconWithColor
2021-01-25 14:56:39 +01:00
vilmibm
d051f0634f
update tests
2021-01-22 16:13:39 -08:00
vilmibm
1fa3047b59
restore renaming behavior for nontty case
2021-01-22 16:12:25 -08:00
Mislav Marohnić
96fa6e7830
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-22 23:56:54 +01:00
Mislav Marohnić
23d68705bc
Match color of the success icon with the end state of the record
2021-01-22 23:55:33 +01:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
Nate Smith
29805a4003
Merge pull request #2588 from cdce8p/gh-clone-fetch
...
Only fetch default branch when adding upstream remote
2021-01-21 12:57:10 -08:00
vilmibm
b906826a68
i like trunk
2021-01-21 12:56:53 -08:00
vilmibm
dcedd32249
use newer command stubbing in tests
2021-01-21 12:32:40 -08:00
vilmibm
48c89076f6
add positive case test
2021-01-21 12:04:19 -08:00
vilmibm
a27a94f8b5
Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags
2021-01-21 11:58:20 -08:00
Sam
938f6f4bdd
Merge pull request #2809 from cli/deadcode
...
delete unused parameter
2021-01-21 09:56:15 -08:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
...
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
vilmibm
509e5dd0c9
fix tests
2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce
accept a remote name instead of doing magic remote naming in repo fork
2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140
Merge remote-tracking branch 'origin/trunk' into remote-renaming-847
2021-01-20 15:10:20 -08:00
Mislav Marohnić
aa0de5f636
Stop using utils.Spinner in repo fork
2021-01-20 14:46:45 +01:00
vilmibm
3797aa72ff
delete unused parameter
2021-01-19 19:08:49 -08:00
Mislav Marohnić
75ebb863e3
Use testify assertions for error matching
2021-01-19 13:59:37 +01:00
Mislav Marohnić
fc77cbc964
Deprecate test.ExpectLines
...
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
c308f1cd91
Prevent further use of SetPrepareCmd and InitCmdStubber
2021-01-18 22:44:53 +01:00
Mislav Marohnić
5531498f27
Migrate to new cmd stubber in repo fork tests
2021-01-18 22:42:27 +01:00
Mislav Marohnić
584b33e79c
Migrate to new cmd stubber in repo clone tests
2021-01-18 22:42:13 +01:00
Mislav Marohnić
c63acf6728
Migrate to new cmd stubber in misc. tests
2021-01-18 22:42:01 +01:00
Cristian Dominguez
ce151420f3
Migrate legacy tests
2021-01-11 21:07:19 -03:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. ( #2671 )
...
This addresses issue #2587 .
2021-01-05 14:40:52 -08:00
Mislav Marohnić
39a0a8c57c
Improve clone wiki test
2020-12-15 17:45:13 +01:00
gunadhya
fd57835bb9
Fix repo clone wiki
2020-12-15 17:45:03 +01:00
cdce8p
f536901bc1
Only fetch DefaultBranchRef when adding upstream remote during gh repo clone
2020-12-09 20:15:21 +01:00
Josh Soref
ec82d3c47e
spelling: settings
2020-11-21 21:43:51 -05:00
Josh Soref
e58b2dbe92
spelling: chestnuts
2020-11-21 21:43:51 -05:00
Nate Smith
05a1a25271
match parent repo protocol when forking ( #2434 )
...
* match parent repo protocol when forking
* guard against nil and prefer PushURL
2020-11-20 12:00:49 -06:00
dfireBird
e513333fb1
feat: implement prompt for remote renaming
2020-11-17 00:13:26 +05:30
Mislav Marohnić
6a0d38df44
Merge pull request #2404 from alissonbrunosa/fix-repo-view-command-with-branch
...
Generate correct URL when branch option is passed in
2020-11-13 13:05:56 +01:00
Alisson Santos
62e560d6ee
add empty line between functions
2020-11-13 10:24:17 +01:00
Alisson Santos
9ecc902959
Generate correct URL when branch option is passed in
2020-11-13 10:20:30 +01:00
boonhong
57ec879aea
Fix typos
2020-11-12 22:32:36 +08:00
Mislav Marohnić
5b4a08dcb9
Ensure that only PATH is searched when shelling out to external commands
...
Works around https://github.com/golang/go/issues/38736 for Windows.
2020-11-11 16:33:13 +01:00
Cristian Dominguez
fa8674386b
Render links as absolute URLs in repo view ( #2363 )
...
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2020-11-11 13:13:19 +01:00
Cristian Dominguez
07bd647211
Update repo fork help msg
2020-11-04 12:14:02 -03:00
Cristian Dominguez
97aa0b2f7d
Warn when passing git flags without repository arg
2020-11-04 12:10:35 -03:00