Commit graph

249 commits

Author SHA1 Message Date
Corey Johnson
d209c0be01 Allow pr urls 2020-05-19 11:04:43 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:29 -07:00
Corey Johnson
b42f5527fd Remove hot dog 2020-05-18 13:27:23 -07:00
Corey Johnson
78bc7260e0 Add closed test 2020-05-18 13:08:57 -07:00
Corey Johnson
0b0070e725 Add "already marked" test 2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0 Can be marked ready for review 2020-05-18 12:42:16 -07:00
Corey Johnson
fad9f24f39 Make reopen work 2020-05-18 11:11:13 -07:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai
Add support for `gh pr merge`
2020-05-12 10:18:54 -07:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view
Add Reviewers to pr view in CLI
2020-05-08 14:46:08 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash
Fix `pr status -R` crash with closed PR on the default branch
2020-05-08 14:23:51 -05:00
Corey Johnson
43e15130f1 Use a var 2020-05-08 11:37:45 -07:00
Corey Johnson
b9c4a76687 Update usage docs 2020-05-08 11:20:00 -07:00
Mislav Marohnić
93c61a83b2 Fix pr status -R crash with closed PR on the default branch
At the time we have a reference to `baseRepo`, we might still not have
contacted the API nor obtained any information about the default branch
for the repository. This expands the `PullRequests()` query to always
report the default branch so we may choose how to render entries that
belong on the current branch.
2020-05-07 20:53:03 +02:00
Corey Johnson
58663dccfd Better description 2020-05-07 10:31:05 -07:00
Corey Johnson
5b78d47306 Use stdout 2020-05-07 10:30:59 -07:00
Corey Johnson
4b2f14d939 Use PR if given 2020-05-07 10:30:51 -07:00
Corey Johnson
1ea38af79c Fix merge usage syntax 2020-05-07 10:30:31 -07:00
Corey Johnson
2041f0ab1b Fix usage syntax 2020-05-07 10:30:23 -07:00
Corey Johnson
bcf41fd5e7 Fix sentence case 2020-05-07 10:30:14 -07:00
Corey Johnson
1de57db74d Fix lint error 2020-05-06 11:27:41 -07:00
Corey Johnson
5a04679535 Remove debug output 2020-05-06 11:21:05 -07:00
Corey Johnson
8c85e14bac Make it work without a PR number 2020-05-06 11:19:00 -07:00
Corey Johnson
8681e7a7b6 Make squash and rebase work 2020-05-05 15:09:02 -07:00
Corey Johnson
c0831d4c4f Add merge api call 2020-05-05 11:56:45 -07:00
Corey Johnson
0aca0eff1f Add merge code 2020-05-05 11:35:27 -07:00
Mislav Marohnić
1834d8cfd5 Tweak syntax in issue/pr close docs
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Daniel Foad
e7e3a4f9b1
pr comments 2020-05-04 23:47:47 +01:00
Corey Johnson
fef11b3489 Merged prs return error 2020-05-04 10:44:20 -07:00
Corey Johnson
2f075fca73 Return an error if the pr was already merged 2020-05-04 10:25:38 -07:00
Corey Johnson
5cc60c669e Take in a pointer 2020-05-04 10:19:54 -07:00
Corey Johnson
1e88226b2b Add space 2020-05-04 10:16:30 -07:00
Corey Johnson
083693bc05 Update usage string 2020-05-04 10:15:47 -07:00
Corey Johnson
f7be93b135 use less words 2020-05-04 10:11:24 -07:00
Corey Johnson
1ee31db033 Add "merged" message 2020-05-04 10:10:03 -07:00
Corey Johnson
846425fe5e simplified boolean comparison 2020-05-01 14:16:49 -07:00
Corey Johnson
922352753a Add merged exit 2020-05-01 14:08:30 -07:00
Corey Johnson
bc623a7a23 Make it green 2020-05-01 12:07:23 -07:00
Corey Johnson
0bb1d2018a Add code to reopen 2020-05-01 12:00:13 -07:00
Corey Johnson
4bf778b136 require one arg 2020-04-30 11:41:39 -07:00
Corey Johnson
af6eaa8ca2 Hot dog 2020-04-30 11:41:32 -07:00
Corey Johnson
19f6c69854 Actually make it work 2020-04-30 11:27:11 -07:00
Corey Johnson
f9a55f4d8e Add close pull request code 2020-04-30 11:24:43 -07:00
Toshiya Doi
d2d0b47ecc Merge branch 'master' into reviewers-in-pr-view 2020-04-30 00:31:04 +09:00
Daniel Foad
09157f1fc7
unit tests 2020-04-28 00:03:21 +01:00
Daniel Foad
c62dd557e3
Filter closed/merged PRs on default branch 2020-04-27 21:14:00 +01:00
rista404
fab18ed4a9
Show awaiting triage when project col is empty 2020-04-25 22:57:03 +02:00
Toshiya Doi
67907c8b00 Support ghost reviews in pr view 2020-04-22 21:59:09 +09:00