Kynan Ware
70537de132
test(prompter): fix invalid comment
2025-04-10 17:18:56 -06:00
Kynan Ware
8cd39923fe
test(prompter): fix race condition
...
This test was trying to block on `expect`’ing a string at the same
time the prompt was completed.
This doesn't need to happen for this test. It should just check for
the output from the Input prompt invocation.
2025-04-10 17:09:22 -06:00
Andy Feller
b8cd094ca8
Ensure markdown confirm prompt shows editor name
...
Apparently, `gh` might not actually have an editor at the time we're prompting
the user if they want to use it for markdown editing. In the survey package,
there is a function that will handle fallback to the default editor based on
environment variables and parse it in the case the editor contains flags and
arguments for cases like Visual Studio Code.
Additionally, there are no tests for the EditorName function and the fact it
is loaded via `init` makes this difficult to test.
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-04-10 16:28:58 -06:00
Kynan Ware
20ff409bfc
fix(prompter): remove needless default value assignment
2025-04-10 16:28:57 -06:00
Kynan Ware
9eee77a2bf
test(prompter): doc how accessible prompter tests work
2025-04-10 10:55:24 -06:00
Kynan Ware
8b70870f4f
test(prompter): describe why echo is editorcmd
2025-04-10 10:39:59 -06:00
Kynan Ware
47d603221d
test(prompter): use *testing.T instead
2025-04-10 10:37:36 -06:00
Kynan Ware
fab0de5583
fix(prompter): pass io to huh and refactor tests
2025-04-09 15:51:02 -06:00
Kynan Ware
2f5e896535
fix(prompter): update huh and fix tests
2025-04-09 15:18:53 -06:00
Kynan Ware
8fc8486af5
refactor(prompter): rename speechSynthesizerFriendlyPrompter to accessiblePrompter
2025-04-09 08:24:54 -06:00
Kynan Ware
d230b08c43
test(prompter): re-add skipped test for accessible confirm default
2025-04-08 13:09:15 -06:00
Kynan Ware
19387b8418
fix(prompter): rename GH_ACCESSIBLE_PROMPTER
2025-04-08 12:52:39 -06:00
Kynan Ware
9cf341302e
refactor(prompter): explicit return values
2025-04-08 12:03:55 -06:00
Kynan Ware
8821f77fbb
doc(prompter): remove senseless comment
2025-04-08 12:00:02 -06:00
Kynan Ware
c4be95afd9
refactor(prompter): remove unused variable
2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9
test(prompter): timeout for tests is 1s
2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778
fix(prompter): use os.lookupenv for accessible prompter
2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86
test(prompter): remove needless NO_COLOR set
2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests
2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-07 14:53:31 -06:00
Kynan Ware
0543aac53c
test(prompter): add basic survey prompter test
2025-04-07 12:54:03 -06:00
Kynan Ware
2a851e33e8
test(prompter): fix race conditions
2025-04-07 11:59:05 -06:00
Kynan Ware
f89700160b
doc(prompter): clarify comments
2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467
refactor(prompter): less magic strings
2025-04-04 15:07:21 -06:00
Kynan Ware
2e48cadf58
fix(prompter): remove impossible condition
2025-04-04 15:05:23 -06:00
Kynan Ware
5c39e0bd10
fix(prompter): notes about Confirm default
2025-04-04 14:52:25 -06:00
Kynan Ware
4cf048a8d1
fix(prompter): input returns default when blank
2025-04-04 11:33:10 -06:00
Kynan Ware
5b0d49c6ec
test(prompter): more tests for bad input
2025-04-04 11:06:40 -06:00
Kynan Ware
a30df14b6a
refactor(prompter): rename env var for speech synthesizer friendly prompter
2025-04-03 13:08:16 -06:00
Kynan Ware
49ddacf5b8
docs(prompter): doc prompter interface
2025-04-03 13:06:31 -06:00
Kynan Ware
02fc12e7b7
fix(linter): linter errors
2025-04-03 08:51:54 -06:00
Kynan Ware
88e6285b49
test(prompter): move to external package
2025-04-03 08:45:58 -06:00
Kynan Ware
8827803bd1
test(prompter): skip vt10x tests on Windows
2025-04-03 08:25:33 -06:00
Kynan Ware
e299b56c0f
test(prompter): remove needless variable declaration
2025-04-02 13:08:36 -06:00
Kynan Ware
e42af35839
tests(prompter): rename huhprompter
2025-04-02 13:00:46 -06:00
Kynan Ware
0d7fd36f11
test(prompter): replace assert with require
2025-04-02 12:58:44 -06:00
Kynan Ware
94bbd26aab
fix(prompter): rename huhprompter
2025-04-02 12:56:44 -06:00
Kynan Ware
f7de9e0c11
test(prompter): go-expect based prompter tests
2025-04-02 12:56:44 -06:00
Kynan Ware
88a98ea63a
feat(prompter): include no as false-y value
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-02 11:58:10 -06:00
Kynan Ware
92b1a8e0f0
test(prompter): remove t.parallel calls
...
t.Parallel() cannot be used when env vars are being set.
2025-03-31 16:01:16 -06:00
Kynan Ware
e973ee332d
fix(md prompter): accessible prompt allows blank
...
Allow the accessible markdownEditor prompt to be blank when the blank
comes from the result of an interactive session with an editor, even when
blankAllowed is false.
This behavior aligns the accessible prompter with the behavior of the
current standard prompter.
2025-03-31 15:58:20 -06:00
Kynan Ware
7b0c09541d
feat(md prompter): md prompt respects blankAllowed
...
Accessible prompter now respects blankAllowed and
will not prompt for "skip" if blankAllowed is false.
2025-03-31 15:52:26 -06:00
Kynan Ware
202c1ad16b
feat(prompter): add accessible prompter support
2025-03-31 15:04:57 -06:00
Tyler McGoffin
13e916bcfb
Change prompts for gh auth login to reflect change from GHE to Other
2024-09-20 14:10:05 -07:00
William Martin
72d5550407
Implemented auth logout for multiaccount
2023-12-06 14:06:28 +01:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface ( #8246 )
2023-10-27 15:42:05 +02:00
Sam Coe
8016244dbb
Use go-gh prompter package ( #7896 )
2023-08-28 08:08:43 -05:00
Nate Smith
f2e5ad6dcd
fix RegisterPassword
2023-08-16 21:26:37 -05:00
Nate Smith
7d470c4df4
name MultiSelect parameters in interface
...
I wanted the parameters to show up in my autocomplete
2023-08-07 17:59:12 -07:00
vilmibm
3bd1d6770c
fix variable name
2023-05-24 12:40:46 -07:00
