Commit graph

2242 commits

Author SHA1 Message Date
Caleb Brose
83153fe9e5 Cleanups from PR comments 2022-06-14 14:33:41 +00:00
Caleb Brose
9f6e1c774b Check for key already exists 2022-06-13 19:31:44 +00:00
Caleb Brose
919dcebc45 Rename Context 2022-06-13 19:16:16 +00:00
Caleb Brose
b5580f9503 Refactor inferfaces from PR comments 2022-06-13 19:04:29 +00:00
cmbrose
ec58990715 Typo 2022-06-10 12:38:10 -05:00
cmbrose
e16a8adb6f Invert boolean 2022-06-10 11:14:19 -05:00
cmbrose
2c5532116d Restore empty flag 2022-06-07 12:38:01 -05:00
cmbrose
eebef06c67 Merge main and use func options again 2022-06-07 12:27:29 -05:00
cmbrose
9095556372 Merge remote-tracking branch 'upstream/trunk' into jungaretti/no-ssh-keys 2022-06-07 12:07:03 -05:00
cmbrose
60032db5eb Use function options pattern 2022-06-07 11:04:08 -05:00
Jonathan Fenwick
2abe1b3294
Remove auth logout confirmation prompt (#5751) 2022-06-07 15:26:53 +00:00
Greggory Rothmeier
f15a8ca335
Extract LiveshareSession interface (#5725)
This will make it possible to inject a mock liveshare session for testing
2022-06-06 15:52:52 +02:00
cmbrose
8e8632ddab Prepend flag for scp support 2022-06-03 14:24:15 -05:00
cmbrose
2209a84c9d More cleanup 2022-06-03 14:07:41 -05:00
cmbrose
2310795b3f Actually check err 2022-06-03 13:53:16 -05:00
cmbrose
f67ca53c07 Refactor ssh_keys to a more common location 2022-06-03 13:39:52 -05:00
Jeff Hubbard
866eccc202
Merge pull request #5705 from 8Gitbrix/users/ajeyaseelan/fix-edit-cmd
codespace edit: interactively choose a codespace
2022-06-03 10:04:31 -07:00
Fengyi Li
04ed77ddf0
Update prebuild availability status display at codespace creation (#5737) 2022-06-02 17:20:12 +00:00
Mislav Marohnić
afb69d2d31 cs edit: 💅 implementation and tests 2022-06-01 17:18:17 +02:00
JP Ungaretti
a1629c70c0 Generate codespaces key 2022-05-31 17:19:16 -07:00
cmbrose
ac630880c6 Refactor to WithOptions 2022-05-31 15:52:16 -05:00
JP Ungaretti
83a9b87397 Fix errors 2022-05-26 21:49:59 +00:00
JP Ungaretti
76090a2ea7 Add key to RPC call 2022-05-26 21:45:20 +00:00
Ashwin Jeyaseelan
61553e5e8a Added nit, removed last test due to survey.ask call wanting a terminal 2022-05-26 17:01:30 +00:00
Federico Guerinoni
b780608e90 Quote path of repo in order to have a valid copy paste command
Closes #5602
2022-05-26 12:12:56 +02:00
Greggory Rothmeier
77507cd94c
Bugfix: Retention period is being sent to the API as 0 (#5706)
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-05-25 17:36:27 +02:00
Mislav Marohnić
7859afb586 Fix Cobra completion output going to stdout 2022-05-25 14:57:47 +02:00
Ashwin Jeyaseelan
c2c4afdf6d Updated edit.go 2022-05-24 16:39:57 +00:00
Mislav Marohnić
cfaca91d06 Fix --version flag printing to stdout 2022-05-24 16:21:13 +02:00
Ahmed Adan
31bee2e639
Add --upstream-remote-name flag to gh replo clone (#5619) 2022-05-24 13:12:01 +02:00
Mislav Marohnić
eb4439d781
Merge pull request #5698 from cli/deprecation-stderr
Write Cobra deprecation messages to stderr
2022-05-24 12:36:18 +02:00
Heath Stewart
b54ff58382
Parallelize label clone (#5687) 2022-05-24 10:04:05 +02:00
Mislav Marohnić
2139e763fb Write Cobra deprecation messages to stderr
We used to do the equivalent of `rootCmd.SetOut(os.Stdout)` because we
thought that Cobra's "Out" stream represents standard output. However,
upon closer inspection it turns out that this is Cobra's stream for
usage errors and deprecation warnings, and those we want written to
stderr as well. It is not clear to me why Cobra maintains a distinction
between "Out" and "Err" streams since both seem to go to sdterr by
default.

This change also ceases our usage of `command.Print()` functions in
favor of explicitly writing to `IOStreams.Out/ErrOut`.
2022-05-23 20:23:42 +02:00
Josh Soref
7d99a98f02 Clarify that ShowResponseHeaders includes status line 2022-05-23 10:18:50 -04:00
Sam Coe
ebbf2ac096
Fix owner qualifier for search queries (#5693) 2022-05-23 13:00:32 +00:00
ffalor
3fb8579419
Add --pattern field to run download (#5539) 2022-05-23 08:57:57 +00:00
ffalor
2918c538b3
add include-all-branches flag to repo create (#5537) 2022-05-23 10:11:55 +02:00
Andrew Senetar
ff8aa8a555
Add ability to set title for ssh key in auth login (#5524) 2022-05-23 08:06:42 +00:00
Heath Stewart
3574240fa7
Always clear screen when watching PR checks (#5678) 2022-05-23 08:38:50 +02:00
Heath Stewart
f834b2a510
Fix label clone to pass orderBy (#5675) 2022-05-23 08:32:11 +02:00
Mislav Marohnić
4d9a6ecb25 pr create: ensure clear error when --body is missing in nonTTY mode 2022-05-18 19:13:59 +02:00
Heath Stewart
00e97121ec
Allow passing full extension name (#5464) 2022-05-18 08:35:47 +02:00
Curtis Tarr
bec49152cf
Fixing #5624 - Removing unneeded hint and additional new line (#5642) 2022-05-18 08:32:00 +02:00
Sam Coe
539b150833
Extract feature detection package (#5494) 2022-05-17 19:07:44 +00:00
Mark Phelps
669b0fa981 dont need assignment 2022-05-17 13:36:15 +00:00
Mark Phelps
48bb894277 filter out internal ports from gh cs ports list 2022-05-16 12:40:24 -07:00
Mislav Marohnić
c9503df123
Allow nil to truncate template function (#5656)
Fixes #5643
2022-05-16 19:05:17 +02:00
Josh Gross
b00bfce9cc
Support rerunning Actions runs with debug logging (#5594) 2022-05-16 19:01:53 +02:00
Heath Stewart
d9323c6d56 Allow nil to truncate template function
Fixes #5643
2022-05-16 08:58:20 -07:00
Josh Soref
104d7655d7
Support and favor delete for secrets (#5617)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-16 12:24:05 +00:00