Commit graph

7492 commits

Author SHA1 Message Date
William Martin
85e81a50da Comment further on config changes 2024-05-10 10:55:41 +02:00
William Martin
88631d13d4 Remove unnecessary config list variable 2024-05-10 10:49:07 +02:00
William Martin
bc5329e9db Fix mistaken find and replace for Option type 2024-05-10 10:48:45 +02:00
William Martin
07e0ff7127 Fix repo fork to use remote protocol if none configured 2024-05-10 10:48:36 +02:00
William Martin
d0e436b369 Avoid reconstructing config Options on each use 2024-05-10 10:48:24 +02:00
William Martin
8a4f32b4e2 Make config list less fallible 2024-05-10 10:48:17 +02:00
William Martin
8a82e3a856 Provide more type safety around config values 2024-05-10 10:48:11 +02:00
William Martin
1d38230675
Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
William Martin
2543c22463
Merge pull request #9068 from szepeviktor/typos
Fix typos
2024-05-10 07:37:34 +02:00
Viktor Szépe
6d9dd57774 Fix typos 2024-05-09 20:15:27 +00:00
Andy Feller
f11f096695
Merge pull request #8934 from babakks/8588-improve-run-list-doc
Improve `run list` doc with available `--json` fields
2024-05-08 17:01:16 -04:00
Meredith Lancaster
c9e8fd6c64
Fix attestation verify source repository check bug (#9053)
* add build source repo URI extension when repo is provided, add integration tests for this change

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add initial docs on specifying cert identity

Signed-off-by: Meredith Lancaster <malancas@github.com>

* wording

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add reusable workflow example

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add more test cases

Signed-off-by: Meredith Lancaster <malancas@github.com>

* tweak to verify docs

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
Co-authored-by: Phill MV <phillmv@github.com>
2024-05-08 07:44:52 -06:00
William Martin
08e8ee6746
Merge pull request #9059 from cli/wm/fix-unused-params
Fix unused params across project
2024-05-08 11:43:46 +02:00
William Martin
5007c18f5f Fix unused params across project 2024-05-07 17:50:43 +02:00
Babak K. Shandiz
4ac966f030
Fix test function name
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:35:54 +01:00
Babak K. Shandiz
05a87b9664
Add test to verify JSON fields section is rendered in Markdown
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:01:12 +01:00
Babak K. Shandiz
ad71f8cf9f
Output JSON Fields section in Markdown
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:00:54 +01:00
Babak K. Shandiz
5b99a4a2ec
Add test to verify JSON fields section is rendered
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:57:50 +01:00
Babak K. Shandiz
b445adae20
Add jsonCmd test command variable
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:57:12 +01:00
Babak K. Shandiz
2b304a5e84
Output JSON Fields section
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:56:37 +01:00
Babak K. Shandiz
9f9d0415da
Output JSON FIELDS
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:55:46 +01:00
Babak K. Shandiz
a3ff7791db
Add tests to verify proper help:json-fields annotations
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:55:19 +01:00
Babak K. Shandiz
506378cc21
Add help:json-fields annotation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:54:59 +01:00
Babak K. Shandiz
1e88ec55fc
Add FormatSlice function
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:54:21 +01:00
William Martin
4896546432
Merge pull request #8684 from shayn-orca/bugfix-7642
Added support for jobs with long filenames
2024-05-06 11:48:21 +02:00
William Martin
61a698a55a Add support for jobs with long filenames
Co-authored-by: John Basila <john@orca.security>
Co-authored-by: Shay Nehmad <shay.nehmad@orca.security>
2024-05-06 11:32:41 +02:00
Meredith Lancaster
6f350827d2
Run attestation command set integration tests separately (#9035)
* rename and add integration build tag

Signed-off-by: Meredith Lancaster <malancas@github.com>

* run tests that include integration build tag in workflow

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-02 08:07:44 -06:00
William Martin
65cfc684f8
Merge pull request #9034 from cli/dependabot/go_modules/golang.org/x/net-0.23.0
build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0
2024-05-01 17:13:11 +02:00
dependabot[bot]
fea08d194c
build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-01 15:04:39 +00:00
Andy Feller
a4353aca5f
Merge pull request #9032 from cli/9021-document-the-relationship-between-hosts-and-active-accounts-2
Document relationship between host and active account
2024-05-01 08:52:33 -04:00
William Martin
de394ec77c
Merge pull request #9033 from cli/wm/table-headers-no-mutate-wat
Do not mutate headers when initialising tableprinter
2024-05-01 14:19:43 +02:00
William Martin
4ca098b0c9 Adjust short and long to be the same 2024-05-01 14:17:08 +02:00
William Martin
cb357785dd Do not mutate headers when initialising tableprinter 2024-05-01 12:35:24 +02:00
William Martin
5a5b04d132 Document relationship between host and active account 2024-05-01 11:14:00 +02:00
Andy Feller
f2d6a8ec5c
Merge pull request #9030 from cli/wm/doc-clone
Document repo clone protocol behaviour
2024-04-30 09:03:11 -04:00
Andy Feller
1902b8be5c
Merge pull request #9023 from cli/andyfeller/go-gh-v2.9.0
Update cli/go-gh to v2.9.0
2024-04-30 08:59:10 -04:00
Andy Feller
d1f8c7d12e
Merge pull request #9025 from cli/phillmv/tweak-attestation-helpdocs
Tweaked gh attestation help strings to generate nicer cli manual site.
2024-04-30 08:57:21 -04:00
William Martin
825beef723 Document repo clone protocol behaviour 2024-04-30 08:22:49 +02:00
Phill MV
38ee906acc whitespace aligment for inspect/inspect.go 2024-04-29 16:40:30 -04:00
Phill MV
9523a99325 whitespace alignment in attestation/attestation.go 2024-04-29 16:38:35 -04:00
Phill MV
ce61fd8a06 Added tweaked note to tuf-root-verify 2024-04-29 16:31:28 -04:00
Phill MV
5619251faa Tweaked gh attestation help strings to generate nicer cli manual site. 2024-04-29 16:24:54 -04:00
Andy Feller
f5430ced2d
Merge pull request #9022 from cli/andyfeller/attestation-beta-usage
Add beta designation on attestation command set
2024-04-29 14:57:56 -04:00
Andy Feller
d51ae5ced9 Update attestation's beta designation 2024-04-29 14:45:20 -04:00
Andy Feller
2ef8232b9c Update cli/go-gh to v2.9.0
This change updates the GitHub CLI extension library with fixes for calculating display width and exporting tenancy and enterprising logic.
2024-04-29 14:14:59 -04:00
Andy Feller
57ca29b4b8
Merge pull request #9019 from cli/wm/attestation-host-checks
Be more general with attestation host checks
2024-04-29 13:44:21 -04:00
Andy Feller
0740c00f0a Add beta designation on attestation command set
With the `gh attestation` command set going into public beta, users should be reminded the feature is in beta and subject to change.

Both the short and long help usage are updated for individual command `--help` as well as `gh reference`.
2024-04-29 12:46:01 -04:00
Andy Feller
68dfd87f47
Merge pull request #9000 from cli/andyfeller/flag-level-disableauth
proof of concept for flag-level disable auth check
2024-04-29 12:15:49 -04:00
Andy Feller
cc36d32a21 Test gh at verify -b does not require auth
Thanks to @williammartin, this completes the PR by ensuring the actual feature this new logic was added for actually works as expected :D
2024-04-29 12:02:41 -04:00
William Martin
ef51cad663 Use ghinstance package for attestation host checks 2024-04-29 17:08:22 +02:00