STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4621 commits 87 branches 0 tags 160 MiB
Commit graph

27 commits

Author SHA1 Message Date
Jose Garcia
5b5c3da393 Validate host public keys 2021-09-30 08:16:28 -04:00
Mislav Marohnić
0483765da5 Merge pull request #190 from github/app-struct 
Introduce an App struct that executes core business logic
 2021-09-28 15:46:57 +02:00
Alan Donovan
57d9b1a9e1 create: decode JSON error heuristically 2021-09-27 14:51:52 -04:00
Mislav Marohnić
dc8f6ef183 No longer accept a logger in CreateCodespace 
The API layer shouldn't concern itself with logging progress to stderr.
Instead, we will subsequently add progress indicators in the caller
around CreateCodespace and other potentially slow commands as needed.
 2021-09-24 17:30:31 +02:00
Mislav Marohnić
ca0f89d3bc Introduce an App struct that executes core business logic 
The Cobra commands are now a light wrapper around the App struct.

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-24 17:20:34 +02:00
Mislav Marohnić
1232dba684 Merge remote-tracking branch 'origin' into raffo/delete-codespaces 2021-09-23 16:43:22 +02:00
Jose Garcia
186b90b12e Rename request type 2021-09-23 08:29:24 -04:00
Jose Garcia
13d7804a35 Remove API test, inline poller 2021-09-23 08:26:23 -04:00
Jose Garcia
9a558bc58c Early return if polling is not required 
- Add context to errors in poller
 2021-09-22 15:03:12 -04:00
Jose Garcia
208f1721b5 Rename ProvisionCodespaceParams 2021-09-22 13:21:02 -04:00
Jose Garcia
70a2ea2e6a PR Feedback 
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
 2021-09-22 13:19:26 -04:00
Jose Garcia
d2d21996bc Move ProvisionCodespace to API client 
- Make CreateCodespace private along with its errors
 2021-09-22 11:49:41 -04:00
Jose Garcia
8c5330d9e9 Rename error 2021-09-22 10:04:18 -04:00
Jose Garcia
2a0ea1617b Handle specific error for GetCodespaceToken 2021-09-22 09:40:45 -04:00
Jose Garcia
86717f14a1 Implement codespaces.Provision 
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
  is returned
 2021-09-22 09:09:09 -04:00
Mislav Marohnić
678da44c28 Simplify delete further 2021-09-21 21:09:26 +02:00
Mislav Marohnić
ab86739b6b Merge remote-tracking branch 'origin' into mislav/delete-codespaces 2021-09-21 20:35:58 +02:00
Jose Garcia
d5b03df406 Merge branch 'main' of github.com:github/ghcs into jg/poll-on-async-creation 2021-09-21 14:01:37 -04:00
Jose Garcia
0b68aaab7e Return error on 202 responses 
- Start implementing the retry/poll flow
 2021-09-21 09:59:16 -04:00
Alan Donovan
dbb80d8b1e check for authorised SSH keys 2021-09-20 16:01:43 -04:00
Raffaele Di Fazio
054fec0ba1 address code comments 
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
 2021-09-17 14:45:08 +02:00
Raffaele Di Fazio
455dabb484 use named params 
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
 2021-09-16 18:49:44 +02:00
Raffaele Di Fazio
22e9da790c Update internal/api/api_test.go 
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
 2021-09-16 18:43:16 +02:00
Raffaele Di Fazio
5cd90fea88 fix linter 
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
 2021-09-16 16:45:07 +02:00
Raffaele Di Fazio
68f4cad1af implement delete all with thresold 
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
 2021-09-16 16:42:53 +02:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00