STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8782 commits 87 branches 0 tags 160 MiB
Commit graph

4102 commits

Author SHA1 Message Date
petercover
bad7098cfe chore: fix some comments 
Signed-off-by: petercover <raowanxiang@outlook.com>
 2025-01-23 00:47:27 +08:00
William Martin
1bd07b9477
Merge pull request #10279 from mikelolasagasti/go-1.24-printf 
Bump golangci-linter and address failures to prepare for Go 1.24 strictness
 2025-01-22 12:08:39 +01:00
Tyler McGoffin
e0d3b9181a
Merge pull request #10227 from iamrajhans/rerun-err-msg 
show error message for rerun workflow older than a month ago
 2025-01-21 13:14:24 -08:00
William Martin
0a3706a404 Remove unncessary printf usage 2025-01-21 18:04:47 +01:00
William Martin
0ead3398a7 Bump golang ci lint to work with go 1.24 2025-01-21 17:55:39 +01:00
William Martin
ff922353bb
Merge pull request #10209 from cli/wm/add-remote-check-to-secret 
Require repo disambiguation for secret commands
 2025-01-21 15:24:49 +01:00
Rajhans Jadhao
211aaefc39
Merge branch 'trunk' into rerun-err-msg 2025-01-21 10:38:23 +05:30
Mikel Olasagasti Uranga
4396e40a31 Fix: Ensure constant format strings in fmt and printf calls 
Go 1.24 introduces stricter checks for format string validation.
This commit fixes instances where non-constant format strings were
used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
 2025-01-20 16:27:27 +01:00
Kynan Ware
facd0caa29 Fix: accidental whitespace in gist edit 2025-01-16 11:44:46 -07:00
Kynan Ware
5b6fd53a88 Fix: gist edit test name 2025-01-16 11:36:48 -07:00
Kynan Ware
dec46670bb Fix: gist edit/view tests var name consistency 2025-01-16 11:14:33 -07:00
Kynan Ware
a2dce589d6 Merge 'trunk' into fix/issue_10042 2025-01-16 11:06:36 -07:00
Kynan Ware
35d81e3ff5 Fix: Gist edit tests for interactivity 
This changes the gist edit tests to use the positive `istty` instead of the previous inverse `nontty`, which is consistent with the way other commands are written.
 2025-01-16 10:46:07 -07:00
Andy Feller
8288011149
Merge pull request #10239 from cli/andyfeller/10235-non-blocking-ext-update 
Make extension update check non-blocking
 2025-01-16 08:40:39 -05:00
William Martin
cc4bf0fc9f Add small wait to extension update tests 2025-01-16 14:10:42 +01:00
Andy Feller
243acaf579 Refactor test based on PR feedback 2025-01-16 00:08:45 -05:00
Rajhans Jadhao
143d628f1b
Merge branch 'trunk' into rerun-err-msg 2025-01-16 09:02:31 +05:30
William Martin
e7ffb1e435 Fix typo in secret base repo selection comment 2025-01-15 14:55:18 +01:00
William Martin
88a64d2a11 Change wording on secret repo prompt 2025-01-15 14:55:17 +01:00
William Martin
b382b24728 Print informative message before prompting for secret repo 2025-01-15 14:55:17 +01:00
William Martin
a47327aee6 Secret base repo prompting should not use resolved remote 
This is because the secret commands don't use the SmartBaseRepo behaviour, and therefore
don't care about the resolved remote.
 2025-01-15 14:55:17 +01:00
William Martin
ce47fabc27 Move secret base repo prompting earlier 2025-01-15 14:55:17 +01:00
William Martin
d831e3e1db Remove validated TODO and add review warning 2025-01-15 14:55:17 +01:00
William Martin
4da4c82090 Rename secret BaseRepo func 2025-01-15 14:55:17 +01:00
William Martin
870da79886 Use smarter base repo funcs for secret commands 2025-01-15 14:55:17 +01:00
William Martin
73244c010e Move secret repo validation into secrets subpackage 2025-01-15 14:55:17 +01:00
William Martin
df8bb51c9c Always prompt on secret set when multiple remotes 2025-01-15 14:55:17 +01:00
Wing
0be5720c1c Update setdefault test 2025-01-15 14:55:17 +01:00
Wing
cad59036f5 Update docs for set-default 
NOTE: gh does not use the default repository for managing repository and environment secrets.
 2025-01-15 14:55:17 +01:00
Wing
3de2fd94b3 Prompt for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
57c9ee0ad2 Add tests for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
88988374b5 Add remote check to secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Tyler McGoffin
3feeb9a826 Add tests for deleteGist 2025-01-14 14:21:49 -08:00
Rajhans Jadhao
10d4d27d8c
Merge branch 'trunk' into rerun-err-msg 2025-01-14 15:04:15 +05:30
Daniel A. Ochoa
3370bc8a04
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-13 21:17:23 -06:00
Andy Feller
bc8c46b0b1 Make extension update check non-blocking 
Fixes #10235

This commit updates the Cobra command logic around extension upgrade checks to be non-blocking.

Previously, we were waiting for 1 second after the extension completed to allow the update checking logic complete, however users want the GitHub CLI to run as far as possible.
 2025-01-13 20:38:03 -05:00
Tyler McGoffin
6fe21d8f52
Merge pull request #10197 from cli/jtmcg/remove-named-returns 
Remove naked return values from `ReadBranchConfig` and `prSelectorForCurrentBranch`
 2025-01-13 09:55:17 -08:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Mateus Marquezini
4eb0e8138f
Merge branch 'trunk' into fix/issue_10042 2025-01-13 11:47:52 -03:00
Mateus Marquezini
c0f6eb0598 #10042: Attempt to add a new test scenario for handling error messages when TTY is unavailable 2025-01-13 11:39:48 -03:00
Andy Feller
41e99b9eab
Merge pull request #9934 from cli/andyfeller/cli-cli-8183-timeout-pt2 
Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices
 2025-01-13 09:12:32 -05:00
Mateus Marquezini
977e2326a2 #10042: Applied code review suggestions to view_test.go 2025-01-13 11:06:13 -03:00
Rajhans Jadhao
b41b77165b
show error message for rerun workflow older than a month ago 2025-01-13 19:21:58 +05:30
Andy Feller
3ada5af872 Enhance help docs on ext upgrade notices 
- update `gh help environment` to include that upgrade notices only happen when gh or extensions are executed
- update `gh ext --help` to include reference to upgrade notices and points to `gh help environment` for info on disabling
 2025-01-13 08:41:10 -05:00
danochoa
1d9b4e4464 fix tests 2025-01-12 19:36:44 -06:00
danochoa
08f7706c42 fix tests 2025-01-12 19:18:24 -06:00
danochoa
7885167c70 gist delete - check no gists 2025-01-12 17:01:45 -06:00
Mateus Marquezini
24e9fed7e0 removed unnecessary space 2025-01-12 14:57:24 -03:00
Mateus Marquezini
c5d6ae6cf6
Update pkg/cmd/gist/edit/edit.go 
Update pkg/cmd/gist/edit/edit.go after code review

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2025-01-12 14:53:20 -03:00
Mateus Marquezini
f65ac161ee
Merge branch 'trunk' into fix/issue_10042 2025-01-12 14:50:41 -03:00