Commit graph

11229 commits

Author SHA1 Message Date
William Martin
8ff70e6e7a Remove numberFieldOnly API shortcut
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-01 17:23:01 +02:00
tidy-dev
611b01f6c8
Merge pull request #13312 from cli/enable-pr-screening
Enable extended PR screening for external PRs
2026-04-30 07:59:51 -04:00
tidy-dev
8b89c8b2b2 Enable extended PR screening for external PRs
Opts in to the new PR screening features in the shared triage workflow:
- Instantly closes PRs with zero file changes
- Detects same-author resubmissions of recently closed PRs
- Fast-tracks small, well-described fixes to ready-for-review
- Accelerates closure of large unsolicited PRs (3 days vs 7)

Depends on desktop/gh-cli-and-desktop-shared-workflows#17

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-29 09:43:23 -04:00
William Martin
d762f9e232
Merge pull request #13304 from pdostal/fix/accessible-prompter-password-test-timeout
Fix flaky accessible prompter Password test timeout
2026-04-28 18:47:53 +02:00
William Martin
fae293f8e8
Merge pull request #13303 from pdostal/fix/add-integration-build-tag
Add missing //go:build integration tag to verify_integration_test.go
2026-04-28 18:34:25 +02:00
Pavel Dostál
6d6ea5f371 Fix flaky Password test by increasing echo mode setup timeout
The beforePasswordSendTimeout was set to 100 microseconds, which is
insufficient for huh to disable echo mode on the PTY in slow or
constrained environments (e.g. network-isolated build containers).
Increase to 100 milliseconds to avoid the race condition.
2026-04-28 18:25:51 +02:00
Pavel Dostál
20e4d25147 Add missing //go:build integration tag to verify_integration_test.go
The four tests in this file (TestVerifyIntegration,
TestVerifyIntegrationCustomIssuer, TestVerifyIntegrationReusableWorkflow,
TestVerifyIntegrationReusableWorkflowSignerWorkflow) call
NewLiveSigstoreVerifier which requires network access to Sigstore and
GitHub TUF servers. Unlike the other integration test files in this
package (attestation_integration_test.go, sigstore_integration_test.go,
inspect_integration_test.go), this file was missing the //go:build
integration tag, causing these tests to run during a regular
'go test ./...' and fail in network-isolated build environments.
2026-04-28 18:20:23 +02:00
William Martin
bd4a06aab7
Merge pull request #13297 from cli/dependabot/github_actions/goreleaser/goreleaser-action-7.2.1
chore(deps): bump goreleaser/goreleaser-action from 7.0.0 to 7.2.1
2026-04-28 16:32:29 +02:00
William Martin
6c470f6080
Merge pull request #13281 from maxbeizer/fix/projects-v2-ignorable-error
Add "Resource not accessible" to ProjectsV2IgnorableError
2026-04-28 12:16:54 +02:00
William Martin
697f7f64ee
Merge pull request #13301 from cli/bump-go-1.26.2
Bump Go to 1.26.2
2026-04-28 11:32:21 +02:00
cli automation
06ac7b6e0a Bump Go to 1.26.2 2026-04-28 11:22:34 +02:00
Babak K. Shandiz
e41ec700c1
Merge pull request #13298 from cli/dependabot/go_modules/github.com/mattn/go-isatty-0.0.22
chore(deps): bump github.com/mattn/go-isatty from 0.0.21 to 0.0.22
2026-04-28 08:31:39 +01:00
dependabot[bot]
0e3c4991c7
chore(deps): bump github.com/mattn/go-isatty from 0.0.21 to 0.0.22
Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.21 to 0.0.22.
- [Commits](https://github.com/mattn/go-isatty/compare/v0.0.21...v0.0.22)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-isatty
  dependency-version: 0.0.22
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-27 17:27:14 +00:00
dependabot[bot]
ed31e2f6e8
chore(deps): bump goreleaser/goreleaser-action from 7.0.0 to 7.2.1
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 7.0.0 to 7.2.1.
- [Commits](ec59f474b9...1a80836c5c)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-version: 7.2.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-27 17:26:50 +00:00
Babak K. Shandiz
3c7c88c0e4
Merge pull request #13296 from travellertales/patch-1
Add trust disclaimer to extension help text
2026-04-27 16:17:10 +01:00
travellertales
e40c592e42
Update command.go 2026-04-27 10:19:56 -04:00
Max Beizer
dde46dc424
Add "Resource not accessible" to ProjectsV2IgnorableError
When a token (GitHub App, fine-grained PAT, or GITHUB_TOKEN) lacks the
project permission, querying projectItems on a PR or issue fails with
"Resource not accessible by integration" or "Resource not accessible by
personal access token". ProjectsV2IgnorableError did not match these
errors, causing commands like pr view, pr edit, and issue view to fail
entirely instead of gracefully omitting project data.

Add "Resource not accessible by" as an ignorable error prefix. This is
safe because ProjectsV2IgnorableError is only called in project-specific
code paths.

Closes #13280

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-24 17:16:00 -05:00
Babak K. Shandiz
ea7a2450cd
Merge pull request #13274 from cli/babakks/fix-zsh-completion-on-debian
chore: fix zsh completion on debian
2026-04-24 14:54:29 +01:00
Babak K. Shandiz
de6a9eb3e4
chore: fix zsh completion on debian
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-24 14:42:40 +01:00
Sam Morrow
2c1f5b2f72
Merge pull request #13264 from SamMorrowDrums/sammorrowdrums/skill-ghec-data-residency
feat(skills): support GHEC with data residency hosts
2026-04-24 11:45:28 +02:00
Sam Morrow
96b9af3443
Merge pull request #13266 from cli/sammorrowdrums/fix-skill-install-flat-path
Install skills flat by Name, not namespaced InstallName
2026-04-24 11:41:03 +02:00
Sam Morrow
5a121bf331
Merge pull request #13265 from SamMorrowDrums/sammorrowdrums/preview-allow-hidden-dirs-flag
feat(skills): add --allow-hidden-dirs flag to preview command
2026-04-24 11:39:24 +02:00
William Martin
352a00e83c
Merge pull request #13241 from cli/dependabot/go_modules/github.com/gdamore/tcell/v2-2.13.9
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.8 to 2.13.9
2026-04-23 19:26:25 +02:00
William Martin
d13a1858d7
Merge pull request #13273 from cassidyjames/patch-1
docs: correct typo in Linux Homebrew copy
2026-04-23 19:23:21 +02:00
Cassidy James Blaede
993d4bb630
install_linux: correct typo in Homebrew copy
Just a little typo I noticed when looking at the instructions. updated → updates
2026-04-23 10:35:16 -06:00
William Martin
db234016a1
Merge pull request #13206 from cli/dependabot/go_modules/charm.land/bubbletea/v2-2.0.6
chore(deps): bump charm.land/bubbletea/v2 from 2.0.2 to 2.0.6
2026-04-23 16:12:55 +02:00
dependabot[bot]
aba7c591f3
chore(deps): bump charm.land/bubbletea/v2 from 2.0.2 to 2.0.6
Bumps [charm.land/bubbletea/v2](https://github.com/charmbracelet/bubbletea) from 2.0.2 to 2.0.6.
- [Release notes](https://github.com/charmbracelet/bubbletea/releases)
- [Commits](https://github.com/charmbracelet/bubbletea/compare/v2.0.2...v2.0.6)

---
updated-dependencies:
- dependency-name: charm.land/bubbletea/v2
  dependency-version: 2.0.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-23 14:04:05 +00:00
dependabot[bot]
47f379cf0d
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.8 to 2.13.9
Bumps [github.com/gdamore/tcell/v2](https://github.com/gdamore/tcell) from 2.13.8 to 2.13.9.
- [Release notes](https://github.com/gdamore/tcell/releases)
- [Changelog](https://github.com/gdamore/tcell/blob/main/CHANGESv3.md)
- [Commits](https://github.com/gdamore/tcell/compare/v2.13.8...v2.13.9)

---
updated-dependencies:
- dependency-name: github.com/gdamore/tcell/v2
  dependency-version: 2.13.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-04-23 14:03:29 +00:00
William Martin
3a0d49525d
Merge pull request #13163 from cli/dependabot/go_modules/charm.land/lipgloss/v2-2.0.3
chore(deps): bump charm.land/lipgloss/v2 from 2.0.2 to 2.0.3
2026-04-23 16:02:34 +02:00
William Martin
7051e276fd
Merge pull request #13162 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.21.5
chore(deps): bump github.com/google/go-containerregistry from 0.21.4 to 0.21.5
2026-04-23 16:02:00 +02:00
William Martin
abc0dc6c23
Merge pull request #13161 from cli/dependabot/go_modules/github.com/mattn/go-isatty-0.0.21
chore(deps): bump github.com/mattn/go-isatty from 0.0.20 to 0.0.21
2026-04-23 16:01:31 +02:00
William Martin
a9d36fb9ef
Merge pull request #13272 from cli/wm/fix-log-terminal-injection
Fix log terminal injection
2026-04-23 15:40:29 +02:00
William Martin
c8e0139919
Update acceptance/testdata/workflow/run-view-log-escape-sequences.txtar
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-04-23 15:31:38 +02:00
William Martin
9a3dc9fce7 Fix log terminal injection 2026-04-23 13:56:33 +02:00
sammorrowdrums
d961de44d7 fix(skills): include --allow-hidden-dirs in preview hint from install
The review hint printed after `gh skill install --allow-hidden-dirs`
suggests `gh skill preview` commands. Those commands would fail for
hidden-dir skills because preview would filter them out. Pass the
flag through so the suggested commands work as-is.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-23 10:23:26 +02:00
Copilot
2e93afc272 Install skills flat by Name, not namespaced InstallName
Most agent clients (Claude Code, Copilot, etc.) only discover immediate
subdirectories of their skills folder. When a skill repository used
namespaced paths like skills/author/my-skill/, the installer created
nested directories (e.g. .claude/skills/author/my-skill/) that clients
could not find.

This separates the skill's identity (InstallName, used for lockfile keys,
search, filtering, display) from the filesystem path (Name, used for the
install directory). Skills are now always installed flat:

  .claude/skills/my-skill/SKILL.md  (not .claude/skills/author/my-skill/)

Changes:
- installer: use skill.Name for directory paths instead of InstallName
- install.go: use skill.Name for overwrite checks and prompts
- collisions: detect conflicts by Name since flat install means two
  skills with the same Name but different Namespace values will collide
- update: clean up old namespaced directories when migrating to flat

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-23 01:26:31 +02:00
Copilot
8498bdf435 feat(skills): add --allow-hidden-dirs flag to preview command
Add support for the --allow-hidden-dirs flag in `gh skill preview`,
matching the existing pattern in `gh skill install`. This allows users
to preview skills located in hidden directories (e.g. .claude/skills/,
.agents/skills/).

Changes:
- Add AllowHiddenDirs field to PreviewOptions
- Register --allow-hidden-dirs flag on the preview command
- Switch from DiscoverSkills to DiscoverSkillsWithOptions to get all
  skills including hidden-dir ones
- Add filterHiddenDirSkills to exclude hidden-dir skills by default,
  showing a hint when they are found but excluded
- Print a warning when --allow-hidden-dirs is used and hidden skills
  are present
- Return an error when only hidden-dir skills exist without the flag

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-22 23:41:25 +02:00
sammorrowdrums
63262dce8b feat(skills): support GHEC with data residency hosts
Widen ValidateSupportedHost to accept tenancy hosts (*.ghe.com) alongside
github.com. GHEC with data residency uses these domains, and all skill
subcommands (search, install, preview, publish, update) now allow them.

GitHub Enterprise Server remains unsupported and is explicitly rejected
with a clear error message.

Also fix the lockfile writer to use the actual host when constructing
SourceURL instead of hardcoding github.com.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-22 23:27:38 +02:00
Babak K. Shandiz
3ad29588b8
Merge pull request #13259 from cli/fix-sample-rate-dimension-sync
Fix SetSampleRate not updating sample_rate dimension
2026-04-22 13:13:58 +01:00
William Martin
7095e2a4fc
Fix SetSampleRate not updating sample_rate dimension
The sample_rate common dimension was set once at service creation
time and never updated when SetSampleRate was called later. This
caused commands like 'gh skill publish' that override the sample
rate via PersistentPreRunE to report the wrong sample_rate in
telemetry events (e.g. 1 instead of 100).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-22 13:04:57 +01:00
William Martin
6d986480b8
Merge pull request #13258 from orbisai0security/fix-shell-injection-deployment-workflow
fix: using variable interpolation `${{ in deployment.yml...
2026-04-22 12:55:43 +02:00
orbisai0security
f52acd51e9 fix: yaml.github-actions.security.run-shell-injection.run-shell-injection security vulnerability
Automated security fix generated by Orbis Security AI
2026-04-22 16:05:54 +05:30
William Martin
6fffc2e66a
Merge pull request #13254 from cli/wm/enable-telemetry
Enable telemetry without env var
2026-04-22 12:16:33 +02:00
Babak K. Shandiz
b5757eab2a
Merge pull request #13244 from cli/kw/agent-skills
docs(skills): add gh and gh-skill agent skills
2026-04-21 19:26:07 +01:00
William Martin
90ef03ea38
Enable telemetry without env var 2026-04-21 18:40:02 +01:00
William Martin
3a6d4de90a
Merge pull request #13255 from cli/wm/log-no-events
Log when there is no telemetry
2026-04-21 19:30:51 +02:00
Sam Morrow
92e812b749
Merge pull request #13236 from cli/sammorrowdrums/skill-install-upstream-provenance 2026-04-21 19:29:31 +02:00
Babak K. Shandiz
0467ed499a
test(telemetry): assert ANSI escape chars for color codes
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-04-21 18:05:28 +01:00
Babak K. Shandiz
ec4a3ed6bd
fix(telemetry): lower bias in sample bucket calc
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-04-21 17:49:28 +01:00
William Martin
fe90f9a503
Add telemetry command (#13253) 2026-04-21 18:45:23 +02:00