Commit graph

2895 commits

Author SHA1 Message Date
William Martin
c90b87bdad Remove unused prInstrospection fixture 2023-05-22 18:46:28 +02:00
William Martin
42b61ad53e Inject fake detector into PR status tests 2023-05-22 18:44:51 +02:00
William Martin
cdd05a38c6 Move CheckRunAndStatusContextCounts feature detection up stack 2023-05-22 17:32:52 +02:00
William Martin
75e35e2dde Use pseudo field for statusCheckRollupWithCountByState 2023-05-22 17:28:15 +02:00
William Martin
ebb7d26f3a Implement initial spike for detecting and using counts by state 2023-05-17 19:59:03 +02:00
Sam Coe
f77a3dcacb
Do not fall back to legacy template if template selector returns nil (#7444) 2023-05-16 09:44:00 +12:00
Nate Smith
4af21f71c0
Merge pull request #7445 from ffalor/7216
respect GH_REPO env variable in `pr create`
2023-05-15 13:51:40 -07:00
Tony F
ae3e879480
Mention setting GH_ENTERPRISE_TOKEN
When GH_HOST is set
2023-05-15 10:49:45 -05:00
ffalor
ff991c3c84
Merge branch 'trunk' into 7216 2023-05-15 09:57:07 -05:00
ffalor
ae58b7714c respect GH_REPO env variable in pr create 2023-05-14 22:38:49 -05:00
Jakub Kuczys
bd749b67f6
Allow gh repo set-default --view without repo argument (#7441) 2023-05-15 11:08:01 +12:00
William Martin
07ed1e4e8a
Introduce helpTopics type and reduce duplication across commands (#7414) 2023-05-11 14:59:12 +02:00
Kousik Mitra
8d0f211fdb
Print message after codespace deletion (#7353) 2023-05-09 20:56:54 -05:00
Martijn Pieters
0da0de4022
Include auto-merge information in gh pr view (#7385) 2023-05-10 08:39:52 +12:00
Martijn Pieters
83aaa76141
Include auto-merge information in gh pr status (#7386)
PRs that have auto-merge enabled are marked with a green "✓ Auto-merge enabled" label.
2023-05-10 08:32:05 +12:00
Josh Kraft
b01c27aba2
Add progress labels for gh release download (#7380) 2023-05-07 21:28:37 +00:00
vwkd
d349ba185a
fix empty default description for local repository (#7383) 2023-05-04 09:21:12 +12:00
Kevin Lee
03f1ba75ac
Add alias import command (#7118) 2023-05-04 09:17:39 +12:00
Kousik Mitra
d0207a2ede
Add capability to filter codespaces by repo owner (#7347)
* Add capability to filter codespaces by repo owner

* Replace Flags with PersistentFlags

* Reword flag description

* Update test seed

* Add mutual exclusion

---------

Co-authored-by: Caleb Brose <5447118+cmbrose@users.noreply.github.com>
2023-04-27 10:42:08 -05:00
Martijn Pieters
530002ee7a
Pretty-print JSON results of jq filtering (#7236)
When connected to a TTY, tell the jq formatter to indent the output, and
enable colorization of the output if the terminal supports it.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-04-25 13:27:17 +00:00
Heath Stewart
17679cf65f
Edit multiple issues, PRs in parallel (#7259)
Allows multiple issues or PRs to be edited in parallel, and querying for shared fields once to reduce network requests.

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-04-25 14:45:41 +02:00
cawfeecake
9473ec890c
add --created flag to gh run ls to filter listed runs by when they were created (#7352) 2023-04-25 12:43:19 +02:00
cawfeecake
d7512bb2e7
add --event flag to gh run ls to filter runs by their trigger 2023-04-24 20:50:20 -07:00
Benjamin Levesque
7cfbf478d5
Diacritics substitution in prompt (#7205) 2023-04-21 14:09:59 +00:00
Alexander Seiler
218f29f296
Correct some typos 2023-04-21 03:51:31 +02:00
Caleb Brose
09e86d0ebf
Fix gh cs ports requiring sudo for privileged port numbers (#7326) 2023-04-19 07:00:44 -05:00
John Keech
4b5a9032fe
Clarify how SSH keys are selected (#7325)
Fixes: https://github.com/orgs/community/discussions/52556

Update the help text for `gh codespace ssh` to provide more details about how SSH keys are selected.
2023-04-17 10:19:03 -07:00
Lại Tuấn Anh
3d8057d856
fix: normalize hostname for auth login (#6999)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-04-17 13:35:30 +00:00
Sam Coe
dbc2f05124
Update go-gh to v2 (#7299)
* Update go-gh

* Update code for go-gh v2
2023-04-16 15:34:23 +10:00
Navaneethan
c0855a3e61
Fix typo in cs stop command: Stoppping -> Stopping (#7318) 2023-04-14 14:08:42 -05:00
doaortu
83322104b7
feat: add web flag for codespace list & create subcommand (#7288)
* feat: add web flag to cs list subcommand

web flag only works with repo flag, because,
currently there only param for listing with repo_id

* feat: add web flag to cs crate subcommand

web flag used for creating codespace through web UI instead of terminal.
web flag cannot be used with display-name, idle-timeout,
or retention retention-period
because there's no option for that in the Web UI

* refactor: extract mutual excusive logic to PreRunE

- changed web flag mutual exclusive logic, using cmdutil
- extract that logic to PreRunE clause in createCmd
- move web flag up to make it close to PreRunE clause (for clarity)
- add new param to newCreateCmd fn to facilitate test logic
- apply new newCreateCmd fn to root.go

* fix: clarify flag desc and error message

- remove 'yet' from error messages that can cause misunderstanding
- clarify list web flag can only be used with repo flag

* fix: skip machine check when we use web flag ...
(..and no machine flag provided)

+ add test for this new case
+ adjust related test cases for this new change.

* refactor: move flag check logic to PreRunE

why: err on PreRunE or RunE will also print help if error happened

+ move web, repo, org, user mutual exclusive logic to PreRunE clause
+ move repo, org, user mutual exclusive logic to PreRunE
+ move limit check flag to PreRunE
+ modify newListCmd fn to facilitate test logic
+ apply new newListCmd to root.go
+ add test cases to check PreRunE clause
- remove mutual exclusive test cases from Test_AppList

* refactor: remove the opts equality checks

* fix: mutually exclusive misfires
because of wrong logic

+ refine test case too

* cleanup:removing useWeb check in fn getMachineName

because it's no longer needed

+ remove redundant test-case

* refactor: remove redundant ifs

* refactor: clarify test name

* re-clarify web flag desc in list.go

* refactor: break long lines, use more idiomatic err

* add test case for nonexistent/wrong machine
2023-04-13 10:37:16 -05:00
Kousik Mitra
7ee35e43cc
Enable owner flag to take multiple values for searching 2023-04-12 10:37:09 +05:30
Nate Smith
a279dd7082
Merge branch 'trunk' into feature/ssh-signing-key 2023-04-11 16:00:56 -07:00
Josh Kraft
aa8a902004
Merge branch 'trunk' into gh-org-command 2023-04-07 16:59:59 -06:00
Kenichi Kocha
89caedf181
Add -R as shorthand of --repo flag for search commands (#7274) 2023-04-07 17:41:51 +10:00
Caleb Brose
27a3fcc807 Fix invoker immediately closing 2023-04-05 19:33:50 -05:00
Josh Kraft
6fd951c189
Merge branch 'trunk' into gh-org-command 2023-04-05 15:39:21 -06:00
Josh Kraft
4d20db0ca0 Merge branch 'gh-org-command' of https://github.com/joshkraft/cli into gh-org-command 2023-04-05 15:38:58 -06:00
Josh Kraft
ba37e2333d add "showing x of y organizations" header 2023-04-05 15:36:45 -06:00
Kousik Mitra
4668810cbe
Enhance ssh-key list to show signing ssh keys also 2023-04-05 19:22:28 +05:30
Kousik Mitra
0d8b5ab9d7
Add option to add ssh singing key 2023-04-05 19:22:28 +05:30
Nate Smith
08f9370345
Merge pull request #7254 from phillippbertram/feat/add-cmd-gh-run-delete
feat: add command `gh run delete`
2023-04-04 17:06:07 -07:00
nate smith
75dc9c0c22 extend secure storage default to auth refresh 2023-04-04 15:22:42 -07:00
Josh Kraft
8fbcae6a41
Merge branch 'trunk' into gh-org-command 2023-04-04 15:05:23 -06:00
nate smith
d9db81db4f fix apparent typo 2023-04-04 11:13:53 -07:00
nate smith
5d56dfbf42 add --insecure-storage and make secure storage the default 2023-04-04 11:13:43 -07:00
Kenichi Kocha
1263412055
fix: make number arg, commit arg, and flags mutually exclusive (#7268)
* make number, commit, and flags mutually exclusive

* break condition into arg own check
2023-04-04 12:24:40 +09:30
Kenichi Kocha
6261bc6971
Additional help doc and example for auth setup-git (#7243) 2023-04-04 01:36:09 +00:00
Kenichi Kocha
18f2484080
docs: add commit SHA arg to gh browse help (#7267)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-04-03 14:40:37 +00:00
Josh Kraft
74bf49fcf5
Merge branch 'trunk' into gh-org-command 2023-03-31 15:58:34 -06:00