rista404
a2a6036c65
Add tests
2020-04-25 23:12:51 +02:00
rista404
fab18ed4a9
Show awaiting triage when project col is empty
2020-04-25 22:57:03 +02:00
Mislav Marohnić
3aaa231cc5
Guide user through re-authorization flow if read:org scope is missing
...
How this works for people with existing OAuth tokens:
$ gh issue list -L1
Notice: additional authorization required
Press Enter to open github.com in your browser...
[auth flow in the browser...]
Authentication complete. Press Enter to continue...
Showing 1 of 132 issues in cli/cli
...
Users of Personal Access Tokens get a different notice:
Warning: gh now requires the `read:org` OAuth scope.
Visit https://github.com/settings/tokens and edit your token to enable `read:org`
or generate a new token and paste it via `gh config set -h github.com oauth_token MYTOKEN`
2020-04-23 18:20:21 +02:00
Mislav Marohnić
84ac3d412e
Fix gh updater mechanism for unauthenticated users
...
Per code documentation: "BasicClient returns an API client that borrows
from but does not depend on user configuration". This means that any
errors while reading `oauth_token` should be tolerated.
2020-04-23 15:41:37 +02:00
Mislav Marohnić
8ed9a0324e
Merge remote-tracking branch 'origin/master' into oauth-read-org
2020-04-23 15:35:35 +02:00
vilmibm
97e3a57244
fix tests
2020-04-22 16:16:14 -05:00
vilmibm
03e60758d0
missed a thing
2020-04-22 16:08:47 -05:00
Corey Johnson
e68be52ed0
Use the correct field
2020-04-22 14:03:44 -07:00
Corey Johnson
4b2382c737
Merge branch 'heathy-helping' of https://github.com/cli/cli into heathy-helping
2020-04-22 14:02:09 -07:00
Corey Johnson
c9d5935ee3
move to use
2020-04-22 14:00:08 -07:00
Corey Johnson
4dff85d3c1
Merge remote-tracking branch 'origin/master' into heathy-helping
2020-04-22 13:56:53 -07:00
Nate Smith
9d7590cbfc
Merge pull request #810 from cli/respect-protocol
...
respect git_protocol setting
2020-04-22 15:54:38 -05:00
Corey Johnson
c064b07e6d
Add quote
2020-04-22 13:51:35 -07:00
Corey Johnson
0d79257312
use backets
...
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:50:52 -07:00
Corey Johnson
833f8b4f2c
Update command/root.go
...
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:50:06 -07:00
Corey Johnson
6d20283a7a
Move feedback to the bottom
2020-04-22 13:49:42 -07:00
vilmibm
f1bee0c9b9
use more clear name
2020-04-22 15:49:16 -05:00
Corey Johnson
b5299ef5d7
pointy brackets ftw
...
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:46:51 -07:00
vilmibm
f26690adc9
support GH_EDITOR
2020-04-22 14:33:56 -05:00
vilmibm
9641eee38a
use more clear name
2020-04-22 14:31:09 -05:00
vilmibm
bec58ede98
respect ssh
...
this adds recognition of the git_protocol setting when:
- creating a repo
- cloning a repo
- forking a repo
- forking/pushing during pr create
- checking out a PR
additionally, it:
- consolidates remote adding to use AddRemote; this introduces a fetch
where there previously hadn't been one
- changes repo clone to accept an ssh url
- changes repo fork to accept an ssh url
i just added basic unit tests; adding new test cases for all of the
above scenarios seemed like diminishing returns.
2020-04-22 14:21:01 -05:00
Corey Johnson
a4429aae41
rearrange code
2020-04-22 10:00:33 -07:00
vilmibm
3c8b87c9c6
respect configured editor
2020-04-22 11:23:14 -05:00
Toshiya Doi
1ce09ff758
Merge branch 'master' into reviewers-in-pr-view
2020-04-22 22:00:02 +09:00
Toshiya Doi
67907c8b00
Support ghost reviews in pr view
2020-04-22 21:59:09 +09:00
Toshiya Doi
d70358ea34
Support GitHub Team in requested reviewers
2020-04-22 21:58:01 +09:00
Corey Johnson
be51d095ea
Separating core from non-core commands
2020-04-21 13:30:07 -07:00
Mislav Marohnić
a7d061709d
Add ability to prefetch granulated repository metadata
2020-04-21 19:14:57 +02:00
vilmibm
d4dd4a68bf
fix error handling
2020-04-21 11:25:23 -05:00
vilmibm
fcf258620c
ignore MarkHidden errors
2020-04-21 11:23:38 -05:00
vilmibm
6e55e899fa
handle defaults at the Config level instead of ConfigMap
2020-04-21 10:59:44 -05:00
vilmibm
bba63439dc
slopwip for defaults
2020-04-21 10:32:57 -05:00
vilmibm
3220f2ef53
linter appeasement
2020-04-20 14:00:06 -05:00
vilmibm
c4693077aa
move config stuff to its own package
2020-04-20 13:57:16 -05:00
vilmibm
815f461e8b
more strict erroring around missing user/token
2020-04-20 12:49:46 -05:00
vilmibm
1a5bc0687e
usage cleanup
2020-04-20 12:33:32 -05:00
vilmibm
bd907ec74d
favor %w over %s for error wrapping
2020-04-20 12:22:12 -05:00
vilmibm
a325db3051
new config infrastructure
...
- adds config get and config set commands
- supports arbitrary k/v strings set at top and host level
- supports writing an updated config, preserving comments
- supports mostly lazy evaluation of yaml
2020-04-17 15:17:44 -05:00
Mislav Marohnić
d3a89b8744
Expand issue create metadata flags to pr create
...
- Includes support `pr create --reviewer <login>`
- Hide "Preview in browser" menu option when any metadata are set
2020-04-17 20:23:57 +02:00
Mislav Marohnić
de59f6a1bf
Add flags to add additional metadata to issue create
...
- `-a, --assignee` (accepts multiple)
- `-l, --label` (accepts multiple)
- `-p, --project` (accepts multiple)
- `-m, --milestone`
2020-04-15 18:28:52 +02:00
Mislav Marohnić
3d566dc5a6
Detect and warn about read:org OAuth scope being missing
2020-04-15 17:25:15 +02:00
Mislav Marohnić
f09994dd84
Appease linter that warns about redundant type in composite literals
2020-04-13 15:15:41 +02:00
Toshiya Doi
502f6709af
Extract the reviewerstate formatter into a function
2020-04-11 15:03:43 +09:00
Toshiya Doi
fe27c842bb
Fix slice initialization with provided capacity
2020-04-11 15:03:34 +09:00
Nate Smith
c670049ce7
Merge pull request #745 from doi-t/add-metadata-to-view
...
Add relevant metadata to issue view in CLI
2020-04-09 16:27:07 -05:00
Toshiya Doi
fbff7226ac
Add comments on review state values
2020-04-10 04:51:42 +09:00
Toshiya Doi
2df5281f2f
Merge branch 'master' into reviewers-in-pr-view
2020-04-10 04:46:05 +09:00
Mislav Marohnić
d14b5d3e2c
Merge pull request #764 from cli/pr-view-docs
...
Improve `issue/pr/repo view` documentation
2020-04-09 19:12:34 +02:00
Nate Smith
3c335104c5
Merge pull request #748 from doi-t/add-pr-metadata-to-view
...
Add relevant metadata to pr view in CLI
2020-04-09 12:12:18 -05:00
Mislav Marohnić
7f9aef6c0d
Merge pull request #761 from cli/completion-fixes
...
Improve `completion` command
2020-04-09 19:10:36 +02:00