Commit graph

3638 commits

Author SHA1 Message Date
Meredith Lancaster
93c78a2134 use sigstore specific err
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:28:34 -06:00
Meredith Lancaster
b44c9d3003 undo policy method changes
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:23:50 -06:00
Meredith Lancaster
3378b546da simplify if else logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 12:58:40 -06:00
Meredith Lancaster
41c3ba5fa7 drop sigstore instance for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 18:19:19 -06:00
Meredith Lancaster
e16b69bd08 cert extension funcs are now policy methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 17:27:47 -06:00
Meredith Lancaster
e5b2b09a6e move policy functions into methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 16:41:17 -06:00
Meredith Lancaster
704de0cf37 start building a separate policy struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 15:33:24 -06:00
William Martin
d4c70009bf
Adjust environment help for host and tokens (#9809) 2024-10-24 17:54:27 +02:00
Phill MV
afa4272bdf
Merge pull request #9797 from cli/phillmv/retry-getting-attestations
`gh at verify` retries fetching attestations if it receives a 5xx
2024-10-23 13:45:09 -04:00
bagtoad
04add8d68f Use new GitHub previews terminology in attestation
Update attestations commands to align with new GitHub previews terminology, replacing `beta` with `public preview`.

https://github.blog/changelog/2024-10-18-new-terminology-for-github-previews/
2024-10-22 10:50:00 -06:00
William Martin
ad7c29dc5c
Merge pull request #9790 from tsukasaI/feature/add-archived-timestamp
Add archivedAt json field to repo view and list
2024-10-22 14:03:58 +02:00
William Martin
a923e33421 Test json flags for repo view and list 2024-10-22 13:38:51 +02:00
Kynan Ware
6dab689718
Merge pull request #9794 from cli/kw/cli-9699-validate-local-extension-installs
Prevent local extension installations with invalid names and conflicts with core commands and other extensions
2024-10-21 13:40:09 -06:00
bagtoad
daec7a0e0e Check extOwner for no value instead 2024-10-21 13:28:37 -06:00
bagtoad
35aa8521c4 Fix tests for invalid extension name 2024-10-21 12:47:14 -06:00
bagtoad
cc32f33583 Refactor to remove code duplication 2024-10-21 12:37:27 -06:00
Phill MV
de4c05fb61 Linting: now that mockDataGenerator has an embedded mock, we ought to have pointer receivers in its funcs. 2024-10-21 14:32:32 -04:00
Phill MV
a8b3f050ac
Merge branch 'trunk' into phillmv/fail-verification-if-no-attestations 2024-10-21 12:49:41 -04:00
Phill MV
e7446676b6 Minor tweaks, added backoff to getTrustDomain 2024-10-21 12:44:51 -04:00
Phill MV
fafda48905 added test for verifying we do 3 retries when fetching attestations. 2024-10-21 12:32:57 -04:00
Phill MV
efc1c97cf1 Added constant backoff retry to getAttestations. 2024-10-21 12:10:18 -04:00
Phill MV
664e09fdbc wip: added test that fails in the absence of a backoff. 2024-10-21 11:20:46 -04:00
bagtoad
6923fb5cc8 add validation for local ext install 2024-10-20 16:37:40 -06:00
Tyler McGoffin
1313612245
Merge pull request #9701 from cli/jtmcg/9698
Add handling of empty titles for Issues and PRs
2024-10-17 14:57:57 -07:00
Tyler McGoffin
14acbe00a9 Remove . from test case for TestTitleSurvey 2024-10-17 14:45:35 -07:00
Tyler McGoffin
13ab02729b Clean up Title Survey empty title message code 2024-10-17 14:40:17 -07:00
Andy Feller
86b4bb9956 Include startedAt, completedAt in run steps data
This commit expands the `Step` structure used with GitHub Actions workflow runs to include fields indicating when steps start and complete.

This information is already provided by the GitHub API, so this only involves expanding the structure, fields exported, and the associated tests.

In the future, I could see `gh` including the duration calculation which is used when viewing workflow or workflow run.
2024-10-16 19:38:10 -04:00
Tyler McGoffin
7aef6ec391
Merge pull request #9728 from heaths/issue9704
Supporting filtering on `gist list`
2024-10-15 16:26:13 -07:00
Tyler McGoffin
c1897f3122
Merge branch 'trunk' into jtmcg/9698 2024-10-15 15:15:31 -07:00
Heath Stewart
446f66070a
Add filtered content output to docs 2024-10-15 14:39:21 -07:00
Tyler McGoffin
ddf90c78c2 Remove IsTenancy and relevant tests from gists as they are unsupported 2024-10-15 12:41:23 -07:00
Tyler McGoffin
e1a39d8e2b Add ghe.com to tests describing ghec data residency 2024-10-15 12:24:41 -07:00
Tyler McGoffin
4df2e7be63 Remove comment 2024-10-15 12:16:20 -07:00
Tyler McGoffin
8109594c4c auth: Removed redundant ghauth.IsTenancy(host) check 2024-10-15 11:56:43 -07:00
Tyler McGoffin
81591a09b8 Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname 2024-10-15 11:56:43 -07:00
Tyler McGoffin
3a8417f6c7 Add test coverage to places where IsEnterprise incorrectly covers Tenancy
IsEnterprise currently returns `true` when `IsTenancy` returns true. We
prefer that this behavior is orthogonal. This commit adds failing tests to
the instances where IsEnterprise should not behave the same as IsTenancy.

These test cases are expected to pass with the inclusion of the coming
improvements to go-gh to handle the orthogonality of IsEnterprise and
IsTenancy.
2024-10-15 11:56:43 -07:00
Heath Stewart
9e00f1e4f2
Resolve PR feedback 2024-10-14 15:08:23 -07:00
Heath Stewart
e9d8092ffc
Don't append remaining text if more matches 2024-10-12 23:17:57 -07:00
Heath Stewart
bddadef574
Highlight matches in table and content
When `--filter` is passed, matches will be highlighted in the existing table. If file names match, the "n file(s)" cell will be highlighted.

When `--include-content` is additionally passed, the file name, description, and/or content will be printed like `search code` with matches highlighted.
2024-10-12 23:17:56 -07:00
Heath Stewart
86f045ef0e
Split all newlines, and output no-color to non-TTY 2024-10-12 23:17:56 -07:00
Heath Stewart
70b14215ec
Print filtered gists similar to code search 2024-10-12 23:17:56 -07:00
Heath Stewart
4eaeda580b
Show progress when filtering
Filtering can take a while, so show progress. This also uncovered a bug
that I wasn't checking if a filter was actually specified, resulting in
a non-nil `opts.Filter`.
2024-10-12 23:17:56 -07:00
Heath Stewart
1615f2c1e1
Simplify description 2024-10-12 23:17:56 -07:00
Tyler McGoffin
b56353dc02
Disallow use of --include-content without --filter 2024-10-12 23:17:55 -07:00
Heath Stewart
73af9f8bd9
Improve help docs
Also changes `--filter` argument to "expression" to coincide with some other commands' help text e.g., `--jq`.
2024-10-12 23:17:55 -07:00
Heath Stewart
34203d7e6c
Refactor filtering into existing gist list
Resolves feedback in issue #9704
2024-10-12 23:17:55 -07:00
Heath Stewart
2fb5687777
Improve performance
Filter as we get results instead of getting them all. This allows us to more easily terminate pagination when opts.Limit is reached.
2024-10-12 23:17:55 -07:00
Heath Stewart
8c6d4c9c52
Add gist search command
Resolves #9704
2024-10-12 23:17:52 -07:00
bagtoad
291370824b Return nil instead of empty objects when err 2024-10-11 12:08:10 -06:00
bagtoad
b6cdbc9e22 Fix license list and view tests 2024-10-11 11:59:06 -06:00