Commit graph

2450 commits

Author SHA1 Message Date
David Gardiner
93f033fe87 Address comments 2022-09-27 16:01:10 -07:00
David Gardiner
b0eb1b379a Implement gRPC client 2022-09-27 11:34:30 -07:00
Mislav Marohnić
acb61072cd Respect GH_HOST in auth login, repo delete
Bonus fix: respect fallback host argument to `FromFullNameWithHost()`
2022-09-26 13:32:54 +02:00
Mislav Marohnić
465b952d85
Merge pull request #6344 from cli/yaml-dispatch
Recognize `.yaml` in addition to `.yml` suffix as workflow file name
2022-09-26 11:54:25 +02:00
Mislav Marohnić
6a6fd7bace
Recognize .yaml in addition to .yml suffix as workflow file name 2022-09-26 10:54:57 +02:00
Eng Zer Jun
471cbea4fa
test: use t.Setenv to set env vars in tests (#6333)
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-26 08:46:02 +00:00
Natthakit Susanthitanon
1a759ecd4b
Add header and id column to the gh ssh-key list output (#6270) 2022-09-22 14:07:57 +04:00
Nate Smith
87a0db2a3b
Merge pull request #6317 from cli/cmbrose/local-ssh-test-fix
Ensure local keys don't interfere with ssh_test
2022-09-21 19:31:23 -05:00
Nate Smith
666470744d
Merge pull request #6313 from cli/context-prompter
use Prompter in context
2022-09-21 19:28:54 -05:00
Caleb Brose
cc98ffd6fa Ensure local keys don't interfere with ssh_test 2022-09-21 19:43:31 +00:00
Mislav Marohnić
d4e9b1f6a2
Merge pull request #6314 from cli/fix-git-push-prompt
Allow `git push` during PR create operation to prompt on stdin
2022-09-21 21:07:37 +02:00
Ariel Deitcher
49f6b20d3d
Add undo option to pr ready command to convert PR to draft (#5995) 2022-09-21 19:00:13 +00:00
Mislav Marohnić
6ca9406554 pr create: allow git push step to prompt on stdin 2022-09-21 20:57:53 +02:00
Isaac Shalom
f1be4dc51c
Fix looking up workflow name for workflow runs (#6266)
The API field `WorkflowRun.name` is not guaranteed to correspond to the workflow name anymore. This introduces additional API lookups that resolve Workflows by their ID and look up their name in a future-proof fashion.

It also adds two new JSON fields for export: `displayTitle` and `workflowName`.

Co-authored-by: Christina Guo <61271066+guo-chris@users.noreply.github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-09-21 20:41:19 +02:00
vilmibm
7b21a3ea45 use Prompter in context 2022-09-21 11:33:28 -07:00
Mislav Marohnić
113acf9245
Add the option to generate a README for the created repository (#6264) 2022-09-21 16:08:26 +02:00
Mislav Marohnić
354cfbd1b1
Merge pull request #6306 from cli/typo
fix typo
2022-09-21 14:09:20 +02:00
Caleb Brose
bb6db4b309 PR suggestions 2022-09-20 22:00:27 +00:00
Caleb Brose
4a8047ed61 Improve error handling 2022-09-20 19:36:07 +00:00
vilmibm
198c57a4c6 fix typo 2022-09-20 12:11:36 -07:00
Caleb Brose
deedd35a2c Merge branch 'cmbrose/no-ssh-api-call' of https://github.com/cli/cli into cmbrose/no-ssh-api-call 2022-09-20 18:32:01 +00:00
Caleb Brose
373634ad75 Rename to generateAutomaticSSHKeys 2022-09-20 18:32:00 +00:00
Caleb Brose
045bb54157
Apply suggestions from code review
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-09-20 13:22:38 -05:00
Caleb Brose
049a3676f4 Use filepath instead of path 2022-09-20 15:59:38 +00:00
Caleb Brose
83c67d3b57 Merge remote-tracking branch 'origin/trunk' into cmbrose/no-ssh-api-call 2022-09-20 15:22:27 +00:00
Caleb Brose
3b52df6f99 Don't add private key for -i 2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32 Update tests 2022-09-20 01:02:06 +00:00
Mislav Marohnić
6267bd368a
Merge pull request #6275 from cli/ghe-gist-clone
Fix gist clone URL for GHE hosts
2022-09-19 18:50:50 +02:00
Nate Smith
24ff8fac40
Merge pull request #6253 from cli/auth-prompts
use Prompter in auth commands
2022-09-19 11:02:13 -05:00
Mislav Marohnić
b82884af2d
Merge pull request #6279 from 8Gitbrix/revert-6223-revert-6171-add-org-secrets-api
Revert "Revert "Added functionality for org-level codespaces secrets""
2022-09-19 15:24:35 +02:00
Sam Coe
de83df12d2
Stub out time.Now for search tests (#6299) 2022-09-19 14:54:18 +04:00
Caleb Brose
0c00ca911e Clean up API interface 2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd Remove API call for ssh keys 2022-09-16 22:22:13 +00:00
Ashwin Jeyaseelan
b47ed57694 Revert "Revert "Added functionality for org-level codespaces secrets (#6171)" (#6223)"
This reverts commit eaabd35b76.
2022-09-15 15:53:28 -07:00
Mislav Marohnić
27294c197f gist clone: fix clone URL for GHE gists
Use `HOSTNAME/gist/ID` instead of `gist.HOSTNAME/ID` as clone URL for
Enterprise since it's not guaranteed that the `gist.` subdomain is
configured for a GHE instance.
2022-09-15 18:25:16 +02:00
Mislav Marohnić
0ecd424901
Merge pull request #6262 from cli/fix-subcommand-stdout
Ensure that subprocesses connect to the original `os.Stdout`
2022-09-15 11:07:22 +02:00
Mislav Marohnić
cfb7e66d2b
Merge pull request #6260 from cli/fix-branch-delete
Fix deleting remote branches with `#` in their name
2022-09-15 11:06:04 +02:00
Mislav Marohnić
984cc9f441 Fix tests 2022-09-14 17:05:43 +02:00
Mislav Marohnić
58ef50ae1f Ensure that subprocesses connect to the original os.Stdout
On non-Windows platforms, this avoids wrapping `IOStreams.Out` in a
`fdWriter` and thus causing subprocesses to lose connection to the
terminal that gh is connected to.
2022-09-14 16:47:42 +02:00
Mislav Marohnić
1e295607d7 Fix deleting remote branches with # in their name 2022-09-14 16:19:33 +02:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout (#6258) 2022-09-14 11:33:55 +00:00
Sam Coe
e14d14cef2
Add support for issue state reason (#6245) 2022-09-14 12:39:15 +04:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
vilmibm
8f3032af36 use Prompter in auth commands 2022-09-13 13:22:50 -07:00
Sam Coe
4bd5c2db9d
Rely on go-gh browser resolution (#6237) 2022-09-12 13:23:36 +04:00
ffalor
e5b37ee661
add --required flag to gh pr checks (#5648) 2022-09-10 08:00:29 +00:00
Ashwin Jeyaseelan
eaabd35b76
Revert "Added functionality for org-level codespaces secrets (#6171)" (#6223)
This reverts commit bde64b3191.
2022-09-09 08:18:03 +04:00
Ashwin Jeyaseelan
bde64b3191
Added functionality for org-level codespaces secrets (#6171) 2022-09-08 09:40:53 +04:00
Mislav Marohnić
e2e8d697db
Fix closing IOStreams.Out after finishing writing to the pager (#6210) 2022-09-06 19:22:31 +02:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests (#6203) 2022-09-06 15:31:36 +00:00