Commit graph

344 commits

Author SHA1 Message Date
Caleb Brose
cc98ffd6fa Ensure local keys don't interfere with ssh_test 2022-09-21 19:43:31 +00:00
Caleb Brose
bb6db4b309 PR suggestions 2022-09-20 22:00:27 +00:00
Caleb Brose
4a8047ed61 Improve error handling 2022-09-20 19:36:07 +00:00
Caleb Brose
deedd35a2c Merge branch 'cmbrose/no-ssh-api-call' of https://github.com/cli/cli into cmbrose/no-ssh-api-call 2022-09-20 18:32:01 +00:00
Caleb Brose
373634ad75 Rename to generateAutomaticSSHKeys 2022-09-20 18:32:00 +00:00
Caleb Brose
045bb54157
Apply suggestions from code review
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-09-20 13:22:38 -05:00
Caleb Brose
049a3676f4 Use filepath instead of path 2022-09-20 15:59:38 +00:00
Caleb Brose
3b52df6f99 Don't add private key for -i 2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32 Update tests 2022-09-20 01:02:06 +00:00
Caleb Brose
0c00ca911e Clean up API interface 2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd Remove API call for ssh keys 2022-09-16 22:22:13 +00:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout (#6258) 2022-09-14 11:33:55 +00:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests (#6203) 2022-09-06 15:31:36 +00:00
Caleb Brose
6b24949649
Merge pull request #5958 from cli/cmbrose/no-auto-key-if-uploaded
Check for already configured ssh keys before using automatic key
2022-08-23 12:09:16 -05:00
Sam Coe
6a8deb1f5a
Integrate latest go-gh packages (#6084) 2022-08-18 09:04:13 +03:00
Caleb Brose
d8b06ae8af Add check to -i short circuit for the automatic key 2022-08-16 10:15:43 -05:00
Eljo George
54e5673bd6 remove blank spaces 2022-08-12 21:04:21 +00:00
Eljo George
9f1f74c30a SSH help text to suggest the new features syntax 2022-08-12 21:00:57 +00:00
Caleb Brose
c781ea520a Better .ssh directory 2022-08-10 14:29:14 -05:00
Caleb Brose
3d45244dcc Add -i option to the proxy ssh call in config 2022-08-10 10:57:34 -05:00
Caleb Brose
d410830f7f Handle comment in local ssh key 2022-08-09 11:11:11 -05:00
Caleb Brose
cb914c1873 Cleanup extra param, array declaration 2022-08-09 10:16:24 -05:00
Caleb Brose
b25df2daf4 Merge branch 'trunk' into cmbrose/no-auto-key-if-uploaded 2022-08-09 10:06:37 -05:00
Caleb Brose
0d9b2bf4ce SHort circuit api check if auto keys exist 2022-08-05 18:24:36 +00:00
Mislav Marohnić
2dd63e23fc
Merge pull request #6008 from AyeshaGagguturi/ayesha/delete-prebuild-availibity-enum
Delete blob + pool
2022-08-04 19:09:13 +02:00
Eljo George
53bddb0fd5 Update codespaces ssh doc 2022-08-03 19:50:55 +00:00
Caleb Brose
f63d4c0a4a Linter 2022-08-03 15:50:30 +00:00
Caleb Brose
5212fc8d5b Error handling 2022-08-03 15:26:00 +00:00
Caleb Brose
b6c469518f Linter 2022-08-02 21:53:17 +00:00
Caleb Brose
894b553b78 Add a couple more scenarios 2022-08-02 21:39:33 +00:00
Caleb Brose
d3d72dd820 Add test for hasUploadedPublicKeyForConfig 2022-08-02 21:37:02 +00:00
Caleb Brose
d3c07706a4 Merge branch 'cmbrose/no-auto-key-if-uploaded' of https://github.com/cli/cli into cmbrose/no-auto-key-if-uploaded 2022-08-02 20:57:55 +00:00
Caleb Brose
88b28c5228 Fix api mock 2022-08-02 20:57:52 +00:00
Eljo George
ace223d782 updated message 2022-08-01 23:49:49 +00:00
Eljo George
02902e29b4 CS ssh helptext to indicate how to install ssh 2022-08-01 23:08:14 +00:00
Ayesha Gagguturi
a80a63f3aa Delete blob + pool 2022-07-27 17:03:54 -07:00
Caleb Brose
c9ca2608e6 Invert check 2022-07-22 11:07:57 -05:00
Caleb Brose
414a74b5f5 Even better config support 2022-07-22 11:03:14 -05:00
Caleb Brose
d421664d1f reduce diff 2022-07-17 01:19:42 +00:00
Caleb Brose
6c9d1a9fd4 Switch to using -G instead 2022-07-17 01:09:05 +00:00
Caleb Brose
f313953642 Initial pass 2022-07-16 20:38:23 +00:00
casswedson
00bc550dc6 chore: typo hunting ft. codespell 2022-07-09 21:41:09 -05:00
cmbrose
b2fe329011 Close files to actually fix windows 2022-06-29 12:28:21 -05:00
Caleb Brose
4eac4fbf4c Make a new dir per test to work around windows failures 2022-06-29 11:48:23 -05:00
Caleb Brose
b5348f661e Handle case of partial name match 2022-06-29 11:36:27 -05:00
Caleb Brose
1aa457499d Use Fatal instead to avoid nil-ref 2022-06-29 11:27:18 -05:00
Caleb Brose
fb4ad53dd0 Check MkdirAll error 2022-06-29 11:17:24 -05:00
Caleb Brose
1bae759d3e Don't use strings.Replace 2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147 Rename public key first for edge cases 2022-06-29 10:56:31 -05:00