Commit graph

6 commits

Author SHA1 Message Date
Sam Coe
39805fa9b1
Properly handle closing files that have been writen to (#7199) 2023-03-23 01:17:47 +00:00
Mislav Marohnić
a315e6865c run download: fix extracting to root path
Our rudimentary check for whether a file path is entirely contained
under a directory had a false negative when the parent directory is "/".
2022-02-18 20:27:40 +01:00
Mislav Marohnić
f8c7fd1d28 Fix extracting workflow artifact to a relative path
To prevent zipslip, we verify that each extracted file would fall
strictly under the prefix of the path to extract to. However, this
yielded a false positive when extracting to `.`, which is the default
for downloading a single archive.
2021-04-13 19:15:14 +02:00
Mislav Marohnić
0e94de1ce6 Address run download feedback
- With no arguments in TTY mode, prompt which artifacts to download
- Change `--pattern` argument to be just `--name` and only do exact
  matching
- For multi-archive downloads, prefix the destination path with the name
  of the artifact
- Add tests exercising HTTP functionality
- Avoid "zipslip" path injection when extracting ZIP files
- Add tests for ZIP extraction
2021-04-07 19:56:28 +02:00
Mislav Marohnić
b41681cbb7 Restore Go < 1.16 compatibility 2021-04-02 20:54:56 +02:00
Mislav Marohnić
c54e3c9ca8 Add run download command for downloading workflow artifacts 2021-04-02 20:42:18 +02:00