Jose Garcia
9654dc4bd3
Update to go-liveshare v0.20.0
2021-09-23 10:07:14 -04:00
Mislav Marohnić
090e0c81a1
Merge pull request #171 from github/cli-migration
...
Split out "main" package from "ghcs"
2021-09-21 18:06:06 +02:00
Mislav Marohnić
683d847dd2
Merge remote-tracking branch 'origin' into cli-migration
2021-09-21 17:38:41 +02:00
Jose Garcia
8a53c4369e
Merge pull request #179 from github/jg/close-session
...
liveshare: close sessions
2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220
PR Feedback
...
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
2021-09-21 10:05:48 -04:00
Alan Donovan
0f88081bfa
Merge pull request #178 from github/check-authorized-keys
...
ghcs ssh: check user has authorised SSH keys
2021-09-21 10:03:45 -04:00
Alan Donovan
d3d1ce726d
do logs too
2021-09-21 10:02:55 -04:00
Alan Donovan
f33d430500
Merge pull request #177 from github/delete-surplus-args
...
delete: reject positional arguments
2021-09-21 09:26:22 -04:00
Jose Garcia
a83b3c0816
Update to go-livesare v0.18.0
...
- Only set err if closeErr is non-nil
2021-09-21 08:46:32 -04:00
Jose Garcia
7f682f9c39
Close Live Share sessions
...
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
2021-09-20 16:56:57 -04:00
Alan Donovan
dbb80d8b1e
check for authorised SSH keys
2021-09-20 16:01:43 -04:00
Alan Donovan
9e08b7477d
delete: reject position args
2021-09-20 13:40:45 -04:00
Mislav Marohnić
836075215d
Merge remote-tracking branch 'origin' into cli-migration
2021-09-20 13:59:32 +02:00
Jose Garcia
85f79ed8e8
Merge pull request #159 from github/jg/ssh-cmd-flags
...
ghcs ssh: ssh flags and command support
2021-09-20 07:43:16 -04:00
Jose Garcia
82c19729d3
Wrap -- with optional argument brackets
2021-09-17 15:17:38 -04:00
Jose Garcia
47c6a5fce8
Update usage
2021-09-17 15:13:09 -04:00
Jose Garcia
5890d6ad66
Switch if block logic, assert err string
2021-09-17 15:04:55 -04:00
Jose Garcia
da58313358
Remove redudant type def
2021-09-17 14:03:31 -04:00
Jose Garcia
9f84015bd0
Avoid append
2021-09-17 14:00:16 -04:00
Jose Garcia
65e1c6f789
More test cases
2021-09-17 13:56:38 -04:00
Jose Garcia
76037ee753
Update docs, simplify loop to append to command
2021-09-17 13:54:00 -04:00
Jose Garcia
54265afda0
PR Feedback
...
- use named returns
- handle command flags + test case
- simplify tests
2021-09-17 13:43:23 -04:00
Jose Garcia
60d066f0a6
PR Feedback
...
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
2021-09-17 11:51:37 -04:00
Alan Donovan
67a6f0a85d
Merge pull request #168 from github/restore-delete-r-confirm
...
Restore confirmation to delete -r, lost in botched merge
2021-09-17 11:48:02 -04:00
Alan Donovan
1271e20b9b
Merge pull request #169 from github/delete-no-list
...
delete -r: don't perform "list" operation
2021-09-17 11:28:53 -04:00
Alan Donovan
930f194507
Merge pull request #170 from github/list-show-branch-not-name
...
list: show branch (not name) in branch column
2021-09-17 11:28:26 -04:00
Mislav Marohnić
8c0c7a8e19
Make GITHUB_TOKEN configurable through Go member
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:29:35 +02:00
Mislav Marohnić
c2f3537a32
Separate "main" package from "ghcs" package
...
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:26:20 +02:00
Alan Donovan
ce4bbe5bd8
list: show branch (not name) in branch column
2021-09-17 10:13:35 -04:00
Alan Donovan
d23eca8c5f
remove "list" operation from "delete -r" command
2021-09-17 09:51:11 -04:00
Alan Donovan
747d7e7173
Restore confirmation to delete -r, lost in botched merge
2021-09-17 09:49:46 -04:00
Alan Donovan
6ac8a0ad88
Merge pull request #165 from github/delete-parallel
...
Delete in parallel
2021-09-17 09:34:10 -04:00
Alan Donovan
610ab89c3d
Merge branch 'main' into delete-parallel
2021-09-17 09:32:56 -04:00
Alan Donovan
4de4572813
add comment
2021-09-17 09:31:05 -04:00
Alan Donovan
fb197c8e75
Merge branch 'main' into delete-parallel
2021-09-17 09:30:48 -04:00
Max Beizer
a4f1fa076b
Fix up all the static-check warnings ( #162 )
2021-09-17 13:10:37 +02:00
Alan Donovan
bc74c4aafa
make delete --repo parallel
2021-09-16 18:29:19 -04:00
Jose Garcia
42e47a98d7
add docs, simplify map, error on invalid args
2021-09-16 15:22:47 -04:00
Jose Garcia
8a0f8b6d1c
parse ssh args and command
2021-09-16 10:32:27 -04:00
Christian Gregg
cc1b86461e
Confirm deletion of codespaces with unpushed/uncommited changes ( #129 )
...
Adds a confirmation dialog on `ghcs delete` if the codespace in question
has unpushed or uncommited changes.
This confirmation can be skipped using the `--force` or `-f` flag.
Closes : #84
Closes : #10
2021-09-16 13:47:15 +01:00
Mislav Marohnić
5617db6614
Merge pull request #151 from github/ruleguard
...
Wrap errors using "%w" instead of "%v"
2021-09-16 12:21:36 +02:00
Mislav Marohnić
dbb4e0c177
Merge remote-tracking branch 'origin' into ruleguard
2021-09-16 11:46:50 +02:00
Jose Garcia
514448dde8
Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags
2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f
Merge pull request #154 from github/jg/fix-ctx-error
...
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f
Merge pull request #158 from github/jg/go-liveshare-0.16.0
...
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4
update logs
2021-09-15 15:40:07 -04:00
Alan Donovan
eafadd3757
Merge pull request #156 from github/api-internal
...
move api to internal/api
2021-09-15 15:38:11 -04:00
Jose Garcia
c5bd8c4127
initial spike to accept args
2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082
add back codespaces.Shell
2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567
upgrade to go-liveshare 0.16.0
2021-09-15 15:15:28 -04:00
