Jose Garcia
|
5890d6ad66
|
Switch if block logic, assert err string
|
2021-09-17 15:04:55 -04:00 |
|
Jose Garcia
|
da58313358
|
Remove redudant type def
|
2021-09-17 14:03:31 -04:00 |
|
Jose Garcia
|
9f84015bd0
|
Avoid append
|
2021-09-17 14:00:16 -04:00 |
|
Jose Garcia
|
76037ee753
|
Update docs, simplify loop to append to command
|
2021-09-17 13:54:00 -04:00 |
|
Jose Garcia
|
54265afda0
|
PR Feedback
- use named returns
- handle command flags + test case
- simplify tests
|
2021-09-17 13:43:23 -04:00 |
|
Jose Garcia
|
60d066f0a6
|
PR Feedback
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
|
2021-09-17 11:51:37 -04:00 |
|
Jose Garcia
|
42e47a98d7
|
add docs, simplify map, error on invalid args
|
2021-09-16 15:22:47 -04:00 |
|
Jose Garcia
|
8a0f8b6d1c
|
parse ssh args and command
|
2021-09-16 10:32:27 -04:00 |
|
Jose Garcia
|
514448dde8
|
Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags
|
2021-09-15 15:45:53 -04:00 |
|
Jose Garcia
|
10ad85486f
|
Merge pull request #154 from github/jg/fix-ctx-error
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
|
2021-09-15 15:45:35 -04:00 |
|
Jose Garcia
|
c5bd8c4127
|
initial spike to accept args
|
2021-09-15 15:37:37 -04:00 |
|
Jose Garcia
|
26d3199082
|
add back codespaces.Shell
|
2021-09-15 15:18:54 -04:00 |
|
Jose Garcia
|
ecd0c70567
|
upgrade to go-liveshare 0.16.0
|
2021-09-15 15:15:28 -04:00 |
|
Jose Garcia
|
547c629220
|
fix ctx cancellation errors & fix todo for X11 forwarding
|
2021-09-15 10:38:19 -04:00 |
|
Alan Donovan
|
981b2545bc
|
sketch of changes for https://github.com/github/go-liveshare/pull/13
|
2021-09-02 17:08:17 -04:00 |
|
Alan Donovan
|
3485bacc97
|
fix StartSharing data race
|
2021-09-02 15:53:56 -04:00 |
|
Alan Donovan
|
8570f4111d
|
sketch after API changes in go-liveshare#11
|
2021-09-02 12:38:27 -04:00 |
|
Alan Donovan
|
37b2f5e979
|
Merge branch 'main' into runcommand
|
2021-08-31 17:18:52 -04:00 |
|
Alan Donovan
|
f1c3a22a0b
|
Merge branch 'main' into product-spelling
|
2021-08-31 16:24:41 -04:00 |
|
Alan Donovan
|
c0aae52289
|
move port choice, and PortForwarder.Start call, into clients
|
2021-08-31 13:58:46 -04:00 |
|
Alan Donovan
|
509e037a5e
|
address review comments
|
2021-08-31 12:02:29 -04:00 |
|
Alan Donovan
|
bbcf2dd321
|
spell product names (Codespaces, Live Share) correctly
|
2021-08-31 11:15:26 -04:00 |
|
Alan Donovan
|
40317e91f8
|
cleanup to ssh api
|
2021-08-30 17:46:04 -04:00 |
|
Edmundo Gonzalez
|
903b7be7de
|
Comments from pr.
|
2021-08-30 21:01:13 +00:00 |
|
Edmundo Gonzalez
|
954d46dce5
|
Changes from comments on pr.
|
2021-08-30 17:30:28 +00:00 |
|
Edmundo Gonzalez
|
13917a289d
|
Moved function to ssh.go file.
|
2021-08-30 04:52:27 +00:00 |
|
Edmundo Gonzalez
|
5db9e2d83e
|
PR changes.
|
2021-08-30 04:48:56 +00:00 |
|
Edmundo Gonzalez
|
b6094e0006
|
Changes to point to RPC service.
|
2021-08-26 21:50:20 +00:00 |
|
Mislav Marohnić
|
b47686163a
|
Fixes for log/output streams
|
2021-08-17 13:04:55 +02:00 |
|
Jose Garcia
|
58a055609d
|
logs cmd spike and refactor of ssh tunnel methods
|
2021-07-29 10:57:51 -04:00 |
|