Commit graph

32 commits

Author SHA1 Message Date
vilmibm
5bc6d220c4 review feedback 2020-01-13 15:32:07 -06:00
vilmibm
bbdf30c8f8 add tests for pr/issue previewing in terminal 2020-01-10 15:40:09 -06:00
Corey Johnson
f2afbbce74 Fix test output 2019-12-20 12:07:53 -08:00
Corey Johnson
58761a8dfc Fix tests 2019-12-20 12:04:23 -08:00
Corey Johnson
8f74b658b2 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-20 11:51:37 -08:00
Corey Johnson
bcf1f98702 Do a better job of reverting test changes 2019-12-20 11:32:27 -08:00
Corey Johnson
d025d2d4f3 Revert test changes 2019-12-20 11:24:03 -08:00
Mislav Marohnić
00cede9e5f Fix issue list re: issues that have an assignee
Given the GraphQL query:

    issues(filterBy: {assignee: $assignee})

It turns out that passing a query variable `"assignee": null` is NOT
equivalent to omitting the variable altogether:

- `"assignee": null` seems to filter out issues that HAVE an assignee;
- omitting `assignee` correctly returns all issues.
2019-12-20 13:07:11 +01:00
Mislav Marohnić
bd9b3b9bb5 Add tests for issue status/list/create on repos with issues disabled 2019-12-19 15:54:08 +01:00
Mislav Marohnić
66534e504b Warn about repo issues disabled on issue create 2019-12-19 15:44:20 +01:00
Mislav Marohnić
915dd8b0ef Warn about repo issues disabled on issue status/list 2019-12-19 15:44:20 +01:00
Mislav Marohnić
d9ca764ac2 Look up the repository only once in issue status GraphQL 2019-12-19 15:44:20 +01:00
Mislav Marohnić
2c1fc56967 Update output expectations 2019-12-17 13:01:45 +01:00
Mislav Marohnić
7b7c985e79 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-17 13:00:10 +01:00
Mislav Marohnić
4ad89829c5 Merge remote-tracking branch 'origin/master' into stderr-tests 2019-12-17 12:42:01 +01:00
Corey Johnson
91267a65fa Fix tests 2019-12-16 13:18:16 -08:00
Nate Smith
00da5c2788 Merge pull request #158 from github/issue-create-web
Add "Opening URL in your browser" notice to `issue create --web`
2019-12-16 10:53:31 -06:00
Mislav Marohnić
48aeff1ca7 Assert stdout separarely from stderr in command tests
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.

Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
57c7266328 Fix displaying "There are no issues assigned to you" notice 2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a Add "Opening URL in your browser" notice to issue create --web 2019-12-16 13:39:22 +01:00
Mislav Marohnić
b223176b37 Accept issue URL in issue view <issue>
Also validates that the issue passed either by number or by URL exists.
2019-12-03 21:41:22 +01:00
Mislav Marohnić
2621bccc44 Use RunCommand in tests to ensure flags reset between runs 2019-12-03 17:26:28 +01:00
Nate Smith
89700216c6 Merge pull request #97 from github/issue-create-editor
Use survey when creating issues
2019-11-25 11:34:11 -06:00
Mislav Marohnić
a650cbe002 Simplify parsing API issues 2019-11-22 17:04:32 +01:00
vilmibm
84d393d543 fix issue create test 2019-11-20 11:57:17 -06:00
Corey Johnson
75a3496bf1 Test flags 2019-11-18 11:05:43 -08:00
Corey Johnson
761d29cf5e Fix test 2019-11-14 12:40:48 -08:00
Corey Johnson
44c7495bab Add state 2019-11-12 14:31:24 -08:00
Mislav Marohnić
25142d4895 Add issue create test 2019-11-08 15:20:24 +01:00
Mislav Marohnić
524fe0a69b 🔥 last instance of mockOpenInBrowser 2019-11-06 19:41:18 +01:00
Corey Johnson
738562436f Update tests 2019-11-06 10:02:35 -08:00
Corey Johnson
cf1feb847e Add gh issue list and gh issue view ISSUE_NUMBER 2019-10-31 11:02:27 -07:00