STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8870 commits 87 branches 0 tags 160 MiB
Commit graph

8870 commits

This branch
This branch
All branches
Author SHA1 Message Date
Meredith Lancaster
37e0969f20 remove spaces 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:51 -07:00
Meredith Lancaster
3c0280c4d7 undo name change for now 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:23 -07:00
Meredith Lancaster
7838e912b6 more mock http client cleanup 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:37:02 -07:00
Tyler McGoffin
58ca3c69bb Update triage.md to reflect FR experiment outcome 2025-01-07 10:36:15 -08:00
Meredith Lancaster
9d88ca8cf8 simplify mock http client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:32:49 -07:00
Meredith Lancaster
ecf55c6c16 use mock to assert number of http calls 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:54:17 -07:00
Meredith Lancaster
e34e188ee2 add http client test constructors 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:43:24 -07:00
Meredith Lancaster
9ecd90c26c setup testing struct for test cases 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:24:42 -07:00
nobe4
442be87acb
Merge branch 'trunk' into fancier-extention-upgrade 2025-01-07 12:04:35 +01:00
nobe4
3b69ea6fbc
feat: make the extension upgrade fancier 
This left-pad the extension names during upgrade so they all align
nicely. It makes easier to see what is happening.
 2025-01-07 12:01:02 +01:00
Andy Feller
0006091d76
Fix up intra-org fork test setup 
[1] 96ac8d6a2f
 2025-01-07 10:22:51 +11:00
Andy Feller
be250b3d33
Add renamed acceptance tests 2025-01-07 10:22:49 +11:00
Andy Feller
8bb2879b87
Reflect coverage for view and status subcommands 2025-01-07 10:22:48 +11:00
Andy Feller
eb16a75ab1
Expand with gh pr status 2025-01-07 10:22:46 +11:00
Andy Feller
2d1e4d625b
Add base gh pr view acceptance tests for changes 
These are acceptance tests based on @williammartin work within various issues associated with #9208.

These need to be enhanced to account for `gh pr status`, however that should be quicker given these pass based on the updated branch and upstream fix for cross-repo same org changes.
 2025-01-07 10:22:44 +11:00
Frederick Zhang
4254818dbd
Find push remote using branch.<name>.pushRemote and remote.pushDefault 
When using a push.default = current triangular workflow, apart from
using @{push} to determine the remote branch name, we should also follow
the

1. branch.<name>.pushRemote
2. remote.pushDefault
3. branch.<name>.remote

...list to determine which remote Git pushes to.
 2025-01-07 10:22:39 +11:00
Frederick Zhang
7fc35fd47d
Only find PRs w/ branch.<name>.merge if push.default = upstream/tracking 
When push.default is not 'upstream' / 'tracking' (or 'nothing'), we can
expect local and remote branch names to be the same and solely rely on
@{push} or RemoteURL.

This fixes the wrong error message 'no pull requests found for branch
"<target branch>"' when the local branch is not pushed in the
push.default = simple / current and upstream = <target branch> setup.
 2025-01-07 10:18:07 +11:00
Frederick Zhang
0179381efd
Find PRs using @{push} 
When using a push.default = current central workflow [1], we should use
@{push} instead to locate the remote branch.

In fact, @{push} covers most cases in push.default = upstream too. The
branch.<name>.merge is probably only needed when using RemoteURL and
different remote / local branch names.

[1] https://github.com/tpope/vim-fugitive/issues/1172#issuecomment-522301607
 2025-01-07 10:18:01 +11:00
Michael Hoffman
b3be3aa16b
Merge branch 'trunk' into create-autolinks 2025-01-06 16:09:40 -05:00
Andy Feller
40984d1eb6
Merge pull request #10186 from cli/wm/clear-up-fine-grained-pats-auth-login 
Clear up --with-token fine grained PAT usage
 2025-01-06 15:24:37 -05:00
Meredith Lancaster
69865117ab add mutex for test field 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 13:14:02 -07:00
Meredith Lancaster
fb4fc7e7c2 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:58:13 -07:00
Meredith Lancaster
0202ca8df5 add test case for bundle url fetch failure 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 12:58:09 -07:00
Meredith Lancaster
b1af4b0ce3
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:49:27 -07:00
Andy Feller
b3be16e98e
Merge pull request #10190 from cli/andyfeller/go-gh-2.11.2-security-bump 
Bump cli/go-gh for indirect security vulnerability
 2025-01-06 14:38:49 -05:00
Andy Feller
757966ca7c Bump cli/go-gh for indirect security vulnerability 2025-01-06 14:27:03 -05:00
Meredith Lancaster
e03a36ea3c add tests for bundle url fetch and fallback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 12:12:26 -07:00
Tyler McGoffin
1f4e005562
Merge pull request #10158 from aryanbhosale/trunk 
fix(repo fork): add non-TTY output when fork is newly created
 2025-01-06 10:11:14 -08:00
Michael Hoffman
db51c36433
Merge branch 'cli:trunk' into create-autolinks 2025-01-06 12:46:04 -05:00
Meredith Lancaster
070b67e5a4 fetch bundles in parallel 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:44:55 -07:00
Meredith Lancaster
311f2b2e23 return fetch attestations err directly 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:39:40 -07:00
Tyler McGoffin
2358fcee83
Merge pull request #10177 from cli/cmbrose/pr-create-upstream-fix 
Handle missing upstream configs for `gh pr create`
 2025-01-06 09:32:00 -08:00
Meredith Lancaster
fc984c91d0 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 10:21:37 -07:00
Meredith Lancaster
9051da39fc provide additional logging and fallback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-06 10:19:47 -07:00
Meredith Lancaster
706314b005
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 09:57:57 -07:00
William Martin
c3b41e87b8 Panic mustParseTrackingRef if format is incorrect 2025-01-06 10:33:28 -06:00
William Martin
8b5073d617 Move trackingRef into pr create package 2025-01-06 10:33:28 -06:00
William Martin
62ecb1c84d Make tryDetermineTrackingRef tests more respective of reality 
Though it doesn't really matter, in practice upstream is always going to come before origin.
 2025-01-06 10:33:28 -06:00
William Martin
57ba5e5608 Rework tryDetermineTrackingRef tests 2025-01-06 10:33:28 -06:00
William Martin
b8c167970b Avoid pointer return from determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
27bd4b2aec Doc determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
05764b8114 Don't use pointer for determineTrackingBranch branchConfig 2025-01-06 10:33:28 -06:00
William Martin
dc077dc09b Panic if tracking ref can't be reconstructed 2025-01-06 10:33:28 -06:00
William Martin
3ae4e5da20 Document and rework pr create tracking branch lookup 2025-01-06 10:33:28 -06:00
William Martin
e7d49fb78c
Update pkg/cmd/auth/login/login.go 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-01-06 17:21:02 +01:00
Kynan Ware
106d5d1144
Merge pull request #10181 from jsoref/issue-10084 
Upgrade generated workflows
 2025-01-06 09:08:33 -07:00
William Martin
3695bda637 Clear up --with-token fine grained PAT usage 2025-01-06 16:41:48 +01:00
Josh Soref
dd32a9cc94 Upgrade generated workflows 
Use `cli/gh-extension-precompile@v2`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2025-01-05 23:18:28 -05:00
Michael Hoffman
fdf9a6e2f6 Fix typos 2025-01-05 19:41:15 -05:00
Michael Hoffman
afcaa1934c
Merge branch 'trunk' into create-autolinks 2025-01-05 15:57:09 -05:00