Andy Feller
97eb8a194e
Simplifying cleanExtensionUpdateDir logic
...
This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not.
2025-01-10 14:29:55 -05:00
Andy Feller
20062233c8
Separate logic for checking updates
...
During discussion in cli/cli#9934 , we can to the conclusion that the logic around checking for core GitHub CLI updates would diverge from GitHub CLI
extension updates over time. To that end, this commit splits that logic into a separate function with a new environment variable.
2025-01-10 14:16:46 -05:00
William Martin
889c4c75f3
Collapse dryrun checks in ext bin upgrade
2025-01-10 16:06:01 +01:00
Andy Feller
edc0351c85
Fix failig local extension tests
...
Extensions have to be gh- prefixed and these newer tests were failing because of expectation.
2024-12-13 23:20:42 -05:00
Andy Feller
bfc63a14cc
Implement remaining PR feedback
...
After merging in upstream changes regarding local extensions, this commit addresses remaining PR feedback while also bringing the newly merged tests into alignment with other changes.
2024-12-13 23:09:18 -05:00
Andy Feller
5ad6ccf73a
Merge branch 'trunk' into andyfeller/cli-cli-8183-timeout-pt2
2024-12-13 22:53:13 -05:00
Andy Feller
c12e3694e8
Implement partial feedback before trunk update
2024-12-13 22:52:03 -05:00
Meredith Lancaster
9b905d9f18
Merge pull request #9891 from malancas/print-policy-info
2024-12-13 15:14:05 -07:00
Phill MV
dd95e5a863
tweak output of build policy info
2024-12-13 15:55:49 -05:00
Kynan Ware
b3f74900f2
Merge pull request #10078 from cli/10077-gh-pr-view-cannot-find-pr-from-branch-when-fork-is-in-the-same-org-as-upstream
...
Support `pr view` for intra-org forks
2024-12-13 11:44:43 -07:00
Phill MV
c789b56da4
Merge pull request #9954 from cli/phillmv/improve-gh-at-inspect
2024-12-13 09:50:52 -05:00
William Martin
d662226ae4
Name conditionals in PR finder
2024-12-13 14:33:33 +01:00
William Martin
96ac8d6a2f
Support pr view for intra-org forks
2024-12-13 14:27:41 +01:00
Kynan Ware
c35d725b0b
Merge pull request #10074 from cli/kw/cli-7011-fix-delete-branch-with-merge-queue-v2
...
`gh pr merge --delete-branch` exits with error when merge requested via merge queue
2024-12-12 16:05:06 -07:00
Kynan Ware
253b082600
Return err instead of silentError in merge queue check
2024-12-12 15:54:01 -07:00
Meredith Lancaster
76ffe4fb28
Merge pull request #9999 from malancas/sigstore-verifier-cleanup
...
Sigstore verifier logic updates
2024-12-12 15:10:52 -07:00
Phill MV
cae97c9da8
linting pointed out this var is no longer used
2024-12-12 17:00:02 -05:00
Phill MV
75cbdc0d04
Removed fun, but inaccessible ASCII header
2024-12-12 16:58:26 -05:00
Phill MV
85f9cfdccb
further tweaks to the long description
2024-12-12 16:56:02 -05:00
Kynan Ware
439cfa08bb
Exit on pr merge with -d and merge queue
...
When running `gh pr merge -d` on a repo with a merge queue policy, exit before attempting to merge.
2024-12-12 14:49:38 -07:00
Phill MV
94943eac10
Merge branch 'phillmv/improve-gh-at-inspect' of github.com:cli/cli into phillmv/improve-gh-at-inspect
2024-12-12 16:47:11 -05:00
Phill MV
94525f83f6
Addressed PR review feedback; expanded Long command help string, used ghrepo, clarified some abbreviations
2024-12-12 16:46:58 -05:00
Phill MV
e7f3d739ba
Update pkg/cmd/attestation/inspect/inspect.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-12 16:20:56 -05:00
Andy Feller
5e9283c70c
Merge pull request #10026 from ankddev/better-document-auth-scopes
...
docs: better document auth scopes
2024-12-12 11:16:14 -05:00
Andy Feller
4f32282f93
Update gh auth commands to point to GitHub Docs
...
After initial discussion with core maintainers, it didn't seem prudent to duplicate the GitHub Docs information on OAuth scopes within the GitHub CLI codebase.
Instead, this commit updates help usage information in relevant commands on the page within GitHub Docs for more information.
2024-12-12 11:03:57 -05:00
Kynan Ware
e2422b7e7e
Merge pull request #9933 from cli/kw/improve-ext-installation-no-executable-error
...
Improve documentation and error messaging for local extension installations without executables
2024-12-12 07:08:16 -07:00
William Martin
46862f96d9
Reformat ext install long
2024-12-12 14:57:34 +01:00
Kynan Ware
32abca8c38
Mention Windows quirk in ext install help text
2024-12-12 06:42:34 -07:00
Kynan Ware
3b93e28910
Fix error mishandling in local ext install
2024-12-12 06:40:37 -07:00
Kynan Ware
ec4b2dfe1b
Assert on err msg directly in ext install tests
2024-12-12 06:38:04 -07:00
Kynan Ware
b9b60637b9
Clarify hosts in ext install help text
2024-12-12 06:35:13 -07:00
Andy Feller
c8501d82f2
Add build constraint for non-Windows systems
2024-12-11 22:27:59 -05:00
Andy Feller
56841d9cee
Add build constraint for non-Windows systems
2024-12-11 22:25:08 -05:00
Phill MV
19bc3cd886
Removed now redundant file
2024-12-11 17:07:56 -05:00
Phill MV
82a849742e
minor tweak to language
2024-12-11 16:58:37 -05:00
Phill MV
7bd59e091f
Deleted no-longer-used code.
2024-12-11 16:51:23 -05:00
Phill MV
ac93417c29
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-12-11 16:50:01 -05:00
Phill MV
465b6ff889
deleted now-invalid tests, added a tiny patina of new testing.
2024-12-11 16:48:29 -05:00
Phill MV
bc236db9e5
Tightened up docs, deleted dead code, improved printing
2024-12-11 16:26:08 -05:00
Andy Feller
52b845bcad
Refactor local installation manager test by OS
...
- Local extensions on Windows are not symlinks but files whose contents is the path to the local extension directory
- Local extensions elsewhere are symlinks
2024-12-10 22:13:48 -05:00
Kynan Ware
e8e30dab6a
Merge branch 'trunk' into issue-10038
2024-12-10 14:17:11 -07:00
Kynan Ware
9d53b86436
Merge pull request #10044 from cli/kw/cli-10034-repo-rename-docs-and-prompt-updates
...
`gh repo rename` help text clarifies new repo name should not include owner
2024-12-10 14:07:08 -07:00
Uday R
40beb82e0c
fix: list branches in square brackets in gh codespace
2024-12-10 15:19:30 -05:00
Meredith Lancaster
23a3c18d56
Merge pull request #10020 from malancas/attestation-fetch-integration-tests
2024-12-10 07:56:57 -07:00
Uday R
8afb434e59
test(gh run): assert branch names are enclosed in square brackets
2024-12-09 12:45:36 -05:00
Kynan Ware
167e868fe2
docs: enhance help text and prompt for rename command
2024-12-09 10:16:38 -07:00
William Martin
54a7f4de70
Revert "Confirm auto-detected base branch"
...
This reverts commit e021a07285
2024-12-09 13:01:00 +01:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
...
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.
Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
...
Merges changes from @williammartin including acceptance tests and word changes.
Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Andy Feller
a6b8bec70d
Remove unnecessary Extension.FullName()
2024-12-08 21:17:26 -05:00
