Commit graph

57 commits

Author SHA1 Message Date
bchadwic
98a5541d15 Started to fix the flags and the restrictions using them 2021-06-08 20:35:38 -07:00
bchadwic
95afca882b Finished refactoring now 2021-06-08 16:35:53 -07:00
bchadwic
506bd4b2de working on refactoring the output, the tests and how opts is structured 2021-06-08 15:36:11 -07:00
Benjamin Chadwick
698ca014c7
Merge pull request #38 from bchadwic/trunk
Redefined browse output, and added in more test cases
2021-06-08 13:12:48 -07:00
Benjamin Chadwick
9fe986a480
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:48:17 -07:00
Benjamin Chadwick
891f4af69c
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:56 -07:00
Benjamin Chadwick
94002bf0cc
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:44 -07:00
ravocean
898d585e6a A small change in code 2021-06-07 22:00:05 -07:00
bchadwic
569d2fd58a Got tests objects to fully work! Currently working on making more test cases 2021-06-07 21:47:08 -07:00
ravocean
449858158d Continued to work on the output of test file 2021-06-07 12:57:36 -07:00
Jessica Sestak
f792704003 Worked on browse_test.go, still not getting errors 2021-06-07 11:04:29 -07:00
bchadwic
6ed9900084 working on the test file for the browse.go 2021-06-06 01:09:43 -07:00
ttran112
e425e897a6 create new test file for first browse branch 2021-06-05 23:31:19 -07:00
ttran112
1a9704dbfb fix the route 2021-06-05 22:46:46 -07:00
Benjamin Chadwick
bc3a341479
Update browse.go 2021-06-05 21:56:06 -07:00
Jessica Sestak
6f09e4f51a Fixed print error messages and returning error from openInBrowser 2021-06-05 21:47:03 -07:00
bchadwic
6fc36cf01f Fixed long message 2021-06-05 17:48:52 -07:00
bchadwic
e28000b5d2 Worked on help section 2021-06-05 17:46:07 -07:00
Benjamin Chadwick
95ceb85ee5
Delete helpful-resources.txt 2021-06-02 12:42:09 -07:00
Benjamin Chadwick
5aeca61fd0
Delete browse_test.go 2021-06-02 12:42:03 -07:00
ravocean
6391bf5801 Starter code for testing 2021-05-31 16:39:10 -07:00
bchadwic
798e03cf15 working on testing browse.go 2021-05-31 15:21:15 -07:00
ttran112
52e7b7cc86 added the message to help the user navigate github 2021-05-31 14:08:15 -07:00
Jessica Sestak
0bfeb8926a Fixed error messages, added repo override 2021-05-31 13:02:05 -07:00
ravocean
a8a01badf1 Finished refactoring (addCombined) 2021-05-31 11:42:48 -07:00
bchadwic
c162a28099 started to refactor the code base 2021-05-31 10:57:16 -07:00
ttran112
5077d4794c fixed the 404 edge case error 2021-05-30 20:25:11 -07:00
ttran112
cb3792051a fix minor error and add branchName for addArgs, addCombine 2021-05-26 19:27:07 -07:00
ttran112
3a48c35bc6 fix addArgs and combine by addding branchName parameter 2021-05-26 17:45:42 -07:00
Jessica Sestak
88ce5320f6 made branch and line flags, fixed path 2021-05-25 23:04:42 -07:00
Jessica Sestak
a65266bf36 added combination of args, partial fix to args 2021-05-25 22:47:08 -07:00
ravocean
1e61f41cd9 Tidied up the logic of openInBrowser 2021-05-25 21:42:42 -07:00
Ben
50af6c1658 broke the flag checking into a separate function, and created a http response checker function 2021-05-25 17:54:23 -07:00
bchadwic
24abf29acb created a test file 2021-05-24 21:16:37 -07:00
bchadwic
70e72afdcc cleaned up, added suggestion to 404 handling 2021-05-24 13:06:33 -07:00
bchadwic
fdca340b28 simplified the if block for flags, now allows for checking destination before opening browser 2021-05-24 12:53:17 -07:00
bchadwic
88e2a9f748 cleaned logic and added in a print function that takes in an exitCode 2021-05-24 12:48:32 -07:00
Jessica Sestak
edebfa104b Added errors and started defining the the path for flags and args to open in the browser. 2021-05-23 19:04:38 -07:00
ravocean
b22519309f Fixed the name of projects flag 2021-05-23 16:01:18 -07:00
ravocean
e4b2ec202d We added a few flags based on priority 2021-05-23 15:57:29 -07:00
ravocean
6e7cd6fd05 Added parseArgs() function, beginning to work on parseFlags() functions 2021-05-23 15:31:01 -07:00
Benjamin Chadwick
f66a086a5d
Merge branch 'trunk' into trunk 2021-05-23 12:35:53 -07:00
jlsestak
e4e8b77c7d
Update browse.go 2021-05-23 12:30:27 -07:00
jlsestak
bab7b498ec
Update browse.go 2021-05-23 12:23:33 -07:00
Ben
b8de5c87e1 removed help message for non error operation 2021-05-19 22:45:03 -07:00
Ben
d8c20faa65 added in a help dialogue and error message 2021-05-19 22:14:58 -07:00
Ben
daf27af34a only accepts 1 arg at most 2021-05-19 19:17:14 -07:00
Ben
14a40fb0db added a return statement to avoid a segmentation fault on a null baseRepo, error handling will be improved more later 2021-05-19 13:13:23 -07:00
Ben
697ff425a8 disregard 2021-05-19 13:09:30 -07:00
Ben
097dd25884 redefined how gh browse opens the repo. We now use the BaseRepo to extract the correct paths. This should make it easier to navigate to other directories within the repo using the repoUrl variable created 2021-05-19 12:57:56 -07:00