Commit graph

139 commits

Author SHA1 Message Date
Robin Neatherway
3ab01661e4 Add on: pull_request trigger to CodeQL workflow
From February 2021, in order to provide feedback on pull requests, Code Scanning workflows must be configured with both `push` and `pull_request` triggers. This is because Code Scanning compares the results from a pull request against the results for the base branch to tell you only what has changed between the two.

Early in the beta period we supported displaying results on pull requests for workflows with only `push` triggers, but have discontinued support as this proved to be less robust.

See https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#scanning-pull-requests for more information on how best to configure your Code Scanning workflows.
2021-01-13 11:09:00 +00:00
Mislav Marohnić
19ee0eff08 Simplify linter output setup
`golangci-lint` now supports an output formatter for GitHub Actions, so
we don't need to manually reformat the failure output anymore.
2021-01-07 16:16:44 +01:00
Pete Woods
03949a4d72
Build static binaries
Fixes #2555
2020-12-07 15:49:58 +00:00
Amanda Pinsker
436846a715
Add design system docs to contributing 2020-11-25 11:58:26 -08:00
Sam
1ed4f049a1
Merge pull request #2113 from cli/move-project-cards-fix
Fix moving all "Pending release" project cards to the "Done" column
2020-10-27 12:01:30 +03:00
Mislav Marohnić
d66fd2fe9e Remove needs-user-input from "please avoid"
The user input might have come in a reply already, but the maintainers
haven't gotten around to remove the stale label yet. This shouldn't
prevent someone from submitting a PR.
2020-10-13 18:06:00 +02:00
Mislav Marohnić
ef907463d9 Fix label links 2020-10-13 18:05:27 +02:00
Mislav Marohnić
bb6a571ab5 Tweak contributing guidelines 2020-10-13 16:40:40 +02:00
Mislav Marohnić
20f88bbd5a Update references to the help wanted label after rename
GitHub has some special behavior for the `help wanted` label, but not
the `help-wanted` label, so I've renamed ours.

Bonus: updated links to docs.github.com
2020-10-09 19:06:25 +02:00
Mislav Marohnić
fe9d390af0 Update deprecated set-env and add-path
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-06 15:57:08 +02:00
Mislav Marohnić
4bfde21b1b Fix moving all "Pending release" project cards to the "Done" column
Previously only the first 30 project cards were moved.
2020-10-06 15:48:03 +02:00
Mislav Marohnić
0d593e78aa
Merge pull request #2056 from cli/scoop
Fix updating scoop bucket, homebrew-core formula on release
2020-10-06 15:04:06 +02:00
Mislav Marohnić
01bd0dce5e fix hub release download 2020-10-06 15:01:59 +02:00
Mislav Marohnić
70412ef06a Add trailing newline 2020-10-02 17:48:40 +02:00
Mislav Marohnić
419566345b Fix bumping the Homebrew formula
The gh formula in homebrew-core went back and forth between git-style
and tarball-style. Now that it's back to tarball, update the action to
reflect that.
2020-10-01 19:10:30 +02:00
Mislav Marohnić
4bf2e513c7 Use default token for Goreleaser action
Now that Goreleaser doesn't need to update any external repositories, we
can use the default generated GITHUB_TOKEN for releases.
2020-10-01 19:09:46 +02:00
Mislav Marohnić
0a17259e3c Bump scoop bucket manually on release
Goreleaser can no longer do this for us since we're always creating a
draft release initially.
2020-10-01 19:09:14 +02:00
Nate Smith
72eeae9d1d
Update CONTRIBUTING.md 2020-09-30 17:17:58 -05:00
vilmibm
91fcfa548f Sentence Case. 2020-09-29 11:00:12 -05:00
vilmibm
746ab7354a mention new core label in contributing docs 2020-09-29 10:47:51 -05:00
vilmibm
74665b213a support more ubuntus 2020-09-17 14:18:06 -05:00
vilmibm
f46ebf9cea support more debians 2020-09-16 12:47:16 -05:00
Nate Smith
50211eade3
add issue template for general feedback
is this a good idea?
2020-09-15 12:00:07 -05:00
Cristian Dominguez
3d350e8707
Go 1.15+ is required to run the test suit 2020-09-14 20:31:22 +00:00
vilmibm
e59431eeef more ubuntus 2020-09-08 16:26:25 -05:00
Mislav Marohnić
a983131479 Exercise most of the release process on prereleases
- deb and rpm packages are now built for prereleases
- consolidate setup for deb & rpm
- man pages are generated for prereleases
- the `cli.github.com` site is only pushed to on full releases

Bonus:
- only publish the GitHub release after the Windows MSI is uploaded
- hub does not need downloading
2020-09-07 16:11:27 +02:00
vilmibm
894be03923 linux repo creation 2020-09-03 13:47:48 -05:00
Sam Coe
b4956006be Fix up feature request issues url 2020-09-01 15:52:58 +02:00
Sam Coe
35e739dfbd Link to bugs and feature requests 2020-09-01 10:25:16 +02:00
Sam Coe
022d29ce79 Further cleanup up README links and update contributing doc 2020-09-01 09:40:27 +02:00
Mislav Marohnić
176dd29c05 Clarify our Go version requirements
* We are trying to keep the binary building on Go 1.13 to support building the project on Ubuntu 20.04 LTS
* Go 1.14+ is required to run the test suite
* We build our releases on Go 1.15

This adds a CI check that verifies that the project compiles on 1.13
2020-08-28 14:05:50 +02:00
Nate Smith
66da8a2431
Update CONTRIBUTING.md 2020-08-14 09:30:30 -05:00
Shoma Okamoto
bcc1b433ab bump go version to 1.15 in docs 2020-08-14 10:00:04 +09:00
Shoma Okamoto
06b579c976 update go version 2020-08-13 22:22:27 +09:00
Mislav Marohnić
4757540bdf Align bump-homebrew-formula config for updated formula format 2020-07-31 19:47:13 +02:00
Mislav Marohnić
41f7b054e6 Bump golangci-lint to v1.29.0
Trying to address https://github.com/cli/cli/pull/1406/checks?check_run_id=896316941
which I cannot reproduce locally on macOS
2020-07-22 14:18:18 +02:00
Mislav Marohnić
9c7d52f9f6 Bump golangci-lint 2020-07-02 17:02:38 +02:00
Mislav Marohnić
fb80cfbd6f
Merge pull request #1163 from micnncim/fix-pull-request-template
Remove duplicated words in PULL_REQUEST_TEMPLATE
2020-06-11 13:32:55 +02:00
micnncim
0c717ccfa8 Remove duplicated words in PULL_REQUEST_TEMPLATE 2020-06-11 19:58:07 +09:00
Mislav Marohnić
e19ea12265 Merge remote-tracking branch 'origin' into blank-issue 2020-06-10 12:35:33 +02:00
Davor Kapsa
27026d738a
Update releases.yml 2020-06-09 14:35:44 +02:00
Davor Kapsa
26185467a8
update lint.yml 2020-06-09 14:34:41 +02:00
Davor Kapsa
8ace991c94
update go.yml 2020-06-09 14:32:50 +02:00
Mislav Marohnić
9d11cedd18 Rename "master" to "trunk" in various links 2020-05-26 20:57:26 +02:00
Mislav Marohnić
cd163f020c Fix linter in CI
It turns out that YAML anchors are not supported
https://github.com/cli/cli/actions/runs/115915028
2020-05-26 18:28:19 +02:00
Mislav Marohnić
54e68ae5b2 Enable linting for pull requests 2020-05-22 19:40:00 +02:00
vilmibm
d800e3f0b6 rely on environment 2020-05-18 15:07:28 -05:00
vilmibm
01f272dead give our pr template a name 2020-05-18 11:44:21 -05:00
Mislav Marohnić
1fb27af96b Bump golangci-lint 2020-05-07 21:04:44 +02:00
Mislav Marohnić
0eb471899a Upgrade to Go 1.14 in CI 2020-05-07 21:03:42 +02:00