STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
400 commits 87 branches 0 tags 160 MiB
Commit graph

86 commits

Author SHA1 Message Date
Jose Garcia
3e26a15342 Merge pull request #188 from github/jg/update-liveshare 
Update to go-liveshare v0.20.0
 2021-09-23 10:22:09 -04:00
Jose Garcia
f1c35ba9da Update docs 2021-09-23 10:21:01 -04:00
Jose Garcia
9654dc4bd3 Update to go-liveshare v0.20.0 2021-09-23 10:07:14 -04:00
Jose Garcia
186b90b12e Rename request type 2021-09-23 08:29:24 -04:00
Jose Garcia
13d7804a35 Remove API test, inline poller 2021-09-23 08:26:23 -04:00
Jose Garcia
9a558bc58c Early return if polling is not required 
- Add context to errors in poller
 2021-09-22 15:03:12 -04:00
Jose Garcia
208f1721b5 Rename ProvisionCodespaceParams 2021-09-22 13:21:02 -04:00
Jose Garcia
70a2ea2e6a PR Feedback 
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
 2021-09-22 13:19:26 -04:00
Jose Garcia
d2d21996bc Move ProvisionCodespace to API client 
- Make CreateCodespace private along with its errors
 2021-09-22 11:49:41 -04:00
Jose Garcia
8c5330d9e9 Rename error 2021-09-22 10:04:18 -04:00
Jose Garcia
2a0ea1617b Handle specific error for GetCodespaceToken 2021-09-22 09:40:45 -04:00
Jose Garcia
86717f14a1 Implement codespaces.Provision 
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
  is returned
 2021-09-22 09:09:09 -04:00
Jose Garcia
d5b03df406 Merge branch 'main' of github.com:github/ghcs into jg/poll-on-async-creation 2021-09-21 14:01:37 -04:00
Jose Garcia
8a53c4369e Merge pull request #179 from github/jg/close-session 
liveshare: close sessions
 2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220 PR Feedback 
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
 2021-09-21 10:05:48 -04:00
Alan Donovan
0f88081bfa Merge pull request #178 from github/check-authorized-keys 
ghcs ssh: check user has authorised SSH keys
 2021-09-21 10:03:45 -04:00
Jose Garcia
0b68aaab7e Return error on 202 responses 
- Start implementing the retry/poll flow
 2021-09-21 09:59:16 -04:00
Jose Garcia
a83b3c0816 Update to go-livesare v0.18.0 
- Only set err if closeErr is non-nil
 2021-09-21 08:46:32 -04:00
Jose Garcia
7f682f9c39 Close Live Share sessions 
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
 2021-09-20 16:56:57 -04:00
Alan Donovan
dbb80d8b1e check for authorised SSH keys 2021-09-20 16:01:43 -04:00
Jose Garcia
85f79ed8e8 Merge pull request #159 from github/jg/ssh-cmd-flags 
ghcs ssh: ssh flags and command support
 2021-09-20 07:43:16 -04:00
Jose Garcia
5890d6ad66 Switch if block logic, assert err string 2021-09-17 15:04:55 -04:00
Jose Garcia
da58313358 Remove redudant type def 2021-09-17 14:03:31 -04:00
Jose Garcia
9f84015bd0 Avoid append 2021-09-17 14:00:16 -04:00
Jose Garcia
65e1c6f789 More test cases 2021-09-17 13:56:38 -04:00
Jose Garcia
76037ee753 Update docs, simplify loop to append to command 2021-09-17 13:54:00 -04:00
Jose Garcia
54265afda0 PR Feedback 
- use named returns
- handle command flags + test case
- simplify tests
 2021-09-17 13:43:23 -04:00
Jose Garcia
60d066f0a6 PR Feedback 
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
 2021-09-17 11:51:37 -04:00
Jose Garcia
42e47a98d7 add docs, simplify map, error on invalid args 2021-09-16 15:22:47 -04:00
Jose Garcia
8a0f8b6d1c parse ssh args and command 2021-09-16 10:32:27 -04:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
Jose Garcia
514448dde8 Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags 2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f Merge pull request #154 from github/jg/fix-ctx-error 
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
 2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f Merge pull request #158 from github/jg/go-liveshare-0.16.0 
upgrade to go-liveshare 0.16.0
 2021-09-15 15:40:58 -04:00
Jose Garcia
c5bd8c4127 initial spike to accept args 2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082 add back codespaces.Shell 2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567 upgrade to go-liveshare 0.16.0 2021-09-15 15:15:28 -04:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220 fix ctx cancellation errors & fix todo for X11 forwarding 2021-09-15 10:38:19 -04:00
Mislav Marohnić
fb5a35568c Ensure original errors are wrapped with "%w" instead of "%v" 2021-09-15 13:58:41 +02:00
Alan Donovan
efb2569d2b move vendored go-ghcs-crypto to internal module 2021-09-10 12:29:25 -04:00
Alan Donovan
cbb8253544 consolidate survey functions 2021-09-09 11:57:37 -04:00
Alan Donovan
2c660fa2e5 avoid ListenTCP helper 2021-09-03 12:55:40 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Alan Donovan
8570f4111d sketch after API changes in go-liveshare#11 2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317 Merge pull request #107 from github/spelling-again 
use correct correct spelling of codespace
 2021-09-02 11:38:25 -04:00
Alan Donovan
72a2099a50 fix breakage from API changes 2021-09-01 17:50:24 -04:00