Mislav Marohnić
f749590e87
Replace old "github/ghcs" import statements
2021-09-28 16:57:56 +02:00
Mislav Marohnić
dc8f6ef183
No longer accept a logger in CreateCodespace
...
The API layer shouldn't concern itself with logging progress to stderr.
Instead, we will subsequently add progress indicators in the caller
around CreateCodespace and other potentially slow commands as needed.
2021-09-24 17:30:31 +02:00
Mislav Marohnić
ca0f89d3bc
Introduce an App struct that executes core business logic
...
The Cobra commands are now a light wrapper around the App struct.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-24 17:20:34 +02:00
Mislav Marohnić
7a91ba5942
Print usage help when args given to "NoArgs" commands
2021-09-22 19:51:12 +02:00
Mislav Marohnić
678da44c28
Simplify delete further
2021-09-21 21:09:26 +02:00
Mislav Marohnić
ab86739b6b
Merge remote-tracking branch 'origin' into mislav/delete-codespaces
2021-09-21 20:35:58 +02:00
Mislav Marohnić
683d847dd2
Merge remote-tracking branch 'origin' into cli-migration
2021-09-21 17:38:41 +02:00
Jose Garcia
8a53c4369e
Merge pull request #179 from github/jg/close-session
...
liveshare: close sessions
2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220
PR Feedback
...
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
2021-09-21 10:05:48 -04:00
Alan Donovan
d3d1ce726d
do logs too
2021-09-21 10:02:55 -04:00
Mislav Marohnić
b894d3e134
Simplify delete implementation
2021-09-20 18:37:00 +02:00
Mislav Marohnić
c2f3537a32
Separate "main" package from "ghcs" package
...
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:26:20 +02:00
Max Beizer
a4f1fa076b
Fix up all the static-check warnings ( #162 )
2021-09-17 13:10:37 +02:00
Mislav Marohnić
dbb4e0c177
Merge remote-tracking branch 'origin' into ruleguard
2021-09-16 11:46:50 +02:00
Alan Donovan
06719866c9
move api to internal/
2021-09-15 13:13:10 -04:00
Mislav Marohnić
fb5a35568c
Ensure original errors are wrapped with "%w" instead of "%v"
2021-09-15 13:58:41 +02:00
Alan Donovan
c4be0a0e28
this time without compile errors
2021-09-13 09:29:46 -04:00
Alan Donovan
1526ab5bff
fix URL
2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1
stdin/stdout fds are not 0/1 on windows
2021-09-10 17:36:20 -04:00
Alan Donovan
2fe71e3576
Merge pull request #138 from github/sigint-delay
...
Wait forever for SIGINT delivery
2021-09-10 14:15:36 -04:00
Jose Garcia
28ab023b07
Merge pull request #133 from github/jg/ports-flags
...
ghcs ports: deprecate codespace arg, introduce global flag
2021-09-10 13:33:26 -04:00
Alan Donovan
4f6cab195a
wait for sigint delivery
2021-09-10 10:08:54 -04:00
Jose Garcia
fe2d5ebf37
merge upstream + pr feedback
2021-09-09 17:22:07 -04:00
Alan Donovan
22f9824ec8
deliver SIGINT to self after Ctrl-C in survey
2021-09-09 16:33:39 -04:00
Alan Donovan
cbb8253544
consolidate survey functions
2021-09-09 11:57:37 -04:00
