Commit graph

9554 commits

Author SHA1 Message Date
Mislav Marohnić
ba9370ab1f Enable simplifycompositelit check in CI
This will fail the build when there are redundant types in composite
struct literals.
2020-06-12 15:59:25 +02:00
ShubhankarKG
15ec2b748e Refactor code 2020-06-12 12:00:01 +05:30
gedenata
7aa1caf4ed Merge branch 'trunk' into develop 2020-06-12 11:58:20 +08:00
naman
fffa393683 fix lint 2020-06-11 17:08:18 -07:00
naman
fb7b01b40c resolve PR review 2020-06-11 17:05:25 -07:00
gedenata
8ffd0d59f6 redundant type composite literal 2020-06-12 04:23:51 +08:00
Nate Smith
db74ea051e
Merge pull request #1165 from cli/api-repo-placeholders
api command: support `{owner}` and `{repo}` placeholders
2020-06-11 15:18:43 -05:00
Mislav Marohnić
3f6d0bff45 Switch to :owner/:repo syntax for placeholders 2020-06-11 21:46:27 +02:00
Nate Smith
420d527926
Merge pull request #1167 from cli/doc-examples-tweaks
Fix doc EXAMPLES formatting for HTML
2020-06-11 14:14:28 -05:00
Nate Smith
1ef6d4bc66
Merge pull request #1158 from vilmibm/default-cfg
initialize a non-empty config
2020-06-11 14:13:54 -05:00
vilmibm
64a7fd4200 test default configuration 2020-06-11 14:04:41 -05:00
vilmibm
47102fe427 just fill in the blank config with default content 2020-06-11 14:04:29 -05:00
Mislav Marohnić
d5c4e23ca5 Tweak last few Example sections 2020-06-11 20:36:08 +02:00
Mislav Marohnić
73ab5810ea Merge remote-tracking branch 'origin' into doc-examples-tweaks 2020-06-11 20:32:47 +02:00
Mislav Marohnić
0dfc0f733f Fix indentation of Example blocks
In HTML, `Example` blocks seem to be already injected in fenced Markdown
blocks `` ``` ``, so they don't need to be especially intented.
2020-06-11 20:31:37 +02:00
Mislav Marohnić
99fce24fc8 Fix FLAGS section showing up empty for config get/set
This is because `config get/set` both do have a flag, but it's hidden.
2020-06-11 18:50:18 +02:00
Mislav Marohnić
e6a0c3dc28 Fix EXAMPLES sections of various commands
- Code should be intented per Markdown syntax for a code block. This
  matters when this documentation is rendered to HTML

- Fix some innaccurate usage examples

- Tweak wording, formatting in a few places
2020-06-11 18:47:57 +02:00
Corey Johnson
cde76930a1
Merge pull request #1157 from bvwells/limit
Validate pr and issue limit flag
2020-06-11 09:37:05 -07:00
Nate Smith
63d9611c0a
Merge pull request #1166 from cli/fix-gh-config-examples
Tweak gh config examples in help output
2020-06-11 10:25:01 -05:00
Nate Smith
e6721c595d
Merge pull request #1164 from AliabbasMerchant/fix-1159
Fix error when Milestone is empty during PR create
2020-06-11 10:20:04 -05:00
Mislav Marohnić
e7c934b05c Tweak gh help config output 2020-06-11 16:44:27 +02:00
Mislav Marohnić
8e90c27c46 Use Cobra's Example field for config get/set examples 2020-06-11 16:44:08 +02:00
Mislav Marohnić
8ffbc24c65 Merge remote-tracking branch 'origin' into fix-gh-config-examples 2020-06-11 16:30:00 +02:00
Mislav Marohnić
acf0046718 api command: support {owner} and {repo} placeholders
When `{owner}` and `{repo}` strings are found in request path (for REST
requests) or `query` (for GraphQL), they are replaced with values from
the repository of the current working directory.
2020-06-11 15:00:29 +02:00
AliabbasMerchant
26987c1434 Fix error when Milestone is empty during PR create 2020-06-11 17:27:18 +05:30
Mislav Marohnić
fb80cfbd6f
Merge pull request #1163 from micnncim/fix-pull-request-template
Remove duplicated words in PULL_REQUEST_TEMPLATE
2020-06-11 13:32:55 +02:00
micnncim
0c717ccfa8 Remove duplicated words in PULL_REQUEST_TEMPLATE 2020-06-11 19:58:07 +09:00
micnncim
c6c366e8f5 Fix gh config examples in documentations 2020-06-11 19:53:09 +09:00
Nate Smith
bf9aca834a
Merge pull request #1160 from gedenata/develop
redundant type slice-string
2020-06-11 00:39:19 -05:00
gedenata
cfaedd4c71 redundant type slice-string 2020-06-11 07:32:09 +08:00
vilmibm
cabf0b1972 populate initial config 2020-06-10 17:08:12 -05:00
Ben Wells
a89f45b1ed Validate pr and issue limit flag 2020-06-10 21:42:38 +01:00
Nate Smith
85b418352e
Merge pull request #1129 from cli/triage-docs
add docs about new triage rotation
2020-06-10 14:28:04 -05:00
Corey Johnson
fb7fdc3045
Merge pull request #1106 from cli/h-e-l-p
Style all commands like the root help command
2020-06-10 12:19:52 -07:00
Nate Smith
13b5c46081
Merge pull request #1150 from cli/api-content-length
api command: add explicit Content-Length for file uploads
2020-06-10 14:08:31 -05:00
naman
3bb6983b35 fix regression in support for detached HEAD state
for gh pr status
2020-06-10 11:41:44 -07:00
Nate Smith
adc7aa794c
Merge pull request #1143 from gedenata/develop
variable global color
2020-06-10 13:33:48 -05:00
Corey Johnson
2fb48e93ed Inline method call 2020-06-10 09:59:40 -07:00
Corey Johnson
7d7a010739 Clear out usage func 2020-06-10 09:43:24 -07:00
Corey Johnson
4931892cc3 Apply changes that were lost in merge conflict 2020-06-10 09:30:35 -07:00
Corey Johnson
d140ae6f5b Don't show hidden commands 2020-06-10 09:29:34 -07:00
Corey Johnson
56f1315d5f Merge remote-tracking branch 'origin/trunk' into h-e-l-p 2020-06-10 09:28:40 -07:00
Mislav Marohnić
74a39f3ed1 Turns out we do need explicit Content-Length for file uploads
This reverts commit 141388fd23.
2020-06-10 18:18:49 +02:00
Nate Smith
4d95349081
Merge pull request #1148 from cli/api-raw-body
Support passing raw POST body in `api` command
2020-06-10 11:11:30 -05:00
vilmibm
8263cd238b linter appeasement 2020-06-10 11:05:21 -05:00
Nate Smith
bd7e6bf00c
Merge branch 'trunk' into api-raw-body 2020-06-10 11:00:59 -05:00
Nate Smith
446486fec1
Merge pull request #1114 from cli/pretty-json
Pretty-print JSON in `api` command output
2020-06-10 10:53:10 -05:00
Nate Smith
12e8c4a184
Merge pull request #1122 from joehattori/feature/use-new-httpmock
use new httpmock API in repo_test.go
2020-06-10 10:37:44 -05:00
Nate Smith
096bf6bb79
Merge pull request #1115 from cli/api-errors
Print HTTP errors on stderr in `api` command
2020-06-10 10:35:04 -05:00
Mislav Marohnić
141388fd23 Turns out, Go will automatically set Content-Length 2020-06-10 16:29:50 +02:00