Jose Garcia
9e13f6ba6b
cleanup connect
2022-10-11 09:14:23 -04:00
Jose Garcia
e11b43f8f6
Fixes for handling the grpc client lifecyle
2022-10-11 08:55:14 -04:00
David Gardiner
f89b1b6a45
Create timeout context in caller
2022-10-10 14:39:12 -07:00
David Gardiner
0f41ccc472
Have cilents call port connection function
2022-10-10 11:56:44 -07:00
David Gardiner
a090b17e38
Ensure port is forwarded and server is shared
2022-10-07 15:37:04 -07:00
David Gardiner
341fc6c3f7
Mock session/channel for grpc tests
2022-10-03 20:29:31 -07:00
David Gardiner
f947020fa5
Add grpc mock server + tests
2022-09-30 11:55:57 -07:00
David Gardiner
d02ff315e4
Fix linting errors
2022-09-29 10:27:17 -07:00
David Gardiner
766e6a2314
Use existing context
2022-09-29 09:58:44 -07:00
David Gardiner
3f34d6d95e
Make suggested gRPC client changes
2022-09-28 10:39:26 -07:00
David Gardiner
93f033fe87
Address comments
2022-09-27 16:01:10 -07:00
Mislav Marohnić
acb61072cd
Respect GH_HOST in auth login, repo delete
...
Bonus fix: respect fallback host argument to `FromFullNameWithHost()`
2022-09-26 13:32:54 +02:00
Sam Coe
ebc681be05
Replace os.Setenv with t.Setenv ( #6345 )
2022-09-26 13:37:34 +04:00
Eng Zer Jun
471cbea4fa
test: use t.Setenv to set env vars in tests ( #6333 )
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-26 08:46:02 +00:00
Caleb Brose
83c67d3b57
Merge remote-tracking branch 'origin/trunk' into cmbrose/no-ssh-api-call
2022-09-20 15:22:27 +00:00
Mislav Marohnić
6e9974c2ef
Escape liquid tags in site docs
...
It is good practice to wrap all dynamic content in `{% raw %}..{% endraw %}`
Liquid tags so that no syntax within can mistakenly get interpreted as
Liquid tags. Fixes rendering of `gh auth login` help page.
2022-09-19 15:50:51 +02:00
Caleb Brose
0c00ca911e
Clean up API interface
2022-09-16 22:25:11 +00:00
Nate Smith
6ab61a085b
Merge pull request #6251 from cli/fix-prompter-default
...
Do not set default for survey prompt if empty string passed
2022-09-14 12:17:04 -05:00
Sam Coe
e14d14cef2
Add support for issue state reason ( #6245 )
2022-09-14 12:39:15 +04:00
Sam Coe
e7102f9d84
Migrate to go-gh text package ( #6236 )
2022-09-14 09:23:55 +04:00
vilmibm
c2f4bbac6b
Do not set default for survey prompt if empty string passed
2022-09-12 17:43:57 -07:00
Mislav Marohnić
436d9ef859
Fix "missing method Fd" crash on Windows ( #6200 )
...
This ensures that `IOStreams.Out` always keeps the original `Fd()` value even if it's wrapped as a Colorable stream for Windows in cases when enabling virtual terminal processing has failed.
2022-09-06 17:29:06 +02:00
Caleb Brose
6b24949649
Merge pull request #5958 from cli/cmbrose/no-auto-key-if-uploaded
...
Check for already configured ssh keys before using automatic key
2022-08-23 12:09:16 -05:00
Nate Smith
1f488f4d54
Merge pull request #6101 from cli/graphql-cleanup
...
Consolidate GraphQL clients and make GraphQL headers uniform
2022-08-22 17:31:50 -05:00
Abirdcfly
b998f3912d
remove duplicate "the" words in comments
2022-08-21 11:11:39 +08:00
Sam Coe
45f1a71c8b
Remove all direct calls to shurcool-graphql
2022-08-18 21:40:41 +03:00
Sam Coe
6a8deb1f5a
Integrate latest go-gh packages ( #6084 )
2022-08-18 09:04:13 +03:00
vilmibm
2d093c1741
add test helpers
2022-08-15 13:53:43 -05:00
vilmibm
8bba7f9624
rename NewPrompter to New
2022-08-15 13:28:15 -05:00
vilmibm
791b8b4173
Merge remote-tracking branch 'origin/trunk' into prompt-factory
2022-08-15 13:21:22 -05:00
Mislav Marohnić
d21d388b8d
Restore old GH_DEBUG=1 behavior for HTTP logging ( #6054 )
...
- No HTTP bodies or headers are logged until `GH_DEBUG=api` is used.
- Logging to terminal now supports colorization.
2022-08-10 17:59:13 +02:00
Caleb Brose
cb914c1873
Cleanup extra param, array declaration
2022-08-09 10:16:24 -05:00
Caleb Brose
5212fc8d5b
Error handling
2022-08-03 15:26:00 +00:00
vilmibm
f7d5c5f725
move prompter to own package
2022-07-26 16:41:13 -05:00
vilmibm
4afb567d06
WIP: survey wrapper
2022-07-26 14:39:38 -05:00
Caleb Brose
c9290cbc2c
Merge remote-tracking branch 'origin/trunk' into cmbrose/no-auto-key-if-uploaded
2022-07-22 11:08:21 -05:00
JP Ungaretti
ec9e50ff93
Always set PasswordAuthentication option
2022-07-19 16:55:14 -07:00
Caleb Brose
f313953642
Initial pass
2022-07-16 20:38:23 +00:00
Sam Coe
e5cf302ad8
Post go-gh integration cleanup ( #5933 )
2022-07-13 14:58:50 +02:00
Sam Coe
1e8cb9c1b2
Fix login flow ( #5928 )
2022-07-12 15:46:35 +02:00
Mark Phelps
6014b31d03
Fix case where codespace created while in provisioning state causes panic
2022-07-01 13:08:44 -04:00
Mark Phelps
38ea62afba
Codespaces list by repo ( #5854 )
...
* WIP
* Allow to list codespaces by repo
* Tests
* Cleanup
* respond to PR feedback
* Address review comments
2022-06-28 13:34:04 +00:00
Sam Coe
cacff4ad6d
Use go-gh config package ( #5771 )
2022-06-23 11:50:04 +00:00
Sam Coe
074ed50b8a
Integrate go-gh API package ( #5614 )
2022-06-23 04:05:31 +01:00
Mislav Marohnić
6e3689d58b
Apply UI polish around codespaces org-admin commands ( #5843 )
2022-06-22 20:35:56 +02:00
Ashwin Jeyaseelan
47f5abdb6f
8gitbrix/add delete org codespace ( #5827 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-22 18:28:09 +02:00
Greggory Rothmeier
2294f49d07
Add support for org admins to stop a members codespace ( #5812 )
2022-06-22 13:56:22 +02:00
Greggory Rothmeier
4b36dc031f
Add flag to list codespaces under an organization ( #5807 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-21 13:57:40 +00:00
Jake Shorty
832f35e000
PreFlight => BillableOwner for less confusion
2022-06-20 17:12:07 +00:00
Jake Shorty
ddbf8590e8
Fix error message and JSON keys
2022-06-19 18:28:33 +00:00
