Commit graph

225 commits

Author SHA1 Message Date
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view
Add Reviewers to pr view in CLI
2020-05-08 14:46:08 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash
Fix `pr status -R` crash with closed PR on the default branch
2020-05-08 14:23:51 -05:00
Mislav Marohnić
93c61a83b2 Fix pr status -R crash with closed PR on the default branch
At the time we have a reference to `baseRepo`, we might still not have
contacted the API nor obtained any information about the default branch
for the repository. This expands the `PullRequests()` query to always
report the default branch so we may choose how to render entries that
belong on the current branch.
2020-05-07 20:53:03 +02:00
Mislav Marohnić
1834d8cfd5 Tweak syntax in issue/pr close docs
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Daniel Foad
e7e3a4f9b1
pr comments 2020-05-04 23:47:47 +01:00
Corey Johnson
fef11b3489 Merged prs return error 2020-05-04 10:44:20 -07:00
Corey Johnson
2f075fca73 Return an error if the pr was already merged 2020-05-04 10:25:38 -07:00
Corey Johnson
5cc60c669e Take in a pointer 2020-05-04 10:19:54 -07:00
Corey Johnson
1e88226b2b Add space 2020-05-04 10:16:30 -07:00
Corey Johnson
083693bc05 Update usage string 2020-05-04 10:15:47 -07:00
Corey Johnson
f7be93b135 use less words 2020-05-04 10:11:24 -07:00
Corey Johnson
1ee31db033 Add "merged" message 2020-05-04 10:10:03 -07:00
Corey Johnson
846425fe5e simplified boolean comparison 2020-05-01 14:16:49 -07:00
Corey Johnson
922352753a Add merged exit 2020-05-01 14:08:30 -07:00
Corey Johnson
bc623a7a23 Make it green 2020-05-01 12:07:23 -07:00
Corey Johnson
0bb1d2018a Add code to reopen 2020-05-01 12:00:13 -07:00
Corey Johnson
4bf778b136 require one arg 2020-04-30 11:41:39 -07:00
Corey Johnson
af6eaa8ca2 Hot dog 2020-04-30 11:41:32 -07:00
Corey Johnson
19f6c69854 Actually make it work 2020-04-30 11:27:11 -07:00
Corey Johnson
f9a55f4d8e Add close pull request code 2020-04-30 11:24:43 -07:00
Toshiya Doi
d2d0b47ecc Merge branch 'master' into reviewers-in-pr-view 2020-04-30 00:31:04 +09:00
Daniel Foad
09157f1fc7
unit tests 2020-04-28 00:03:21 +01:00
Daniel Foad
c62dd557e3
Filter closed/merged PRs on default branch 2020-04-27 21:14:00 +01:00
rista404
fab18ed4a9
Show awaiting triage when project col is empty 2020-04-25 22:57:03 +02:00
Toshiya Doi
67907c8b00 Support ghost reviews in pr view 2020-04-22 21:59:09 +09:00
Toshiya Doi
d70358ea34 Support GitHub Team in requested reviewers 2020-04-22 21:58:01 +09:00
Toshiya Doi
502f6709af Extract the reviewerstate formatter into a function 2020-04-11 15:03:43 +09:00
Toshiya Doi
fe27c842bb Fix slice initialization with provided capacity 2020-04-11 15:03:34 +09:00
Toshiya Doi
fbff7226ac Add comments on review state values 2020-04-10 04:51:42 +09:00
Toshiya Doi
2df5281f2f Merge branch 'master' into reviewers-in-pr-view 2020-04-10 04:46:05 +09:00
Mislav Marohnić
d14b5d3e2c
Merge pull request #764 from cli/pr-view-docs
Improve `issue/pr/repo view` documentation
2020-04-09 19:12:34 +02:00
Toshiya Doi
6223a2c198 Puts completed reviews before review requests and sort reviewer names alphabetically 2020-04-10 01:16:43 +09:00
Toshiya Doi
6d0e5bf2b8 Remove Participants related codes for pr view` 2020-04-10 01:02:51 +09:00
Mislav Marohnić
d1754b2bb0 Improve issue/pr/repo view documentation
- Short-form docs for `pr/repo view` no longer say "in browser"

- Long-form docs for all these commands now list more information about
  what will be displayed in the terminal, plus stressing out the
  alternate behavior with the `--web` flag.

- `--web` flag docs: add English articles
2020-04-08 12:04:39 +02:00
Toshiya Doi
5c261e2318 Give a color to reviewer states 2020-04-08 16:27:30 +09:00
Toshiya Doi
bc42228171 Parses Reviews and ReviewRequests to show reviewers and their state 2020-04-08 16:27:30 +09:00
Toshiya Doi
542314a9c3 Omit participants metadata from pr view 2020-04-08 14:53:23 +09:00
Toshiya Doi
d5bff70259 Clean up unnecessary fmt.Sprintf 2020-04-04 15:09:22 +09:00
Toshiya Doi
0cb6890c74 Print pr metadata in CLI preview 2020-04-04 13:09:34 +09:00
Toshiya Doi
4c2f15fe37 Roll back the place of colorFuncForState 2020-04-02 23:58:28 +09:00
Toshiya Doi
0095fe9a13 Merge branch 'master' into view-the-current-state 2020-04-02 23:52:41 +09:00
vilmibm
44acdd4ec3 Merge branch 'master' into pr-status-no-commits 2020-03-30 12:04:02 -05:00
Mislav Marohnić
beb0a6a322
Merge pull request #683 from cli/pr-status-unicode
Add unicode to pr status
2020-03-26 13:30:26 +01:00
vilmibm
f4b8851011 Merge remote-tracking branch 'origin/master' into pr-status-no-commits 2020-03-25 12:00:58 -05:00
Nate Smith
e4b8ae0ec4
Merge pull request #665 from cli/preview-default
switch {pr,issue} view default
2020-03-25 11:32:46 -05:00
Toshiya Doi
7d42f46cda Merge branch 'master' into view-the-current-state 2020-03-25 22:46:12 +09:00
Mislav Marohnić
88cbcc9ec5 Merge remote-tracking branch 'origin/master' into pr-status-unicode 2020-03-25 09:06:27 +01:00
Mislav Marohnić
11327030e7 Tweak whitespace printing in pr status 2020-03-25 09:05:51 +01:00
Amanda Pinsker
7c73cf88ae
Remove formatting from Fprint
Co-Authored-By: Mislav Marohnić <mislav@github.com>
2020-03-24 15:01:21 -07:00