Commit graph

761 commits

Author SHA1 Message Date
Kynan Ware
d230b08c43 test(prompter): re-add skipped test for accessible confirm default 2025-04-08 13:09:15 -06:00
Kynan Ware
19387b8418 fix(prompter): rename GH_ACCESSIBLE_PROMPTER 2025-04-08 12:52:39 -06:00
Kynan Ware
9cf341302e refactor(prompter): explicit return values 2025-04-08 12:03:55 -06:00
Kynan Ware
8821f77fbb doc(prompter): remove senseless comment 2025-04-08 12:00:02 -06:00
Kynan Ware
c4be95afd9 refactor(prompter): remove unused variable 2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9 test(prompter): timeout for tests is 1s 2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778 fix(prompter): use os.lookupenv for accessible prompter 2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86 test(prompter): remove needless NO_COLOR set 2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests 2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-07 14:53:31 -06:00
Kynan Ware
0543aac53c test(prompter): add basic survey prompter test 2025-04-07 12:54:03 -06:00
Kynan Ware
2a851e33e8 test(prompter): fix race conditions 2025-04-07 11:59:05 -06:00
Kynan Ware
f89700160b doc(prompter): clarify comments 2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467 refactor(prompter): less magic strings 2025-04-04 15:07:21 -06:00
Kynan Ware
2e48cadf58 fix(prompter): remove impossible condition 2025-04-04 15:05:23 -06:00
Kynan Ware
5c39e0bd10 fix(prompter): notes about Confirm default 2025-04-04 14:52:25 -06:00
Kynan Ware
4cf048a8d1 fix(prompter): input returns default when blank 2025-04-04 11:33:10 -06:00
Kynan Ware
5b0d49c6ec test(prompter): more tests for bad input 2025-04-04 11:06:40 -06:00
Kynan Ware
a30df14b6a refactor(prompter): rename env var for speech synthesizer friendly prompter 2025-04-03 13:08:16 -06:00
Kynan Ware
49ddacf5b8 docs(prompter): doc prompter interface 2025-04-03 13:06:31 -06:00
Kynan Ware
02fc12e7b7 fix(linter): linter errors 2025-04-03 08:51:54 -06:00
Kynan Ware
88e6285b49 test(prompter): move to external package 2025-04-03 08:45:58 -06:00
Kynan Ware
8827803bd1 test(prompter): skip vt10x tests on Windows 2025-04-03 08:25:33 -06:00
Kynan Ware
e299b56c0f test(prompter): remove needless variable declaration 2025-04-02 13:08:36 -06:00
Kynan Ware
e42af35839 tests(prompter): rename huhprompter 2025-04-02 13:00:46 -06:00
Kynan Ware
0d7fd36f11 test(prompter): replace assert with require 2025-04-02 12:58:44 -06:00
Kynan Ware
94bbd26aab fix(prompter): rename huhprompter 2025-04-02 12:56:44 -06:00
Kynan Ware
f7de9e0c11 test(prompter): go-expect based prompter tests 2025-04-02 12:56:44 -06:00
Kynan Ware
88a98ea63a
feat(prompter): include no as false-y value
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-02 11:58:10 -06:00
Kynan Ware
92b1a8e0f0 test(prompter): remove t.parallel calls
t.Parallel() cannot be used when env vars are being set.
2025-03-31 16:01:16 -06:00
Kynan Ware
e973ee332d fix(md prompter): accessible prompt allows blank
Allow the accessible markdownEditor prompt to be blank when the blank
comes from the result of an interactive session with an editor, even when
blankAllowed is false.

This behavior aligns the accessible prompter with the behavior of the
current standard prompter.
2025-03-31 15:58:20 -06:00
Kynan Ware
7b0c09541d feat(md prompter): md prompt respects blankAllowed
Accessible prompter now respects blankAllowed and
will not prompt for "skip" if blankAllowed is false.
2025-03-31 15:52:26 -06:00
Kynan Ware
202c1ad16b feat(prompter): add accessible prompter support 2025-03-31 15:04:57 -06:00
Andy Feller
6355e54e3c Ensure table headers are thematically contrasting
This commit refactors the color format around table headers to ensure the GitHub CLI uses thematically appropriate colors based on dark background, light background, or no color at all.

In order to do so, `ColorScheme` needs information from the terminal about the background appearance (dark, light, none) to determine appropriate muted color.
2025-03-21 11:51:03 -04:00
Azeem Sajid
a4b86bff77 Use HTML numeric code instead of escaping with slash 2025-02-04 18:48:56 +05:00
Azeem Sajid
800a645e0e [gh config] Escape pipe symbol in Long desc for website manual 2025-02-04 18:16:13 +05:00
William Martin
53f80b2ebf
Merge pull request #10265 from robmorgan/patch-1
Tiny typo fix
2025-01-21 13:48:50 +01:00
Caleb Brose
0c8591064d Change back to exponential backoff 2025-01-17 14:09:33 -06:00
Caleb Brose
9b8cd7babd Linter 2025-01-17 14:09:33 -06:00
Caleb Brose
31bff5b5a8 Better handling for codespace state polling 2025-01-17 14:09:33 -06:00
Rob Morgan
dcf5cc8724
fix: tiny typo fix 2025-01-17 18:08:59 +08:00
Andy Feller
20062233c8 Separate logic for checking updates
During discussion in cli/cli#9934, we can to the conclusion that the logic around checking for core GitHub CLI updates would diverge from GitHub CLI
extension updates over time.  To that end, this commit splits that logic into a separate function with a new environment variable.
2025-01-10 14:16:46 -05:00
Andy Feller
1c32c986ec Capture greater detail on updaterEnabled
This commit expands the in-line docs around updaterEnabled package variable used to affect release checking.

Along with clarifying specific details discovered when talking with @williammartin, I'm also removing a useless local variable.
2025-01-10 13:55:16 -05:00
Andy Feller
6bbd70353b Comment exported functions 2025-01-09 09:09:42 -05:00
Andy Feller
bfc63a14cc Implement remaining PR feedback
After merging in upstream changes regarding local extensions, this commit addresses remaining PR feedback while also bringing the newly merged tests into alignment with other changes.
2024-12-13 23:09:18 -05:00
Andy Feller
5ad6ccf73a Merge branch 'trunk' into andyfeller/cli-cli-8183-timeout-pt2 2024-12-13 22:53:13 -05:00
Andy Feller
c12e3694e8 Implement partial feedback before trunk update 2024-12-13 22:52:03 -05:00
Andy Feller
10f62b1c37 Expand update tests for local extensions 2024-12-08 21:06:01 -05:00
Andy Feller
a79e086bd4 Test whether extension update should be checked 2024-12-08 20:43:51 -05:00
Andrew Feller
a55f50b115 Remove Extension.FullName() from interface
- this was something I did in the original implementation of this improved extension update notification logic
- discovering other parts of the extension manager code that were working with non-prefixed extension names motivated a different approach
- the extension manager code that requires the extension be prefixed has been enhanced to use the centralized ensurePrefixed() logic, making the need for this on the extension unnecessary
2024-12-08 20:01:26 -05:00