STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9239 commits 87 branches 0 tags 160 MiB
Commit graph

4611 commits

Author SHA1 Message Date
Tyler McGoffin
a390ce4f10 Refactor autolink list and test to use http interface for simpler testing 
This defines an AutolinkClient interface with a Get method used for
fetching the autolinks lists from the api. Then, the http client for
autolinks implements this interface with the AutolinkGetter struct.

This allows for dependency injection of the AutolinkGetter struct into the
listOptions, enabling mocking of the AutolinkGetter for testing. The
result of this is simpler tests that are easier to maintain, because the
interface for the table tests now allow for defining autolink structs as
the response instead of large mocked api calls.

This also allows for bespoke testing of the http file, which I'll follow
up with in the next commit.
 2024-12-27 21:36:16 -05:00
Tyler McGoffin
5fb98524e0 Apply PR comment changes 2024-12-27 21:36:16 -05:00
Michael Hoffman
23c16c9c4c Introduce repo autolinks list commands 2024-12-27 21:36:16 -05:00
ChandranshuRao14
29371e9491 Extract logic into helper function 2024-12-26 22:52:32 -05:00
Arseni Dziamidchyk
f9767d0a9a add pending status for workflow runs 2024-12-26 19:10:06 +03:00
ChandranshuRao14
a542011cdc Feat: Allow setting security_and_analysis settings in gh repo edit 2024-12-24 12:59:42 -06:00
Tyler McGoffin
7357bad2d3
Merge pull request #10112 from heaths/gh-merge-base-docs 
Document how to set gh-merge-base
 2024-12-23 11:51:10 -08:00
William Martin
b9c597458b Document SmartBaseRepoFunc 2024-12-23 19:07:17 +01:00
William Martin
7a954cde82 Document BaseRepoFunc 2024-12-23 19:07:17 +01:00
Heath Stewart
78836097c3
Document how to set gh-merge-base 
Follow-up to PR #9712
 2024-12-20 10:49:38 -08:00
Meredith Lancaster
73cd38ac07 update verify output table 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-19 12:47:55 -07:00
Meredith Lancaster
ce6150d136 simplify func params 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-19 07:18:01 -07:00
Meredith Lancaster
3542b3566a add test for different SAN and SourceRepositoryURI values 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-18 07:24:44 -07:00
Meredith Lancaster
4431fa9d8f add test for signerRepo and tenant 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-18 06:55:00 -07:00
Meredith Lancaster
86b815e9bf add some more fields to test that san, sanregex are set properly 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-18 06:49:08 -07:00
Meredith Lancaster
83770d8e55 update san and sanregex configuration for readability 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 18:42:29 -07:00
Meredith Lancaster
9acd0c7e06 Merge branch 'consolidate-verify-policy-options-config' of github.com:malancas/cli into consolidate-verify-policy-options-config 2024-12-16 17:06:41 -07:00
Meredith Lancaster
1df2976e81 reduce duplication when creating policy content 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 17:06:36 -07:00
Meredith Lancaster
ab4912ff48 fix failing tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 12:40:13 -07:00
Meredith Lancaster
e4431a3f55 add mock http client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 12:22:20 -07:00
Meredith Lancaster
fb020f2a79 update error messages 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 12:13:22 -07:00
Meredith Lancaster
8f5d7100f5 var naming 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 12:02:52 -07:00
Meredith Lancaster
6b95175363 add httpClient field to LiveClient struct 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 11:57:45 -07:00
Meredith Lancaster
e51b4efaa9 remove unused method 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 11:50:46 -07:00
Meredith Lancaster
5a6a7968a3 fetch bundles with sas url 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-16 11:25:43 -07:00
Meredith Lancaster
08f6e2f943
Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-16 08:08:09 -07:00
Meredith Lancaster
64bf37e31c
Merge pull request #10051 from malancas/gh-attestation-download-windows-bug 
Use Windows compatible file name for downloaded attestations when running `gh attestation download`
 2024-12-16 08:01:36 -07:00
nilvng
3987f4af4a chore: remove unused file 2024-12-15 18:08:45 +11:00
nilvng
55598d0a2c feat: integrate new PRLister into pr list command 2024-12-15 18:04:51 +11:00
nilvng
91b3b99b76 issue #2329: create shared PRLister 2024-12-15 17:53:00 +11:00
nilvng
d7cabf18f7 fix: tab format may break checkout prompts 2024-12-15 13:55:47 +11:00
nilvng
1f525bf175 issue #2329: handle empty list of PR 2024-12-15 12:34:46 +11:00
Andy Feller
edc0351c85 Fix failig local extension tests 
Extensions have to be gh- prefixed and these newer tests were failing because of expectation.
 2024-12-13 23:20:42 -05:00
Andy Feller
bfc63a14cc Implement remaining PR feedback 
After merging in upstream changes regarding local extensions, this commit addresses remaining PR feedback while also bringing the newly merged tests into alignment with other changes.
 2024-12-13 23:09:18 -05:00
Andy Feller
5ad6ccf73a Merge branch 'trunk' into andyfeller/cli-cli-8183-timeout-pt2 2024-12-13 22:53:13 -05:00
Andy Feller
c12e3694e8 Implement partial feedback before trunk update 2024-12-13 22:52:03 -05:00
Nilln
de13d7b721
Merge branch 'trunk' into nil/fix-2329 2024-12-14 11:03:22 +11:00
Meredith Lancaster
7160f7ef50 Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2024-12-13 15:25:00 -07:00
Meredith Lancaster
90f5dae82b Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-13 15:23:01 -07:00
Meredith Lancaster
9b905d9f18
Merge pull request #9891 from malancas/print-policy-info 2024-12-13 15:14:05 -07:00
Phill MV
dd95e5a863 tweak output of build policy info 2024-12-13 15:55:49 -05:00
Kynan Ware
b3f74900f2
Merge pull request #10078 from cli/10077-gh-pr-view-cannot-find-pr-from-branch-when-fork-is-in-the-same-org-as-upstream 
Support `pr view` for intra-org forks
 2024-12-13 11:44:43 -07:00
Phill MV
c789b56da4
Merge pull request #9954 from cli/phillmv/improve-gh-at-inspect 2024-12-13 09:50:52 -05:00
William Martin
d662226ae4 Name conditionals in PR finder 2024-12-13 14:33:33 +01:00
William Martin
96ac8d6a2f Support pr view for intra-org forks 2024-12-13 14:27:41 +01:00
Kynan Ware
c35d725b0b
Merge pull request #10074 from cli/kw/cli-7011-fix-delete-branch-with-merge-queue-v2 
`gh pr merge --delete-branch` exits with error when merge requested via merge queue
 2024-12-12 16:05:06 -07:00
Kynan Ware
253b082600 Return err instead of silentError in merge queue check 2024-12-12 15:54:01 -07:00
Meredith Lancaster
76ffe4fb28
Merge pull request #9999 from malancas/sigstore-verifier-cleanup 
Sigstore verifier logic updates
 2024-12-12 15:10:52 -07:00
Phill MV
cae97c9da8 linting pointed out this var is no longer used 2024-12-12 17:00:02 -05:00
Phill MV
75cbdc0d04 Removed fun, but inaccessible ASCII header 2024-12-12 16:58:26 -05:00