Commit graph

383 commits

Author SHA1 Message Date
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
Mark Woods
e876b22963
Change markdown wrap limit match terminal width (#6016) 2022-09-01 07:36:25 +00:00
Sam Coe
45f1a71c8b
Remove all direct calls to shurcool-graphql 2022-08-18 21:40:41 +03:00
Sam Coe
6a8deb1f5a
Integrate latest go-gh packages (#6084) 2022-08-18 09:04:13 +03:00
vilmibm
41385477c3 fix linting 2022-07-27 14:15:27 -05:00
vilmibm
d5334f4115 Revert "update linter checks"
This reverts commit 40ecb8c188.
2022-07-27 13:30:41 -05:00
vilmibm
f7d5c5f725 move prompter to own package 2022-07-26 16:41:13 -05:00
vilmibm
40ecb8c188 update linter checks 2022-07-26 16:06:52 -05:00
vilmibm
4afb567d06 WIP: survey wrapper 2022-07-26 14:39:38 -05:00
Patrick Reader
0cf2600725
strip whitespace when adding topics
closes #5934
2022-07-14 13:17:40 +01:00
Mislav Marohnić
5656296ade repo fork: directly fork under the desired name
A new GitHub feature landed where the API client can specify the desired
name of the new fork. This avoids the necessity of subsequently having
to rename the forked repo after the fork operation has created one.

For backwards compatibility, the renaming logic is still here, but
activates only if the resulting repo name is not the desired name.
2022-07-11 13:54:58 +02:00
casswedson
00bc550dc6 chore: typo hunting ft. codespell 2022-07-09 21:41:09 -05:00
Sam Coe
cacff4ad6d
Use go-gh config package (#5771) 2022-06-23 11:50:04 +00:00
Sam Coe
074ed50b8a
Integrate go-gh API package (#5614) 2022-06-23 04:05:31 +01:00
Jonathan Fenwick
ddb408e67b
Add check to see if current owner is attempting to fork the repo (#5794)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-14 13:13:24 +00:00
Mislav Marohnić
80f130184c repo edit: fix interactive mode in GHES < 3.3 2022-06-07 17:54:52 +02:00
Mislav Marohnić
aff26cbcfc Simplify repo list color check 2022-06-07 17:51:44 +02:00
Mislav Marohnić
89886eeaf8 Fix repo visibility label in search repos output
The `Visibility` field will be empty for `search` results when made
against GHES versions < 3.3. If that is the case, fall back to
constructing the label using `IsPrivate` field.
2022-06-07 17:09:17 +02:00
Sam Coe
33975a95e4
Allow repo list to work with GHES earlier than 3.3 2022-06-06 12:45:55 -05:00
Federico Guerinoni
b780608e90 Quote path of repo in order to have a valid copy paste command
Closes #5602
2022-05-26 12:12:56 +02:00
Ahmed Adan
31bee2e639
Add --upstream-remote-name flag to gh replo clone (#5619) 2022-05-24 13:12:01 +02:00
Mislav Marohnić
eb4439d781
Merge pull request #5698 from cli/deprecation-stderr
Write Cobra deprecation messages to stderr
2022-05-24 12:36:18 +02:00
Mislav Marohnić
2139e763fb Write Cobra deprecation messages to stderr
We used to do the equivalent of `rootCmd.SetOut(os.Stdout)` because we
thought that Cobra's "Out" stream represents standard output. However,
upon closer inspection it turns out that this is Cobra's stream for
usage errors and deprecation warnings, and those we want written to
stderr as well. It is not clear to me why Cobra maintains a distinction
between "Out" and "Err" streams since both seem to go to sdterr by
default.

This change also ceases our usage of `command.Print()` functions in
favor of explicitly writing to `IOStreams.Out/ErrOut`.
2022-05-23 20:23:42 +02:00
Sam Coe
ebbf2ac096
Fix owner qualifier for search queries (#5693) 2022-05-23 13:00:32 +00:00
ffalor
2918c538b3
add include-all-branches flag to repo create (#5537) 2022-05-23 10:11:55 +02:00
Dan Halbert
51d18d95f1
repo clone: document the upstream remote (#5466)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 18:12:59 +02:00
Hirad Pourtahmasbi
bbaf010303
repo list: add --visibility internal filter (#5564)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 15:39:53 +00:00
chemotaxis
a291b3eed3
Fix grammar in repo create prompt (#5557)
* Use plural linking verb

While it looks like you could use "there's" informally, grammatically, it should be "are" since "commits" is plural.

<https://dictionary.cambridge.org/us/grammar/british-grammar/there-is-there-s-and-there-are>

* Omit "the"

I created a remote called "github" and got this prompt:

> Would you like to push commits from the current branch to the "github"?

Normally, the default name "origin" doesn't sound bad in that prompt,
but using the name "github" made the prompt sound like something wasn't
right to my American English-speaking ears.

Here are a few options.  Yes, I know English grammar sucks, to put it
mildly.  But, hopefully, the following options and explanations make
sense.

Get rid of "the".  This is the option I went with.  "github" acts as a
proper noun, so no determiner is needed.  If you substitute your own
name for "github" in the original prompt above, you get the same effect:

> Would you like to push commits from the current branch to "github"?

Add the implicit word "remote".  "github" now acts as an adjective and
"the" refers to "remote":

> Would you like to push commits from the current branch to the "github" remote?

Or, combine the two.  This last option relies on the fact that
instructions and manuals often omit definite articles because most
articles are definite.  See the [zero-marking][2] article on Wikipedia.
The original prompt already does this by omitting "the" before the word
"commits":

> Would you like to push commits from the current branch to "github" remote?

Reference:

[1]: http://writing.umn.edu/sws/quickhelp/grammar/articlesproper.html

[2]: https://en.wikipedia.org/wiki/Zero-marking_in_English
2022-05-02 10:21:59 +02:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Roshan Padaki
13342cb272
Don't error on list commands when no results found (#5479)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-25 17:55:52 +00:00
Roshan Padaki
25a55948cf
add ls alias to gh repo list (#5480) 2022-04-19 16:14:22 +02:00
Christopher Nethercott
933a91e18e
Add "new" alias to "create" commands (#5388)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-11 16:48:34 +02:00
Sam Coe
31da9b1360
Replace old search utility with new search (#5366) 2022-04-06 16:44:52 +02:00
Gowtham Munukutla
83a6cccf2a
Add interactive repository edit functionality (#4895) 2022-03-14 17:49:03 +00:00
Mislav Marohnić
9cbfe73140 Have core commands have consistent Short description 2022-02-18 18:39:30 +01:00
Mislav Marohnić
512208ca96 repo fork: tweak docs 2022-02-18 18:38:34 +01:00
Christian Gregg
c5dbf20ed4
Alias list as ls for all commands (#5214)
I always get tripped up whenever trying to list my codespaces, adding
`ls` as an alias to `list` feels natural enough.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-17 13:53:42 +01:00
Breno Silva
6e14426dfb
docs: improve repo edit docs (#5165)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-15 17:35:30 +01:00
Mislav Marohnić
0a5e220231 Ignore EPIPE errors when writing to a closed pager
While a gh command is writing stdout to a pager, the user may choose to
close the pager program before the pager has read all the data on its
standard input. In that case, the parent gh process will receive an
EPIPE error, which would bubble up its error handling and cause it to
print something like:

    write |1: broken pipe

Since this was caused by an explicit user action of closing the pager,
and since the user probably doesn't want to see this uninformative
error, this informs our global error handling of this error and causes
it to be ignored.
2022-02-10 16:42:00 +01:00
Mislav Marohnić
6a4f374caf
Enable repo override for repo deploy-key delete (#5152) 2022-02-01 11:40:34 +00:00
Mislav Marohnić
4a3ef50d2d
Standardize pager output across commands (#5141)
Add pager functionality to the following commands:
- gist list
- pr checks
- release list
- run list
- run view
- secret list
- workflow list
- workflow view

Additionally, normalize error handling when starting the pager has
failed: only print a non-fatal notice to stderr instead of aborting the
whole command.
2022-02-01 08:36:51 +01:00
Kevin Lee
0d143ca89c
Consistent punctuation in command usages (#5139)
* Fix spelling and grammatical errors in command docs
* Add periods for consistency across the long command descriptions
* Format imports
2022-01-31 10:56:12 +00:00
Nate Smith
e17964cf03
Merge pull request #5092 from cli/repo-fork-proto
prefer configured git protocol when forking
2022-01-26 11:33:47 -06:00
nate smith
667671f048 fix race condition, increase clarity 2022-01-25 15:36:41 -06:00
nate smith
bd6e50a08a Merge remote-tracking branch 'origin/trunk' into feature/target-repo-fork-name 2022-01-25 14:08:27 -06:00
Nilesh Singh
47a6aff54a
Add repo deploy key commands (#4302)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-01-25 17:48:24 +00:00
nate smith
0d214864d9 linter appeasement 2022-01-24 17:01:19 -06:00
nate smith
170a50fcc8 prefer configured git protocol when forking 2022-01-24 16:54:01 -06:00
Nate Smith
4b415f80d7
Merge pull request #5022 from cli/config-defaults
add GetOrDefault and related methods to Config
2022-01-17 10:44:28 -06:00
Mislav Marohnić
44775f87c8 Add nolint directives to allow-list current lint violations 2022-01-14 19:52:52 +01:00