Commit graph

307 commits

Author SHA1 Message Date
Nate Smith
c03b0d110d
Merge pull request #291 from HowJMay/fix_typos
fix: Fix typos
2020-02-03 11:17:37 -06:00
TaKO8Ki
6f2d7c5dd1 fx typo 2020-02-02 17:23:51 +09:00
HowJMay
c517fd79b9 fix: Fix typos
Fix typos in files
2020-02-02 01:49:11 +08:00
vilmibm
d7bf83a82c strip color, add whitespace 2020-01-30 14:00:43 -06:00
vilmibm
34248f9892 fix tests 2020-01-29 17:51:18 -06:00
vilmibm
d81cf009f5 simpler repo context 2020-01-29 17:47:29 -06:00
vilmibm
86cb09fe84 Revert "print repo info for status commands"
This reverts commit d64dcdca95.
2020-01-29 17:41:36 -06:00
vilmibm
d64dcdca95 print repo info for status commands 2020-01-29 15:50:04 -06:00
Nate Smith
6a6a6cc60f
Merge pull request #274 from cli/fix-change-link-fo-realz
Fix `gh version` printing the correct changelog link
2020-01-29 10:31:08 -06:00
Mislav Marohnić
2a49efc789 Fix gh version printing the correct changelog link
Previously, the version string didn't match the `vX.Y.Z` pattern because
the wrong variable was passed to `changelogURL`.
2020-01-29 16:03:10 +01:00
Mislav Marohnić
5c4d118f2c Extract vendored fish completion for Cobra to a temporary package 2020-01-29 12:39:02 +01:00
Mislav Marohnić
09f3d176ff Fix test for unsupported shell type 2020-01-29 12:27:02 +01:00
Mislav Marohnić
2abee0905b Add fish completion support via Cobra contributor
Co-authored-by: Tim Reddehase <tim.reddehase@xing.com>
2020-01-28 22:04:40 +01:00
Mislav Marohnić
7b28605e6f Fix current changelog link in gh version
Also allow pre-release tags.
2020-01-28 18:31:12 +01:00
Mislav Marohnić
1c74227ed7 Use new repo name for update notifier and changelog 2020-01-28 18:22:29 +01:00
Nate Smith
25dc2b4a14
Merge pull request #258 from cli/blank-title
prevent graphql error
2020-01-28 10:21:11 -06:00
vilmibm
9025838448 update error text 2020-01-28 10:20:59 -06:00
vilmibm
bfd1d804a8 prevent graphql error 2020-01-27 16:00:11 -06:00
Amanda Pinsker
250286d531
Add updated feedback form link 2020-01-27 12:55:57 -08:00
Mislav Marohnić
a710893fc1 Rename to cli/cli 2020-01-24 16:08:52 +01:00
Mislav Marohnić
b44dad2319 Merge remote-tracking branch 'origin/master' into no-errors-wrap 2020-01-23 16:46:56 +01:00
Nate Smith
a0f2e1736a Merge pull request #244 from github/ghrepo-interface
Extract common interface for a GitHub Repository
2020-01-23 09:39:16 -06:00
Nate Smith
bf0f345ea3 Merge pull request #243 from github/display-url
Extract helper for URL display
2020-01-23 09:36:40 -06:00
Mislav Marohnić
c5960f0906 Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 16:36:22 +01:00
Nate Smith
55a5d19252 Merge pull request #247 from github/issue-pr-view-docs
Tweak `issue/pr view` documentation
2020-01-23 09:35:38 -06:00
Nate Smith
3764e25921 Merge pull request #248 from github/main-pkg
Move main package to under `cmd/`
2020-01-23 09:34:54 -06:00
Nate Smith
91ab3086a8 Merge pull request #249 from github/issue-pr-argument-docs
Avoid saying "number as argument" for `issue/pr view`
2020-01-23 09:31:18 -06:00
Mislav Marohnić
30b4eab8e0 Use ghrepo.FullName in tests 2020-01-23 14:24:22 +01:00
Mislav Marohnić
22fe0839fa Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 14:19:10 +01:00
Mislav Marohnić
4f6dfee965 Merge remote-tracking branch 'origin/master' into pr-create-just-works-TM 2020-01-23 14:08:07 +01:00
Mislav Marohnić
f10b8d8095 Add unit tests for remotes-to-repos resolver 2020-01-23 14:05:15 +01:00
Mislav Marohnić
9122bc181c Migrate away from errors.Wrap()
Turns out the "standard" way of wrapping errors in Go is via
`fmt.Errorf("%w")`, which doesn't require an external package and also allows a
finer control of error sentence formatting.
2020-01-23 13:19:28 +01:00
Mislav Marohnić
f58dd04074 Avoid saying "number as argument" for issue/pr view
Since issue URLs, PR URLs, and PR branch names are all accepted as arguments,
avoid explicitly requesting "number" as argument.
2020-01-23 13:09:37 +01:00
Mislav Marohnić
537b0a8429 Friendlier output for network connectivity errors
For `net.DNSError`, the full error message can be scary. Instead, print "error
connecting to HOST" and hint that the user should check their internet connection
or githubstatus.com.

When $DEBUG is set, the full DNS error is printed like before.

Fixes #206
2020-01-23 12:48:10 +01:00
Mislav Marohnić
f5ad43458c Avoid using <...> in docs
When converted to HTML docs, these get interpreted as HTML tags.

In theory, we could encapsulate these bits in backticks, but the docs are
already in raw Go string literals, and we can't easily escape backticks in that
context. Instead, just avoid using `<>` for now.
2020-01-23 10:28:29 +01:00
Mislav Marohnić
305410cdee Fix usage synopsis for pr view
Indicate that the argument is optional
2020-01-23 10:28:26 +01:00
Mislav Marohnić
90f6a73ba5 Extract helper to print a URL 2020-01-22 23:03:23 +01:00
Mislav Marohnić
1f90579d2a Extract common interface for a GitHub Repository
Also define a handful of utility methods:
- `New(owner, repo)`
- `FullName`: the name slash owner pair
- `FromFullName`: parse the name slash owner pair
- `FromURL`: parse a GitHub.com URL
- `IsSame(r1, r2)`: compare two repositories
2020-01-22 22:44:46 +01:00
Nate Smith
340f747944 Merge pull request #242 from github/debug-api
Dump HTTP request/response bodies when `DEBUG=api`
2020-01-22 14:05:29 -06:00
vilmibm
8c84fe3e3c just augment existing queries 2020-01-22 12:37:00 -06:00
Mislav Marohnić
0b0fd42ef3 Dump HTTP request/response bodies when DEBUG=api 2020-01-22 19:35:39 +01:00
Mislav Marohnić
6799e7f570 Avoid resetting the current branch when --repo is used
This leads to unwanted consequences in `pr create`
2020-01-22 19:33:53 +01:00
Mislav Marohnić
a767fd7910 Add code comments for tricky parts 2020-01-22 18:37:50 +01:00
Mislav Marohnić
e2a825effb Auto-fork on pr create if no pushable target found 2020-01-22 18:32:06 +01:00
Mislav Marohnić
fa30c16ad5 Fix web-based pr create for forks 2020-01-21 23:20:32 +01:00
Mislav Marohnić
6c49614db7 Fix tests 2020-01-21 22:56:15 +01:00
vilmibm
f09b05e628 test for disabled issues 2020-01-21 15:47:36 -06:00
vilmibm
fc25a4e9ed check for disabled issues in issue view command 2020-01-21 15:37:42 -06:00
Mislav Marohnić
7a614ce697 Support triangular git workflows in pr create
- The local git remotes are scanned and resolved to GitHub repositories
- The "base" repo is the first result resolved to its parent repo (if a fork)
- The name of the default branch is read from the base repo
- The "head" repo is the first repo that has push access
2020-01-21 18:26:08 +01:00
vilmibm
bfdf89b579 updated based sorting and fuzzy time display on issue status 2020-01-17 15:38:41 -06:00