Mislav Marohnić
e4c8aa3b2b
Add tests for pr diff --patch
2021-10-08 13:53:19 +02:00
Adarsh K Kumar
e0897fd8e8
#2720 | Add patch flag to pull-request diff command
2021-10-07 23:09:21 +05:30
Sam
becc45a1df
Merge pull request #4437 from cli/fix-extension-io-bug
...
Set io when initializing extension manager
2021-10-06 12:54:25 -07:00
Jose Garcia
b44474c32b
Revert rename for ports cmd
2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7
Revert other rename changes
2021-10-06 13:46:04 -04:00
Jose Garcia
771ac714ac
Update docs
2021-10-06 11:47:18 -04:00
Jose Garcia
3a28643630
Keep codespace struct in API for now
...
- Use a private codespace structure in the cmd pkg to encapsulate common
behavior
2021-10-06 11:44:26 -04:00
Jose Garcia
017632d63d
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-06 09:57:39 -04:00
Jose Garcia
7c497f283b
Update test signature
2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1
Update mock API
2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99
Switch GetCodespace to new API endpoint
...
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
details in the GET request. Ommitting to do so results in a faster
response
2021-10-06 08:50:42 -04:00
Jose Garcia
7fe8357d40
Better short name
2021-10-05 13:30:17 -04:00
Jose Garcia
1971292175
Fixes bug there are +2 codespaces with a conflict
...
- Tracks conflicting name going forward for other records
- Moves the git status dirty star into a constant so we can reference it
2021-10-05 13:24:47 -04:00
Jose Garcia
a8d1718f21
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-05 12:57:11 -04:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public
...
codespace machine: switch `API.GetCodespacesMachines` to use new API
2021-10-05 12:44:38 -04:00
Sam Coe
8f5806d61f
Set io when initializing extension manager
2021-10-05 09:10:49 -07:00
Jose Garcia
975bd7c08a
Change choose codespace prompt
...
- Repo + branch is favored
- Codespace name is included to disambiguate between two codespaces
- Move Codespace model out of out API into its own package
- Update call sites and group behavior under codespace.Codespace
2021-10-05 11:23:12 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public
...
codespace create: update `API.StartCodespace` to use new API endpoint
2021-10-05 09:20:33 -04:00
Jose Garcia
a2e6df18e7
Merge pull request #4432 from cli/jg/rename-pkg
...
codespace: rename the cmd pkg to codespace
2021-10-05 08:23:36 -04:00
Jose Garcia
50d8f1e09a
Merge pull request #4409 from cli/jg/delete-codespace-public
...
codespace delete: update DeleteCodespaces to new API endpoint
2021-10-05 08:20:53 -04:00
Jose Garcia
d02876e6ea
Rename the cmd pkg to codespace
2021-10-04 14:16:04 -04:00
Jose Garcia
e0db10e4dd
Switch API.GetCodespacesMachines to use new API
...
- The SKU terminology is also dropped in favor of "machine" which
matches the nomenclature of the rest of the product.
2021-10-04 13:40:18 -04:00
Jose Garcia
a3efb53c44
Update API.StartCodespace to use new API endpoint
...
- Switch to using name instead of GUID
- Remove GUID from the code since it is not used anywhere else
- Add docs to the api client methods
- Re-gen mocked client
2021-10-04 08:32:02 -04:00
Jose Garcia
6b1876161d
Update DeleteCodespaces to new API endpoint
...
- Drop the need for the user argument
- Update mocks
- Remove no longer applicable TODO comment
- Show message for successful deletion (this regressed)
2021-10-01 12:53:35 -04:00
Jose Garcia
68e54a5904
Merge pull request #4407 from cli/jg/list-codespaces-public
...
codespace list: update ListCodespaces to use new API endpoint
2021-10-01 11:28:37 -04:00
Jose Garcia
05297b8c8d
Update ListCodespaces to use new API endpoint
...
- Removes the need for a User to list codespaces which should result in
a slight speed improvement.
2021-10-01 10:37:15 -04:00
Mislav Marohnić
a723813064
Don't allow the lazyLoadedHTTPClient mutex to wrap Do()
...
We only need a mutex around accessing `l.httpClient`, but never around
the actual HTTP request.
2021-10-01 11:18:15 +02:00
Jose Garcia
0859de0124
Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd
2021-09-30 12:38:41 -04:00
Jose Garcia
9e6c11e767
Move cmd/ghcs to pkg/cmd/codespace
...
- Delete pkg/cmd/codespace/main as it is no longer needed in this
codebase
2021-09-30 11:20:13 -04:00
Jose Garcia
b5bbb442fd
Move internal/api to internal/codespaces/api
2021-09-30 11:06:43 -04:00
Jose Garcia
877ad22da6
Merge pull request #4384 from cli/import-codespaces
...
Import codespaces
2021-09-30 09:44:29 -04:00
Mislav Marohnić
c4ec0a65ba
Merge pull request #4363 from RasmusWL/patch-1
...
Also set `pushRemote` on `gh pr checkout` from fork
2021-09-30 12:01:47 +02:00
Jose Garcia
c3ce95ea1c
Add mutex to guard httpClient
2021-09-29 16:45:51 -04:00
Mislav Marohnić
0d0152b0fa
Have gh codespace inherit the correct API client
2021-09-29 21:21:16 +02:00
vilmibm
7efd06b87d
rename function
2021-09-29 13:43:37 -05:00
vilmibm
a2e7eaf808
test update available for binary ext in list
2021-09-29 13:39:00 -05:00
vilmibm
ef08712354
test list
2021-09-28 19:27:21 -05:00
vilmibm
3971df4f93
switch to stubBinaryExtension
2021-09-28 19:23:28 -05:00
vilmibm
392460b81e
WIP switching to stubBinaryExtension
2021-09-28 15:45:49 -05:00
vilmibm
541ed3ba6f
test Upgrade with binary exts
2021-09-28 15:33:11 -05:00
vilmibm
22c1778b9f
TODOs
2021-09-28 15:04:45 -05:00
vilmibm
94778a9cb0
un-stupid the file mode
2021-09-28 15:04:39 -05:00
vilmibm
1fe49fa776
fix listing, cleanup
2021-09-28 13:07:01 -05:00
vilmibm
54ec5329c5
add ability to upgrade binary extensions
2021-09-28 13:03:00 -05:00
vilmibm
db5bbf799f
use manager io in Upgrade
2021-09-28 13:03:00 -05:00
Mislav Marohnić
7673622830
Mount gh codespace command
2021-09-28 17:03:05 +02:00
Nate Smith
425bc64859
Merge pull request #4090 from bchadwic/pr-checks
...
Revised pending and skipped symbols for pr checks / run commands
2021-09-27 09:25:21 -07:00
Reto Hablützel
f6e9734f17
add more hints to docs
2021-09-25 08:38:26 +02:00
rethab
f5b0d01e86
docs: add hint how to use use stdin in api command
2021-09-25 08:11:47 +02:00
Rasmus Wriedt Larsen
9e3893e104
Also set pushRemote on gh pr checkout from fork
...
As explained in https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote
if you have `remote.pushDefault` set in your global gitconfig (like I
do), then _that_ setting will take precedence over
`branch.<name>.remote` 😞
However, `branch.<name>.pushRemote` will take precedence over your
`remote.pushDefault` setting, such that
`gh pr checkout 123 && make changes && git push` will just work, even if
you have `remote.pushDefault` set 💪
2021-09-24 16:38:25 +00:00