Commit graph

9427 commits

Author SHA1 Message Date
William Martin
ae7ee522d4
Merge pull request #10770 from cli/wm/doc-unknown-step
Document UNKNOWN STEP in run view
2025-04-11 15:49:28 +02:00
William Martin
48274f3118 Document UNKNOWN STEP in run view 2025-04-11 15:23:18 +02:00
Babak K. Shandiz
b65286125b
Add $ anchor to log file regexps
Signed-off-by: Babak K. Shandiz <babakks@github.com>

This is to make sure we do not pick up the wrong file if there is a
`.txt` sequence in the middle of a job name.
2025-04-11 12:41:31 +01:00
Babak K. Shandiz
2d21b4624c
Test normal job run log is preferred over legacy one
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 12:40:26 +01:00
Babak K. Shandiz
940bd10a1d
Prefer normal job run log file over legacy one
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 12:39:09 +01:00
William Martin
83bd23b080
Merge pull request #10740 from cli/babakks/fallback-to-job-run-logs
Fallback to job run logs when step logs are missing
2025-04-11 11:39:07 +02:00
Babak K. Shandiz
5adf3285ec
Explain when a negative number prefix appears
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 10:26:14 +01:00
Babak K. Shandiz
d35236948c
Improve explanation for missing step logs
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 10:17:52 +01:00
Babak K. Shandiz
1bf1153c54
Explain the UNKNWON STEP placeholder
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 10:08:36 +01:00
Babak K. Shandiz
f673b409f7
Replace UNKNOWN with UNKNOWN STEP in job run log
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 09:57:13 +01:00
Babak K. Shandiz
0251a8dd6d
Explain why step logs are preferred
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 09:56:17 +01:00
Kynan Ware
dec71dd9e1
Merge pull request #10710 from cli/kw/first-pass-accessible-prompter
Introduce accessible prompter for screen readers (preview)
2025-04-10 17:28:26 -06:00
Kynan Ware
70537de132
test(prompter): fix invalid comment 2025-04-10 17:18:56 -06:00
Kynan Ware
8cd39923fe test(prompter): fix race condition
This test was trying to block on `expect`’ing a string at the same
time the prompt was completed.

This doesn't need to happen for this test. It should just check for
the output from the Input prompt invocation.
2025-04-10 17:09:22 -06:00
Andy Feller
b8cd094ca8 Ensure markdown confirm prompt shows editor name
Apparently, `gh` might not actually have an editor at the time we're prompting
the user if they want to use it for markdown editing.  In the survey package,
there is a function that will handle fallback to the default editor based on
environment variables and parse it in the case the editor contains flags and
arguments for cases like Visual Studio Code.

Additionally, there are no tests for the EditorName function and the fact it
is loaded via `init` makes this difficult to test.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-04-10 16:28:58 -06:00
Kynan Ware
20ff409bfc fix(prompter): remove needless default value assignment 2025-04-10 16:28:57 -06:00
Kynan Ware
9eee77a2bf test(prompter): doc how accessible prompter tests work 2025-04-10 10:55:24 -06:00
Kynan Ware
8b70870f4f test(prompter): describe why echo is editorcmd 2025-04-10 10:39:59 -06:00
Kynan Ware
47d603221d test(prompter): use *testing.T instead 2025-04-10 10:37:36 -06:00
Babak K. Shandiz
791e1af828
Add missing gc.AssertExpectations calls
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-10 14:09:49 +01:00
Babak K. Shandiz
f0d4acd501
Add tests for IsPinned method
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-10 14:00:24 +01:00
William Martin
057ad52fdb
Merge pull request #10759 from cli/cosign-no-regex
Simplify cosign verification example by not using a regex.
2025-04-10 12:29:44 +02:00
Fredrik Skogman
512fac2dba
Simplify cosign verification example by not using a regex. 2025-04-10 08:39:12 +02:00
leudz
072534c388 Fix multi pages search for gh search 2025-04-10 07:57:43 +02:00
Kynan Ware
4615069773 chore: go mod tidy 2025-04-09 15:51:02 -06:00
Kynan Ware
fab0de5583 fix(prompter): pass io to huh and refactor tests 2025-04-09 15:51:02 -06:00
Kynan Ware
2f5e896535 fix(prompter): update huh and fix tests 2025-04-09 15:18:53 -06:00
Kynan Ware
19633d3855
Merge pull request #10516 from iamazeem/8430-show-hostname-in-repo-creation-prompts
[gh repo create] Show host name in repo creation prompts
2025-04-09 14:30:56 -06:00
William Martin
8f33d81083
Merge pull request #10742 from cli/babakks/improve-regexp
Escape dots in regexp pattern in `README.md`
2025-04-09 20:40:03 +02:00
dependabot[bot]
0311a8b05b
Bump google.golang.org/grpc from 1.71.0 to 1.71.1
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.71.0 to 1.71.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.71.0...v1.71.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.71.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-09 15:05:41 +00:00
Kynan Ware
8fc8486af5 refactor(prompter): rename speechSynthesizerFriendlyPrompter to accessiblePrompter 2025-04-09 08:24:54 -06:00
Kynan Ware
a34c9ea799 doc(prompter env): accessible prompter includes braille reader
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-09 08:20:07 -06:00
Kynan Ware
3b2e7f7f71 chore: go mod tidy 2025-04-09 08:13:21 -06:00
Kynan Ware
861563269a Merge branch 'trunk' into kw/first-pass-accessible-prompter 2025-04-09 08:07:56 -06:00
Meredith Lancaster
17113f431d Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-09 07:23:48 -06:00
Meredith Lancaster
139e82c68c Revert "temporarily skip non-failing tests"
This reverts commit de8778797f.
2025-04-09 07:23:17 -06:00
Meredith Lancaster
7b20ee5549
Merge pull request #10749 from malancas/update-to-sigstore-go-v0.7.1
Update github.com/sigstore/sigstore-go to 0.7.1 and fix breaking function change
2025-04-09 11:58:20 +02:00
Meredith Lancaster
de8778797f temporarily skip non-failing tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 19:09:52 -06:00
Meredith Lancaster
29080dc70a reorganize func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:40:52 -06:00
Meredith Lancaster
d63e2830e0 clean up unneeded sigstore verifier fields
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:35:17 -06:00
Meredith Lancaster
a535cfdbfc flip verifier choice logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:28:56 -06:00
Meredith Lancaster
2559a83945 Merge branch 'refactor-sigstore-verifier-logic' of github.com:malancas/cli into refactor-sigstore-verifier-logic 2025-04-08 16:23:46 -06:00
Meredith Lancaster
366485155e initiate custom verifiers when the sgistore verifier is created
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:23:37 -06:00
Meredith Lancaster
a3bfb158e4
Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-08 16:00:40 -06:00
Meredith Lancaster
323ea74733 add public good and github verifiers as fields for repeated use instead of creating a new one for every attestation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:40:55 -06:00
Meredith Lancaster
35ec7f251c replace sigstore-go test bundle func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:20:51 -06:00
Meredith Lancaster
68b1d8bf29 update sigstore-go
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:20:42 -06:00
Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833
Ensure muted text is thematic and customizable
2025-04-08 16:59:36 -04:00
Andy Feller
6dd8f809b1
Merge pull request #10720 from cli/andyfeler/colorize-label-optin
Introduce configuration setting for displaying issue and pull request labels in rich truecolor
2025-04-08 16:44:25 -04:00
Meredith Lancaster
261cea2075 update error message
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 14:41:18 -06:00