Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state
...
Prompt: avoid resetting PR/issue metadata
2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99
Allow interactive pr create even if we failed to look up commits
2020-12-03 18:02:24 +01:00
Mislav Marohnić
be39f4363b
Make MetadataSurvey testable by accepting an interface
2020-12-03 17:47:40 +01:00
Mislav Marohnić
d6add864b8
Ensure efficient resolving of issue/pr create metadata to GraphQL IDs
...
For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.
For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.
The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
2020-12-03 15:53:13 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix
...
Fix respecting chosen action in interactive `issue create`
2020-12-02 13:02:16 +01:00
Mislav Marohnić
be759785f0
Fix "Continue in browser" for pr create coming from forks
...
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams ( #2465 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-26 17:31:15 +01:00
Zach Boyle
1135e5e3ed
set delete-branch merge flag default to false ( #2466 )
...
Co-authored-by: Divya Ramanathan <ramanad@umich.edu>
2020-11-26 11:54:28 +01:00
Cristian Dominguez
ab05736b98
don't reset previously added metadata
2020-11-25 13:30:54 -03:00
Cristian Dominguez
ea50666c30
Prompt: avoid resetting PR/issue metadata if no option is selected
2020-11-24 13:49:04 -03:00
vilmibm
cf37ce7463
no shorthand for --recover
2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb
switch to recover instead of resubmit
2020-11-23 11:21:34 -08:00
vilmibm
1d408eb30d
linter appeasement
2020-11-23 11:21:28 -08:00
vilmibm
f68909b7a8
use TempFile though the testing is gross
2020-11-23 11:21:28 -08:00
vilmibm
fffd315a7e
fix dumb test
2020-11-23 11:21:28 -08:00
vilmibm
d300526318
preserve and restore issue/pr input on failure
2020-11-23 11:21:28 -08:00
Josh Soref
861d350440
spelling: dunno
2020-11-21 21:43:51 -05:00
Josh Soref
ddd438d5e1
spelling: dismissed
2020-11-21 21:43:51 -05:00
Josh Soref
0e681ca6c4
spelling: beginning
2020-11-21 21:43:46 -05:00
Jakub Warczarek
b205faa941
Implement --web for gh pr checks ( #2146 )
2020-11-17 12:27:07 -06:00
vilmibm
ef52376fe0
fix survey invocation
2020-11-13 10:35:32 -08:00
vilmibm
a686455fb6
add Draft to issue state
2020-11-12 12:17:37 -08:00
vilmibm
b231e6c2cf
use NewIssueState
2020-11-12 12:15:48 -08:00
vilmibm
f5277e452e
get everything working
2020-11-12 12:03:32 -08:00
vilmibm
0ed7879329
stop using Defaults struct
2020-11-12 12:03:20 -08:00
vilmibm
1c280d4341
stop using string pointer
2020-11-12 12:03:20 -08:00
vilmibm
6671106448
WIP works, probably some title/body input edge cases
2020-11-12 12:03:20 -08:00
vilmibm
6fde02df1c
use named output param
2020-11-12 12:02:17 -08:00
Mislav Marohnić
5b4a08dcb9
Ensure that only PATH is searched when shelling out to external commands
...
Works around https://github.com/golang/go/issues/38736 for Windows.
2020-11-11 16:33:13 +01:00
Cristian Dominguez
fa8674386b
Render links as absolute URLs in repo view ( #2363 )
...
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2020-11-11 13:13:19 +01:00
Alisson Santos
cf617e88f4
Extract repeated code to util function
2020-11-03 22:05:04 +01:00
Nate Smith
24d863eccc
Merge pull request #2316 from cli/colors-1624
...
migrate off of utils color functions
2020-11-03 12:49:02 -06:00
Sam
d79eb494d9
Merge pull request #2279 from malaDev/1818-pr-checks-empty
...
add message on `pr checks` returns no CI with non-empty PR
2020-11-03 10:14:31 +03:00
Sam Coe
9acbf8aae4
Refactor regexp writer
2020-11-03 09:59:40 +03:00
Sam Coe
bf46b870cb
Add multiple writes test
2020-11-03 09:59:39 +03:00
Sam Coe
eaa685ac9b
Use custom scanLines function for RegexWriter
2020-11-03 09:59:38 +03:00
Sam Coe
212993632b
Fix up regex to escape dot in URL
2020-11-03 09:59:11 +03:00
Sam Coe
28b3b2c9e7
Address PR comments
2020-11-03 09:59:09 +03:00
vilmibm
47eef416b3
more iostreams passing
2020-11-02 11:47:12 -08:00
vilmibm
893fe09a83
try passing iostreams around instead of writer+colorscheme
2020-11-02 11:44:50 -08:00
vilmibm
74fe97b689
use shared color function
2020-11-02 11:26:11 -08:00
vilmibm
46a1598c19
favor SuccessIcon
2020-11-02 11:13:28 -08:00
vilmibm
a2aa154794
port entirely to ColorScheme
2020-10-29 12:37:45 -07:00
Mislav Marohnić
6b953f2913
Simplify checks test
2020-10-29 13:08:25 +01:00
Irzhy Ranaivoarivony
03309930f0
add message on pr checks returns no CI with non-empty PR
2020-10-29 13:08:25 +01:00
Mislav Marohnić
e093d23521
Merge pull request #2276 from ianbillett/view-closed-prs
...
Allow `gh pr view <closed_pr_branch_name>` to view closed PRs
2020-10-28 17:50:10 +01:00
Mislav Marohnić
2ac68cc534
PullRequestForBranch: fix outdated error message
...
This method doesn't necessarily search through open pull requests.
2020-10-28 15:50:59 +01:00
Ian Billett
0f61272333
Allow PullRequestForBranch to search in closed pull requests
2020-10-28 15:50:59 +01:00
Mislav Marohnić
e74e4310bb
Merge pull request #2208 from cli/merge-confirmation-fixup
...
Restore backwards compatibility in scripted `pr merge`
2020-10-27 13:25:18 +01:00
Mislav Marohnić
4b395c5dd2
Merge pull request #2234 from XD-DENG/stringsbuilder
...
Use strings.Builder for more efficient string concatenation
2020-10-21 18:22:43 +02:00