Commit graph

4961 commits

Author SHA1 Message Date
Alan Donovan
43198b24aa use errgroup 2021-09-03 12:50:11 -04:00
Jose Garcia
9193b03b69 introduce follow, deprecate tail 2021-09-03 12:40:01 -04:00
Jose Garcia
9dbf267e54 codespace flag, deprecate argument 2021-09-03 12:33:47 -04:00
Jose Garcia
3216cbc07f codespace flag, deprecate argument 2021-09-03 11:43:10 -04:00
Jose Garcia
b1d83fe294 codespace flag, deprecate argument 2021-09-03 11:33:33 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Mislav Marohnić
8f3b6749d7
Merge pull request #4241 from cli/saml-error
Suggest to re-authenticate to fix "SAML enforcement" error
2021-09-03 16:10:16 +02:00
Alan Donovan
10a129b764 Merge pull request #13 from github/listen-race
move Listen call into clients to avoid race
2021-09-03 10:05:02 -04:00
Alan Donovan
e2552fbd2a rename to ForwardToListener 2021-09-03 09:43:31 -04:00
Alan Donovan
5bd0519ef3 move Listen call into clients to avoid race 2021-09-02 17:52:49 -04:00
Alan Donovan
88146a16a0 Merge pull request #110 from github/join-session
Update to go-liveshare v0.11.0
2021-09-02 17:26:01 -04:00
Alan Donovan
786a631995 fix local/remote confusion in getPorts (!) 2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff fix go vet loopclosure finding 2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b update go-liveshare@v0.11.0 2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Alan Donovan
b4686935b9 Merge pull request #12 from github/fix-share-data-race
Fix data race in StartSharing
2021-09-02 15:44:49 -04:00
Alan Donovan
4438b85e29 comment tweaks 2021-09-02 15:41:36 -04:00
Alan Donovan
94319d4cfe move localPort parameter to ForwardToLocalPort 2021-09-02 15:34:57 -04:00
Alan Donovan
94b91661cc don't forget to close conn in case of sharing error 2021-09-02 14:30:19 -04:00
Jose Garcia
ab47e97540 Merge pull request #112 from github/jg/start-errs
api start: ignore any 7 err code in start
2021-09-02 14:14:41 -04:00
Jose Garcia
090af2290b pr feedback 2021-09-02 14:13:40 -04:00
Mislav Marohnić
029d49f3b3
Merge pull request #4199 from cli/go-module-v2
Rename the module to "github.com/cli/cli/v2"
2021-09-02 20:10:09 +02:00
Alan Donovan
87b15aa264 Fix data race in StartSharing 2021-09-02 14:03:48 -04:00
Mislav Marohnić
e0fa56dc29 Merge remote-tracking branch 'origin' into go-module-v2 2021-09-02 20:02:16 +02:00
Nate Smith
49652cdefa
Update pkg/cmd/run/cancel/cancel.go
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2021-09-02 12:57:50 -05:00
Jose Garcia
5c65cfd249 ignore any 7 err code in start 2021-09-02 13:42:52 -04:00
Nate Smith
1af6a669e3
Merge pull request #4214 from cli/garden-portability
Use `x/term` package for repo garden instead of shelling out to stty
2021-09-02 12:39:23 -05:00
Jose Garcia
881e6d5940 Merge pull request #111 from github/jg/remove-dir
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00
Jose Garcia
c15d810d68 remove extra verb arg 2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d sketch after API changes in go-liveshare#11 2021-09-02 12:38:27 -04:00
Alan Donovan
e9cb521bfd Merge pull request #11 from github/session
rename Server to Session and simplify API
2021-09-02 12:37:00 -04:00
Alan Donovan
6f45c7fa7d point out data races to be fixed 2021-09-02 12:14:04 -04:00
Alan Donovan
23ea329f2e Merge branch 'main' into session 2021-09-02 11:49:13 -04:00
Alan Donovan
05a3d90a99 more tweaks 2021-09-02 11:39:29 -04:00
Alan Donovan
34c20cf105 Merge pull request #10 from github/rpc-fixes
fix two data races in rpcHandler
2021-09-02 11:38:38 -04:00
Alan Donovan
65c19a3317 Merge pull request #107 from github/spelling-again
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
4cceda1af0 rename Server to Session and simplify API 2021-09-02 11:06:58 -04:00
Alan Donovan
45f9ae76f4 Merge pull request #108 from github/update-liveshare
Update go-liveshare to v0.10.0
2021-09-02 09:48:28 -04:00
Alan Donovan
c31fc05746 more typo fixes 2021-09-02 09:09:05 -04:00
Alan Donovan
af38292f1e fix data races 2021-09-01 18:18:43 -04:00
Alan Donovan
ca6d074333 Merge branch 'main' into wip 2021-09-01 17:55:31 -04:00
Alan Donovan
72a2099a50 fix breakage from API changes 2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21 use correct correct spelling of codespace 2021-09-01 17:26:26 -04:00
Jose Garcia
ef8dde4d2e Merge pull request #106 from github/jg/sku-params
ghcs create: pass branch for sku selection, pre-select if only one is returned
2021-09-01 16:43:02 -04:00
Jose Garcia
bfeb4e77c9 remove dir command 2021-09-01 14:38:37 -04:00
Jose Garcia
2163aba3d5 pass branch for sku selection, pre-select if only one is returned 2021-09-01 13:54:45 -04:00
Mislav Marohnić
abfe29617a
Merge pull request #4253 from despreston/4248-line-range
feat(4248): add support for line range w/ browse
2021-09-01 18:08:51 +02:00
Alan Donovan
55fa17d8bc wip 2021-08-31 17:30:40 -04:00