Commit graph

4961 commits

Author SHA1 Message Date
Mislav Marohnić
feadf684fb Merge remote-tracking branch 'origin' into ghe-auth-tweaks 2020-09-07 17:37:16 +02:00
Mislav Marohnić
9109b68344
Merge pull request #1625 from cli/api-no-accept
Avoid setting a default `Accept` header in `hub api`
2020-09-07 17:30:12 +02:00
Mislav Marohnić
016df6af1c Consolidate Linux installation docs
- Move all Linux installation docs to the separate page to eliminate repetition
- Indicate that only Ubuntu 20.04 is supported for apt-add-repository method
- Pull openSUSE/SUSE out of the "unofficial" section since it refers to
  downloading our official packages
- Point out manual installation methods as well
2020-09-07 17:06:03 +02:00
Mislav Marohnić
44a500e50f Remove Homebrew tap from goreleaser config
Our tap is now deprecated in favor of `gh` from homebrew-core
2020-09-07 16:28:51 +02:00
Mislav Marohnić
a983131479 Exercise most of the release process on prereleases
- deb and rpm packages are now built for prereleases
- consolidate setup for deb & rpm
- man pages are generated for prereleases
- the `cli.github.com` site is only pushed to on full releases

Bonus:
- only publish the GitHub release after the Windows MSI is uploaded
- hub does not need downloading
2020-09-07 16:11:27 +02:00
Mislav Marohnić
a0e0f31363 Disable ANSI color in prompts when color is disabled 2020-09-07 13:10:43 +02:00
Mislav Marohnić
d38a0c5d84 Encapsulate checking color-controlling environment variables 2020-09-07 13:10:43 +02:00
Mislav Marohnić
84b1b36433 Simplify handling the "broken pipe" error 2020-09-07 12:41:28 +02:00
Mislav Marohnić
5e11fe8fa0
Merge pull request #1623 from bdougie/bdougie-filter-credit-bots
Filter gh credits for humans
2020-09-07 11:44:59 +02:00
Brian 'bdougie' Douglas
d83c99f87f filter by contributor type 2020-09-06 22:02:02 -07:00
Mislav Marohnić
ccfe38de26 Add PAGER support to commands that produce significant output 2020-09-04 23:36:14 +02:00
Giacomo Alberini
cab0e0f43d Add pr Title and number to commitHeadline in merge request 2020-09-04 23:07:51 +02:00
Mislav Marohnić
d01355e24b Add global PAGER support
Extract the ad-hoc PAGER behavior from `pr diff` command and make it
available opt-in to any command through IOStreams.
2020-09-04 23:07:17 +02:00
Mislav Marohnić
ca2f2b18ca Add support for CLICOLOR "standard"
The CLICOLOR_FORCE environment variable can now be used to force color
output even when stdout is redirected. https://bixense.com/clicolors/
2020-09-04 21:32:58 +02:00
Mislav Marohnić
995828abf8 Avoid setting a default Accept header in hub api
Due to our HTTP client default behavior, an `Accept` header is added to
all API requests. This is fine for all commands except `gh api`, where
the user should ideally have fine-grained control over most aspects of
HTTP requests and where there should be little to no defaults in general.
2020-09-04 17:42:57 +02:00
Mislav Marohnić
2bb5e052d8 Send GITHUB_TOKEN to github.com and GITHUB_ENTERPRISE_TOKEN to GHES 2020-09-04 17:25:37 +02:00
Mislav Marohnić
3e7a2585c5 Tighten git remote URL parsing
We now only support git URLs that have one of the explicitly supported protocols.
2020-09-04 16:18:26 +02:00
Mislav Marohnić
6ceea6e531
Merge pull request #1616 from cli/display-width-punctuation
Fix detecting display width of common punctuation characters
2020-09-04 16:04:43 +02:00
ShubhankarKG
05a39b732a Fix tests 2020-09-04 18:58:15 +05:30
ShubhankarKG
147cdcdbb4 Add extra confirm step and a flag 2020-09-04 18:24:31 +05:30
vilmibm
deb92f93a6 update linux installation docs 2020-09-03 14:54:35 -05:00
vilmibm
eb132a1ae6 Merge remote-tracking branch 'origin/trunk' into checks 2020-09-03 14:48:32 -05:00
vilmibm
894be03923 linux repo creation 2020-09-03 13:47:48 -05:00
Mislav Marohnić
a470d49c64 Fix reporting release URL when creating with assets 2020-09-03 16:06:28 +02:00
Mislav Marohnić
1ad9b0b14e Have FindDraftRelease be truer to its name 2020-09-03 15:35:07 +02:00
Mislav Marohnić
d4b45c68e2 Allow downloading assets from the latest release 2020-09-03 15:34:10 +02:00
Mislav Marohnić
151a7340a6 Fix .zip and .js overrides for Windows 2020-09-03 11:44:54 +02:00
Mislav Marohnić
02a057a709 Try fixing Windows tests 2020-09-02 22:11:46 +02:00
Mislav Marohnić
b93c896561 Upgrade text/width package 2020-09-02 21:01:39 +02:00
Mislav Marohnić
1f86e7cd04 Fix display width of common punctuation characters
These characters get classified as "East Asian Mixed" by Go's
`text/width` package, and thus assumed that their printed version
occupies a width of 2 characters, whereas they each only occupy one.

I'm not sure why they are classified as East Asian, but I did not have
the energy to dive into Go's Unicode tables, so here is a workaround
based on an exclusion list.
2020-09-02 20:59:11 +02:00
Sam
00836079dd
Merge pull request #1600 from cli/update-readme
Remove feedback survey from README
2020-09-02 19:42:40 +02:00
vilmibm
2961c655fb review feedback 2020-09-02 11:33:39 -05:00
Mislav Marohnić
abf83c02c0
Merge pull request #1606 from cli/ghe-oauth-422-response
Handle HTTP 422 response to OAuth Device flow detection
2020-09-02 13:12:11 +02:00
AliabbasMerchant
9e7279604d Fix failing tests for Windows (due to line-ending issues) 2020-09-02 10:03:56 +05:30
AliabbasMerchant
51c5595cad Interactive template selection test for PR create 2020-09-02 09:56:28 +05:30
Nate Smith
bf9d3ab12f
Merge pull request #1607 from cli/pwsh-tty
properly check for tty when in powershell
2020-09-01 16:16:31 -05:00
Mislav Marohnić
6933c381bf Restore Go 1.13 compatibility 2020-09-01 19:12:02 +02:00
Mislav Marohnić
4976bd75e1 Fix date-based release output and tests 2020-09-01 19:09:10 +02:00
Mislav Marohnić
0f42c7af4d Add tests for release create, delete, download, view 2020-09-01 18:56:30 +02:00
nate smith
49ab3ec5bf check for tty before creating colorables 2020-09-01 11:18:34 -05:00
Nate Smith
734959c39d
Merge pull request #1603 from cli/create-pr-metadata-failure
Be transparent about which part of `pr create` flow failed
2020-09-01 10:51:55 -05:00
Sam Coe
b4956006be Fix up feature request issues url 2020-09-01 15:52:58 +02:00
Mislav Marohnić
9ef1791fdb Provide machine-readable release view output 2020-09-01 15:23:43 +02:00
Mislav Marohnić
d0d9cc2f9b View latest release if no tag provided 2020-09-01 14:16:59 +02:00
Mislav Marohnić
48a827ee34 Tweak gh config set -h output format on auth login 2020-09-01 13:19:30 +02:00
Mislav Marohnić
0de3f678bc Only validate --hostname when flag was provided 2020-09-01 13:19:19 +02:00
Mislav Marohnić
b029397d32 Validate the --hostname flag value 2020-09-01 13:06:13 +02:00
Mislav Marohnić
1a051e9c44 Validate hostname as entered in the auth prompt 2020-09-01 12:59:58 +02:00
Mislav Marohnić
a8b06c329b Ensure correct ANSI color output during OAuth flow on Windows
We used to write directly to `os.Stderr`, but we first need to convert
that into a colorable stream.
2020-09-01 12:31:36 +02:00
Sam Coe
35e739dfbd Link to bugs and feature requests 2020-09-01 10:25:16 +02:00