Rasmus Wriedt Larsen
9e3893e104
Also set pushRemote on gh pr checkout from fork
...
As explained in https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote
if you have `remote.pushDefault` set in your global gitconfig (like I
do), then _that_ setting will take precedence over
`branch.<name>.remote` 😞
However, `branch.<name>.pushRemote` will take precedence over your
`remote.pushDefault` setting, such that
`gh pr checkout 123 && make changes && git push` will just work, even if
you have `remote.pushDefault` set 💪
2021-09-24 16:38:25 +00:00
Mislav Marohnić
c82d4c5472
Avoid passing params struct as pointer
2021-09-24 17:36:18 +02:00
Mislav Marohnić
dc8f6ef183
No longer accept a logger in CreateCodespace
...
The API layer shouldn't concern itself with logging progress to stderr.
Instead, we will subsequently add progress indicators in the caller
around CreateCodespace and other potentially slow commands as needed.
2021-09-24 17:30:31 +02:00
Mislav Marohnić
ca0f89d3bc
Introduce an App struct that executes core business logic
...
The Cobra commands are now a light wrapper around the App struct.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-24 17:20:34 +02:00
Mislav Marohnić
8807b3a73a
Merge pull request #184 from github/args-constraint
...
Consistently institute constraints for position arguments and improve error message
2021-09-24 16:02:36 +02:00
Mislav Marohnić
92d0abd6ab
Merge pull request #79 from github/raffo/delete-codespaces
...
Add code and command to delete unused codespaces
2021-09-24 16:02:05 +02:00
Mislav Marohnić
3d017b2824
Fix stderr output on delete errors
2021-09-24 15:09:41 +02:00
Mislav Marohnić
750c3e38f3
Merge pull request #4243 from wilso199/3704-credential-helper
...
Fixes #4274
2021-09-24 14:50:59 +02:00
Mislav Marohnić
b38ce24497
Ensure correct path to gh after gh auth refresh git credential setup
2021-09-24 14:43:48 +02:00
Mislav Marohnić
d853ce5bc9
Avoid resolving executable() until requested at runtime
...
This is to avoid hitting the filesystem and resolving symlinks
unnecessarily. The value of executable is just used conditionally by a
handful of commands.
2021-09-24 14:42:41 +02:00
Mislav Marohnić
78b35b7b6e
Merge remote-tracking branch 'origin' into 3704-credential-helper
2021-09-24 14:35:01 +02:00
Nate Smith
96aed38819
Merge pull request #4308 from cli/ext-bin
...
install binary extensions
2021-09-23 10:51:37 -07:00
Jose Garcia
4eb15134a4
Merge pull request #189 from github/jg/inline-go-liveshare
...
Inline go-liveshare v0.20.0
2021-09-23 13:45:11 -04:00
Jose Garcia
5d6ea5029e
Linter fixes
2021-09-23 13:36:04 -04:00
Jose Garcia
65dcb0f428
Linter fixes
2021-09-23 13:22:20 -04:00
Jose Garcia
08bc181d79
Linter fixes
2021-09-23 13:16:20 -04:00
Jose Garcia
b8f35f950c
Linter fixes
2021-09-23 13:14:35 -04:00
Mislav Marohnić
75c1dfdf49
Fetch codespace by name directly if name argument given
2021-09-23 18:57:22 +02:00
Jose Garcia
c4114cc972
Linter fixes
2021-09-23 11:58:55 -04:00
Jose Garcia
fb53ccb06a
Linter fixes
2021-09-23 11:56:41 -04:00
Jose Garcia
958990cef8
More linter fixes
2021-09-23 11:47:52 -04:00
Jose Garcia
d0c65e5490
Linter fixes
2021-09-23 11:36:27 -04:00
Jose Garcia
f4396e8f1a
Inline go-liveshare with history
2021-09-23 11:28:04 -04:00
Jose Garcia
9ae7eb5869
Merge branch 'go-liveshare-download' into jg/inline-go-liveshare
2021-09-23 11:19:46 -04:00
Jose Garcia
6ca35d0e73
Moved files to liveshare dir
2021-09-23 11:18:49 -04:00
Mislav Marohnić
e8212a80a9
Print delete failures as they occur
2021-09-23 17:14:25 +02:00
Mislav Marohnić
1232dba684
Merge remote-tracking branch 'origin' into raffo/delete-codespaces
2021-09-23 16:43:22 +02:00
Jose Garcia
3e26a15342
Merge pull request #188 from github/jg/update-liveshare
...
Update to go-liveshare v0.20.0
2021-09-23 10:22:09 -04:00
Jose Garcia
f1c35ba9da
Update docs
2021-09-23 10:21:01 -04:00
Jose Garcia
fb12f4108f
Merge pull request #181 from github/jg/poll-on-async-creation
...
ghcs create: poll for codespaces that are being retried by the server
2021-09-23 10:10:57 -04:00
Jose Garcia
a3c900c3b9
Merge pull request #185 from github/jg/buffer-channels
...
Add buffered to channels to avoid goroutine leak
2021-09-23 10:07:56 -04:00
Jose Garcia
9654dc4bd3
Update to go-liveshare v0.20.0
2021-09-23 10:07:14 -04:00
Jose Garcia
186b90b12e
Rename request type
2021-09-23 08:29:24 -04:00
Jose Garcia
13d7804a35
Remove API test, inline poller
2021-09-23 08:26:23 -04:00
vilmibm
7bf85355a9
restore cached client
2021-09-22 15:59:57 -05:00
vilmibm
5f02ed2656
linter appeasement
2021-09-22 15:59:50 -05:00
Jose Garcia
4e0ac15fe0
Add buffer to channels to avoid goroutine leak
2021-09-22 15:10:47 -04:00
Jose Garcia
9a558bc58c
Early return if polling is not required
...
- Add context to errors in poller
2021-09-22 15:03:12 -04:00
Mislav Marohnić
7a91ba5942
Print usage help when args given to "NoArgs" commands
2021-09-22 19:51:12 +02:00
Mislav Marohnić
a55f7af92c
Correct wrong args constraints
2021-09-22 19:36:25 +02:00
Jose Garcia
208f1721b5
Rename ProvisionCodespaceParams
2021-09-22 13:21:02 -04:00
Jose Garcia
70a2ea2e6a
PR Feedback
...
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
2021-09-22 13:19:26 -04:00
Jose Garcia
d2d21996bc
Move ProvisionCodespace to API client
...
- Make CreateCodespace private along with its errors
2021-09-22 11:49:41 -04:00
Mislav Marohnić
32d3a38465
Name of the codespace
2021-09-22 16:39:50 +02:00
Mislav Marohnić
cb7b535b91
Add tests for delete
2021-09-22 16:11:34 +02:00
Jose Garcia
8c5330d9e9
Rename error
2021-09-22 10:04:18 -04:00
Jose Garcia
2a0ea1617b
Handle specific error for GetCodespaceToken
2021-09-22 09:40:45 -04:00
Jose Garcia
86717f14a1
Implement codespaces.Provision
...
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
is returned
2021-09-22 09:09:09 -04:00
Alan Donovan
770151313f
Merge pull request #22 from github/connect
...
Merge NewClient and JoinWorkspace into Connect
2021-09-22 08:55:26 -04:00
Jose Garcia
48e3473a95
PR Feedback
...
- Bring context.Timeout into the poller
- Accept duration and interval
- Other tidy up
2021-09-21 18:18:30 -04:00
