STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3437 commits 87 branches 0 tags 160 MiB
Commit graph

3437 commits

This branch
This branch
All branches
Author SHA1 Message Date
Peter Kristensen
bc7f733267 Add body argument to pr merge command. 2021-01-20 13:24:27 +01:00
vilmibm
3797aa72ff delete unused parameter 2021-01-19 19:08:49 -08:00
Karel Coudijzer
a7b9e3916c Show progress while creating pr 2021-01-19 22:19:10 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion 
Use Testify assertions in tests
 2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964 Deprecate test.ExpectLines 
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
 2021-01-18 23:25:45 +01:00
Mislav Marohnić
411bd4a70e 🔥 unused test/fixtures/ 2021-01-18 22:53:03 +01:00
Mislav Marohnić
c308f1cd91 Prevent further use of SetPrepareCmd and InitCmdStubber 2021-01-18 22:44:53 +01:00
Mislav Marohnić
5531498f27 Migrate to new cmd stubber in repo fork tests 2021-01-18 22:42:27 +01:00
Mislav Marohnić
584b33e79c Migrate to new cmd stubber in repo clone tests 2021-01-18 22:42:13 +01:00
Mislav Marohnić
c63acf6728 Migrate to new cmd stubber in misc. tests 2021-01-18 22:42:01 +01:00
Mislav Marohnić
1717c8d083 Migrate to new cmd stubber in git tests 2021-01-18 22:39:59 +01:00
Mislav Marohnić
bf4bc1511f Migrate to new cmd stubber in merge tests 2021-01-18 20:15:40 +01:00
Mislav Marohnić
683ebee6ef Consistently use green success icon 
For operations such as closing an issue or merging a PR, we would
display the success icon (a checkmark) in red and magenta colors,
respectively, to reflect the latest state of the record operated on
(red: closed; magenta: merged).

This was always confusing to me, seeing it both in code and in the UI,
because I'm instinctively thinking that it's a bug and have to remind
myself that it's by design.
 2021-01-18 19:57:38 +01:00
Mislav Marohnić
6e5a90821c pr merge: handle case when a cross-repo PR was already merged 
In this case, do not ever offer to delete the branch.
 2021-01-18 19:49:20 +01:00
Mislav Marohnić
e566c61671
Merge pull request #2789 from dpromanko/dpromanko/2625 2021-01-18 18:41:01 +01:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Nilesh Singh
f3fcaf6c9c Fix error message text & add test case 2021-01-17 14:42:49 +05:30
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Nilesh Singh
2f5ffbd60a Add fail message for non-existent hostname 2021-01-15 13:28:57 +05:30
Mislav Marohnić
4750e4ae18
Merge pull request #2774 from rneatherway/codeql-add-pull-request-trigger 
Add on: pull_request trigger to CodeQL workflow
 2021-01-13 14:40:38 +01:00
Robin Neatherway
3ab01661e4 Add on: pull_request trigger to CodeQL workflow 
From February 2021, in order to provide feedback on pull requests, Code Scanning workflows must be configured with both `push` and `pull_request` triggers. This is because Code Scanning compares the results from a pull request against the results for the base branch to tell you only what has changed between the two.

Early in the beta period we supported displaying results on pull requests for workflows with only `push` triggers, but have discontinued support as this proved to be less robust.

See https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#scanning-pull-requests for more information on how best to configure your Code Scanning workflows.
 2021-01-13 11:09:00 +00:00
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments 
Create issue comments
 2021-01-12 11:24:09 -08:00
Mislav Marohnić
3985577de0
Merge pull request #2759 from cristiand391/migrate-legacy-tests 
Migrate legacy HTTP tests
 2021-01-12 18:20:45 +01:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments 2021-01-11 13:56:17 -08:00
Mislav Marohnić
c73845ee22
Merge pull request #2742 from cli/linter-update 
Simplify linter output setup
 2021-01-11 15:32:18 +01:00
Mislav Marohnić
39431a101d Port select portions of Makefile to script/build.go 
This is to enable build tasks on Windows.
 2021-01-08 22:35:57 +01:00
Mislav Marohnić
19ee0eff08 Simplify linter output setup 
`golangci-lint` now supports an output formatter for GitHub Actions, so
we don't need to manually reformat the failure output anymore.
 2021-01-07 16:16:44 +01:00
Mislav Marohnić
5e97775978
Clarify building from source on Windows 
Address https://github.com/cli/cli/issues/2545#issuecomment-751842548
 2021-01-06 18:08:02 +01:00
Sam Coe
155507d31d
Make comment command easier to test 2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. (#2671) 
This addresses issue #2587.
 2021-01-05 14:40:52 -08:00
Sam Coe
de73b16178
Move CreateComment mutation 2021-01-05 10:39:07 -08:00
Sam Coe
1fc8b66b26
Address PR comments 2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests 2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue 2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor 2021-01-05 10:35:09 -08:00
Mislav Marohnić
86eb264277
Merge pull request #2650 from cli/auth-extract 
Extract the oauth package into a separate repo
 2021-01-05 16:41:22 +01:00
Mislav Marohnić
536a173364 Enable debugging HTTP traffic during auth login/refresh 2021-01-05 16:24:47 +01:00
Mislav Marohnić
ca83106a38
Merge pull request #2727 from cristiand391/remove-unused-methods 
Remove unused methods
 2021-01-05 15:33:56 +01:00
Sam
4c53e5eee6
Merge pull request #2698 from camelid/view-newline 
view: Add missing newline
 2021-01-04 11:20:40 -08:00
Cristian Dominguez
21a57d9253 Remove unused methods 2021-01-04 07:35:41 -03:00
Camelid
8ff4cc40e6 view: Add missing newline 
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
 2020-12-27 11:37:59 -08:00
Cristian Dominguez
55c717d3d3 Print friendly error when 'gh gist <command>' is missing required argument 2020-12-21 10:01:30 -03:00
Nate Smith
230441e1a5
Merge pull request #2222 from Crunch09/issue-2115 
add `gist clone` command
 2020-12-18 13:07:44 -08:00
Mislav Marohnić
9140e88708 Extract oauth package 2020-12-18 20:27:56 +01:00