STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4856 commits 87 branches 0 tags 160 MiB
Commit graph

1628 commits

Author SHA1 Message Date
Jose Garcia
0748e658cc Switches port binding to 127.0.0.1 where possible 2021-10-14 11:07:25 -04:00
Jose Garcia
5e56b4a7ce Fix tests 2021-10-14 09:21:03 -04:00
Jose Garcia
3544275c2f Implement new API payload for a Codespace 2021-10-14 09:10:15 -04:00
Mislav Marohnić
d68126af99 Avoid macOS prompt to allow incoming connections in liveshare tests 
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
 2021-10-14 14:23:36 +02:00
nate smith
d72d0f47f6 Merge remote-tracking branch 'origin/trunk' into browse-commit 2021-10-13 16:53:50 -05:00
Mislav Marohnić
2ca18e0600 Warn about missing OAuth scopes when reporting HTTP 4xx errors 
If a 4xx server response lists scopes in the X-Accepted-Oauth-Scopes
header that are not present in the X-Oauth-Scopes header, the final
error messaging on stderr will now include a hint for the user that they
might need to request the additional scope:

    $ gh codespace list
    error getting codespaces: HTTP 403: Must have admin rights to Repository. (https://api.github.com/user/codespaces?per_page=30)
    This API operation needs the "codespace" scope. To request it, run:  gh auth refresh -h github.com -s codespace
 2021-10-13 23:24:14 +02:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix 
codespace ssh: fix for nil logger on non-debugging scenarios
 2021-10-13 14:44:10 -04:00
Jose Garcia
3dbec86556 PR Feedback 2021-10-13 14:30:33 -04:00
Jose Garcia
d6b5157eff Fix for nil logger on non-debugging scenarios 2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting (#4497) 
* Add org scoped port forwarding + fix test formatting

* Redesign port visibility

* Update pkg/cmd/codespace/ports.go

Co-authored-by: Jose Garcia <josebalius@github.com>

* Change sub command to privacy

* Example pr comment

* Fix test mock

* Fix test mock

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-13 13:56:03 -04:00
Jose Garcia
07fa60b69a PR Feedback 2021-10-13 11:46:57 -04:00
Jose Garcia
be10950058 Update mocks 2021-10-13 11:04:15 -04:00
Jose Garcia
4fb4a21efd Rename + docs 2021-10-13 10:57:50 -04:00
Jose Garcia
97b52b30fc Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive 2021-10-13 10:45:40 -04:00
Jose Garcia
ea0d0a543f Initial StopCodespace implementation 
- API
- Command
 2021-10-13 07:45:54 -04:00
Sam Coe
defbf0f306
Make extension upgrade output more friendly 2021-10-12 16:47:19 -07:00
Jose Garcia
5170a2931f Switch to standard lib log.Logger & support dfile 
- --debug-file flag can now be used in conjuction with --debug to
  specify the debug file path
- Push out logger concerns to callers of liveshare
 2021-10-12 15:45:05 -04:00
Meijke
8c9049a364
Merge branch 'trunk' into repo-delete 2021-10-12 11:02:27 -07:00
meiji163
548b39c140 add one test 2021-10-12 10:50:54 -07:00
meiji163
5d433021bd simplify err handling and change flags 2021-10-12 10:16:14 -07:00
Sam Coe
ed3427974c
Use concurrency to check for extension updates 2021-10-12 09:44:41 -07:00
Parth
ec554822b8
Add repo archive command (#4410) 
Co-authored-by: meiji163 <mysatellite99@gmail.com>
 2021-10-12 12:48:40 +02:00
Mateusz Urbanek
cedbbe3c2a
Add limit flag to codespace list (#4453) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-10-11 18:32:40 +00:00
meiji163
9ea36de269 add tests 2021-10-08 20:32:07 -07:00
Mislav Marohnić
e4c8aa3b2b Add tests for pr diff --patch 2021-10-08 13:53:19 +02:00
Jose Garcia
1aefc74378 Add more time between events 2021-10-07 16:48:09 -04:00
Jose Garcia
1ff58a3de7 Update docs, remove needless condition check 2021-10-07 16:39:43 -04:00
Jose Garcia
97cbdca84a Fix additional race in tests 2021-10-07 15:45:55 -04:00
Jose Garcia
8a559ee12a Fix unrelated tests 2021-10-07 15:38:16 -04:00
Jose Garcia
2406f3f09a Fix races and remove unreachable code 2021-10-07 15:32:07 -04:00
Jose Garcia
7ba2fb4c0e Make fileLogger more versatile 2021-10-07 15:19:14 -04:00
Jose Garcia
8f5d6bb672 Tests for most of the new behavior 
- Made the heartbeat interval configurable for easier testing
- Moved span to the top of connect to capture the full execution
 2021-10-07 15:14:42 -04:00
Adarsh K Kumar
e0897fd8e8 #2720 | Add patch flag to pull-request diff command 2021-10-07 23:09:21 +05:30
meiji163
a8028be8f9 add delete HTTP request and confirmation prompting 2021-10-07 09:53:22 -07:00
Jose Garcia
9c8351ecd8 Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive 2021-10-07 11:10:45 -04:00
Jose Garcia
55f4fcf05c Live Share session activity detection 
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
  instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
  notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
  to log to a new temporary file. The file path is printed to the user.
 2021-10-07 10:42:06 -04:00
Sam
becc45a1df
Merge pull request #4437 from cli/fix-extension-io-bug 
Set io when initializing extension manager
 2021-10-06 12:54:25 -07:00
meiji163
025f86b911 init commit 2021-10-06 12:49:06 -07:00
Jose Garcia
b44474c32b Revert rename for ports cmd 2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7 Revert other rename changes 2021-10-06 13:46:04 -04:00
Jose Garcia
771ac714ac Update docs 2021-10-06 11:47:18 -04:00
Jose Garcia
3a28643630 Keep codespace struct in API for now 
- Use a private codespace structure in the cmd pkg to encapsulate common
  behavior
 2021-10-06 11:44:26 -04:00
Jose Garcia
017632d63d Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 09:57:39 -04:00
Jose Garcia
7c497f283b Update test signature 2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1 Update mock API 2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99 Switch GetCodespace to new API endpoint 
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
  details in the GET request. Ommitting to do so results in a faster
  response
 2021-10-06 08:50:42 -04:00
Jose Garcia
7fe8357d40 Better short name 2021-10-05 13:30:17 -04:00
Jose Garcia
1971292175 Fixes bug there are +2 codespaces with a conflict 
- Tracks conflicting name going forward for other records
- Moves the git status dirty star into a constant so we can reference it
 2021-10-05 13:24:47 -04:00
Jose Garcia
a8d1718f21 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-05 12:57:11 -04:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public 
codespace machine: switch `API.GetCodespacesMachines` to use new API
 2021-10-05 12:44:38 -04:00