Commit graph

62 commits

Author SHA1 Message Date
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Jose Garcia
798075045e remove terminal, bash_profile setup 2021-09-10 14:58:47 -04:00
Jose Garcia
81f08e7baf start converting to flags 2021-09-09 12:08:07 -04:00
Alan Donovan
cbb8253544 consolidate survey functions 2021-09-09 11:57:37 -04:00
Jose Garcia
d8138c08b8 revert errgroup usage for ssh and logs 2021-09-08 14:56:16 -04:00
Alan Donovan
2c660fa2e5 avoid ListenTCP helper 2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa use errgroup 2021-09-03 12:50:11 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b update go-liveshare@v0.11.0 2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Jose Garcia
881e6d5940 Merge pull request #111 from github/jg/remove-dir
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00
Jose Garcia
c15d810d68 remove extra verb arg 2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d sketch after API changes in go-liveshare#11 2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317 Merge pull request #107 from github/spelling-again
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
72a2099a50 fix breakage from API changes 2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21 use correct correct spelling of codespace 2021-09-01 17:26:26 -04:00
Jose Garcia
bfeb4e77c9 remove dir command 2021-09-01 14:38:37 -04:00
Alan Donovan
37b2f5e979 Merge branch 'main' into runcommand 2021-08-31 17:18:52 -04:00
Alan Donovan
f1c3a22a0b Merge branch 'main' into product-spelling 2021-08-31 16:24:41 -04:00
Alan Donovan
68792d5aa5 Merge branch 'main' into runcommand 2021-08-31 16:19:37 -04:00
Edmundo Gonzalez
d6f52ae557 Merge pull request #91 from github/edgonmsft/codespaces-ssh-rpc
Implement RPC interface so that the codespaces agent starts and configures ssh in the codespace
2021-08-31 13:05:56 -07:00
Alan Donovan
c0aae52289 move port choice, and PortForwarder.Start call, into clients 2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e address review comments 2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321 spell product names (Codespaces, Live Share) correctly 2021-08-31 11:15:26 -04:00
Alan Donovan
ea97e2e73d remove sleep 1s 2021-08-30 18:15:37 -04:00
Alan Donovan
40317e91f8 cleanup to ssh api 2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de Comments from pr. 2021-08-30 21:01:13 +00:00
Edmundo Gonzalez
ee36a005b1 Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc 2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
5db9e2d83e PR changes. 2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8 merge main 2021-08-27 18:18:30 -04:00
Alan Donovan
38ff786a7d cmd/ghcs: style tweaks 2021-08-27 12:03:20 -04:00
Edmundo Gonzalez
b6094e0006 Changes to point to RPC service. 2021-08-26 21:50:20 +00:00
Jose Garcia
46ee45bcdd simplify the state iteration 2021-08-24 17:46:24 -04:00
Jose Garcia
55f0dad3db merge upstream 2021-08-19 18:30:10 +00:00
Mislav Marohnić
517aae2805 Merge remote-tracking branch 'origin' into docs 2021-08-17 14:42:09 +02:00
Mislav Marohnić
6dd0bf8e5e Merge pull request #67 from github/jg/output-formats
add back . indicators & update ConnectToTunnel
2021-08-17 13:07:14 +02:00
Mislav Marohnić
5e472bc0e5 Improve command descriptions and argument assertions 2021-08-16 23:24:11 +02:00
Mislav Marohnić
22be26431e Have --codespace <name> flag be consistent across commands 2021-08-16 22:31:29 +02:00
Jose Garcia
c9c1ff8dac add back . indicators & update ConnectToTunnel 2021-08-16 20:16:50 +00:00
Mislav Marohnić
20d75f0ff9 Normalize logging, output, and error reporting
- Return errors as errors, not print to stdout and return nil
- Ensure errors and warnings are always written to stderr, not stout
- Do not print progress to stdout unless stdout is a terminal
2021-08-12 14:37:23 +02:00
Jose Garcia
76aca39f5b Create status support 2021-08-04 17:35:11 +00:00
Jose Garcia
70f4a7b4b5 Re-introduce secrets export 2021-08-04 13:19:00 +00:00
Jose Garcia
d5003334e3 Remove secrets export 2021-08-03 13:43:09 +00:00
Jose Garcia
be794f1579 creation log support for cat and tail 2021-07-29 17:09:50 +00:00
Jose Garcia
58a055609d logs cmd spike and refactor of ssh tunnel methods 2021-07-29 10:57:51 -04:00
Jose Garcia
cba40ad72a liveshare client upgrade 2021-07-28 08:33:06 -04:00
Issy Long
c092a29350 cmd/ghcs/ssh: Add -c parameter for specifying a Codespace to SSH to
- This adds a `-c`, `--codespace` parameter to `ghcs ssh` to allow for
  non-interactively specifying a Codespace to SSH into, for instance if
  a user has recently done `ghcs list` and already knows which Codespace
  they want to access. Without a value for the `-c` parameter, the
  interactive prompt appears as usual.
2021-07-26 14:58:48 +01:00
Issy Long
b66d65379f cmd/ghcs/*.go: Better short descriptions of what commands do
- I ran `--help` on `ghcs code` and saw `ghcs code` and that was it,
  which was surprising. I expected a description.
- Here's a fix for all of the commands thus far to give them longer
  descriptions.
- I've only done "short" descriptions in Cobra terms, and removed the
  "long" descriptions as they seemed like they needed to be
  unnecessarily verbose.

Before:

```
❯ ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        code
  create      Create
  delete      delete
  help        Help about any command
  list        list
  ports       ports
  ssh         ssh

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ghcs ssh --help
ssh

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```

After:

```
❯ ./ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        Open a GitHub Codespace in VSCode.
  create      Create a GitHub Codespace.
  delete      Delete a GitHub Codespace.
  help        Help about any command
  list        List GitHub Codespaces you have on your account.
  ports       Forward ports from a GitHub Codespace.
  ssh         SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ./ghcs ssh --help
SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```
2021-07-22 11:07:23 +01:00