Commit graph

824 commits

Author SHA1 Message Date
Andrey
4e1318eb2a
feat: gh auth Automatically copy one-time OAuth code to clipboard (#11518)
* feat: add ability to copy one-time OAuth code while authenticating

Signed-off-by: Andrey <andrekabatareika@gmail.com>

* fix(docs): wrong example for gh auth refresh

* chore(authflow): update message to include one-time code to it

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* chore(authflow): improve message when copied one-time code

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* chore(authflow): don't early return error when could not copy OAuth code

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* refactor(authflow): make code for working with OAuth code more readable

* Adjust language in `gh auth` help for clipboard

---------

Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-08-25 09:52:51 -06:00
Andy Feller
d10251211c
Update feature_detection.go 2025-08-12 21:18:47 -04:00
Andy Feller
3bafd883b5 Update v1 project detection logic
This change updates the v1 project detection logic to retrieve the API version of GHES host to determine support.
2025-08-11 14:50:07 -04:00
Andy Feller
65c7ebc79e v1 project feature detection spike using version
These changes are demonstrating how `gh` commands that support v1 classic projects can determine if support exists by checking the GHES server version.
2025-07-28 17:16:56 -04:00
Martin Kealey
e2b7ef4e26
Typo in generated ~/.config/gh/config.yml 2025-07-08 11:21:31 +10:00
William Martin
ad089d48d9 Update microsoft dev-tunnels to v0.1.13
https://github.com/microsoft/dev-tunnels/pull/322 introduced a few
breaking changes:
 * Port Tags were renamed to Labels
 * Client construction must now provide an API version (of which there is only one)
 * The /api/v1 prefix was dropped from request paths
 * TunnelPortListResponses may now be paginated (but we don't support that)
 * Requests to create a port with a changed protocol began erroring
2025-07-02 16:38:07 +02:00
Andy Feller
0180c7fce4 Restored original test setup, clarified
After discussing my previous change to the test, I'm restoring the previous keyring setup to reflect the specific situation.

I added clarifying comments to help the next reviewer.
2025-06-20 15:38:09 -04:00
Andy Feller
b7c2b19e70 Enhance Activetoken prioritize test
- ensure test user tokens are different from unkeyed token
- ensure assertion expected / actual are in correct order
2025-06-20 14:36:45 -04:00
Anuraag Agrawal
848cedd2c8 Push up 2025-06-18 09:56:44 +09:00
Anuraag Agrawal
cc9a2411e0 Cleanup 2025-05-29 12:28:26 +09:00
Anuraag Agrawal
f294a5f533 fix: get token for active user instead of blank if possible 2025-05-29 12:13:21 +09:00
Kynan Ware
dd4095d016 doc(update): improve comments on updaterEnabled 2025-05-27 13:05:47 -06:00
Kynan Ware
22504bfa96 feat(update): add updateable build tag for update notifications 2025-05-26 09:45:00 -06:00
Kynan Ware
944543863a
Revert "[gh config] Escape pipe symbol in Long desc for website manual" 2025-05-20 08:54:30 -06:00
Kynan Ware
d932934119 Merge branch 'trunk' into kw/gh-cli-epic-900-actors-are-assignable 2025-05-16 12:49:52 -06:00
Kynan Ware
999ffbdfe7
Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to-issues
`gh issue edit`: actors are assignable to issues
2025-05-15 09:24:32 -06:00
Babak K. Shandiz
5db8cf7c1d
Increase beforePasswordSendTimeout to 100 us (#10977)
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-13 12:38:45 +01:00
Kynan Ware
73e5589059 doc(issue): comment why assignable actors disabled 2025-05-12 11:37:37 -06:00
Andy Feller
7ceca4534d
Merge pull request #10937 from cli/kw/accessible-prompter-prints-readable-defaults-in-prompt
Accessible prompter always displays defaults in speech synthesis readable format
2025-05-09 08:48:10 -04:00
Babak K. Shandiz
90532e8377
Improve assertion for disabled echo mode (#10927)
* Improve assertion for disabled echo

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `expect.RegExpPattern`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-08 21:26:02 +01:00
Kynan Ware
9b89a0ac0e fix(a11y prompter): remove invalid defaults 2025-05-08 07:41:36 -06:00
Kynan Ware
8ebbd1d4bf feat(fd): add ActorIsAssignable to IssueFeatures 2025-05-07 12:23:18 -06:00
Kynan Ware
3594f6357b fix(a11y prompter): confirm prompt default is readable 2025-05-06 15:50:57 -06:00
Kynan Ware
04aaaea142 fix(a11y prompter): multi select defaults are readable 2025-05-06 15:43:26 -06:00
Kynan Ware
957667efe6 doc(prompter): remove TODO about default value panic 2025-05-06 15:33:51 -06:00
Kynan Ware
cab906151f fix(a11y prompter): select prompt default value is readable 2025-05-06 15:33:15 -06:00
Kynan Ware
ab4cfb84d2 refactor(a11yprompter): shared method for prompt defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
2ee68411a7 fix(a11y prompter): Select prompt respects defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
9bc2c388da fix(a11y prompter): input prompt default value is readable 2025-05-06 14:34:05 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest
Feature detect v1 projects on interactive `pr create`
2025-05-06 15:24:04 +02:00
Kynan Ware
cc673cfaba test(prompter): add timeout before password input 2025-05-02 14:48:07 -06:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
Kynan Ware
00c930d509
doc(prompter): small typo 2025-04-30 08:04:16 -06:00
Andy Feller
8130126ce5
Merge pull request #10901 from cli/kw/fix-accessible-multi-select-prompter-respects-defaults
Fix: Accessible multiselect prompt respects default selections
2025-04-30 09:46:56 -04:00
Kynan Ware
d8512a9066 fix(prompter): respect default MultiSelect a11y prompter 2025-04-29 16:35:04 -06:00
Andy Feller
88d52ebf97 Fix other disabled echo mode comments 2025-04-28 11:20:17 -04:00
Andy Feller
df0aedbe3c
Update internal/prompter/prompter.go 2025-04-28 11:16:35 -04:00
Andy Feller
2d66877d6c
Update internal/prompter/accessible_prompter_test.go 2025-04-28 11:15:28 -04:00
Andy Feller
9fa00c350b Update accessible tests based on huh@0.7.0 changes 2025-04-28 10:17:23 -04:00
Andy Feller
a53b6c074c Assert password and auth token not displayed
This commit expands existing tests (thanks to @babakks) to assert whether the echo mode is actually disabled for password and auth token prompts.
2025-04-28 08:55:47 -04:00
Andy Feller
97a3b70599 Update to huh@0.7.0, echo mode changes
This commit is the initial change around updating to huh@0.7.0; pre-testing changes.
2025-04-26 12:57:10 -04:00
Kynan Ware
9463b0ee61 test(prompter): correct typo in accessible prompter name 2025-04-22 17:12:07 -06:00
Kynan Ware
138bccd437 feat(config): add accessible prompter and spinner 2025-04-22 16:50:58 -06:00
William Martin
636453059c
Merge pull request #10813 from cli/wm-kw/projectsv1-deprecation-issue-view
Feature detect v1 projects on `issue view`
2025-04-22 17:15:13 +02:00
Andy Feller
ac95196748 Fix comment typo 2025-04-21 14:04:53 -04:00
Andy Feller
486c589665 PR feedback to improve config settings docs 2025-04-21 14:04:00 -04:00
Andy Feller
f61961907e Update configuration support for accessible colors
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
2025-04-17 15:57:49 -04:00
William Martin
5ec2160bc6 Avoid requesting projectCards for issue view 2025-04-17 15:37:48 +02:00
William Martin
a9dbda6913 Rework ref usage when finding and creating PRs 2025-04-15 13:38:10 -06:00
Kynan Ware
70537de132
test(prompter): fix invalid comment 2025-04-10 17:18:56 -06:00