Commit graph

516 commits

Author SHA1 Message Date
Mislav Marohnić
a55dd656f3
Merge remote-tracking branch 'origin' into cobra-update 2022-12-20 17:15:25 +01:00
Des Preston
4ade907ae8
Allow setting codespace display name during create (#6739)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-19 17:10:34 +01:00
Nate Smith
67e5baea09
Merge pull request #6711 from cli/release-prompter
port release command to prompter
2022-12-12 12:09:29 -06:00
Mislav Marohnić
e4f5545e86
Go 1.19: fix comment formatting for moq-generated mocks 2022-12-12 16:58:25 +01:00
Sam Coe
6dbe7e6342
Linter fixes (#6722)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-12 15:27:32 +00:00
vilmibm
6507d35f2f port release command to prompter 2022-12-09 15:06:26 -08:00
Sam Coe
98ab1f2587
Authenticate network git commands (#6541) 2022-11-15 13:14:37 +02:00
Mislav Marohnić
278ff59fce
Allow accessing Cobra built-in doc generation features
Setting GH_COBRA allows access to Cobra's built-in implementation of generating man pages and markdown trees. This is useful for testing and comparing our overrides against Cobra's own logic.
2022-11-09 17:30:32 +01:00
Mislav Marohnić
b12ea845ef
Migrate to the new Cobra command grouping feature 2022-11-09 16:42:13 +01:00
JP Ungaretti
67236841ee Specify directory for generate.sh 2022-11-04 20:30:41 +00:00
JP Ungaretti
95542a8211 Remove colon from header 2022-11-04 20:28:47 +00:00
JP Ungaretti
c020d602ff Remove extra generation 2022-11-04 20:14:48 +00:00
JP Ungaretti
7ade90089d Add docs for gRPC 2022-11-04 20:12:19 +00:00
Mislav Marohnić
b94d07347f
Add support for garage.github.com (#6478) 2022-11-03 12:12:38 +00:00
Sam Coe
f96b2fce57
Refactor git client and add tests (#6525) 2022-11-03 11:58:38 +01:00
Cody Taylor
9a80d9c65c Adds max interval and conditional check on elapsed time 2022-10-31 15:23:54 -05:00
Cody Taylor
893bc25bcc Adds exponential backoff to ConnectToLiveshare; Fixes #5738 2022-10-31 13:55:33 -05:00
Sam Coe
4294ee14a1
revert revert 57fbe4f317 (#6474) 2022-10-20 12:17:20 +00:00
Sam Coe
2cefb9fa59
Fix pr create regression (#6472)
* Revert "Refactor to use new git client (#6447)"

This reverts commit 57fbe4f317.

* Fix pr create regression
2022-10-20 12:46:23 +03:00
Sam Coe
57fbe4f317
Refactor to use new git client (#6447) 2022-10-19 21:11:36 +03:00
Ashwin Jeyaseelan
a756ffb1e8
Fix Codespace Creation Devcontainer bug (#6389) 2022-10-18 11:11:28 +03:00
Mislav Marohnić
3fe5026d39
Migrate to tableprinter from go-gh (#6346) 2022-10-17 15:15:39 +02:00
David Gardiner
21ded3e064 Skip flakey test in Actions 2022-10-12 12:40:38 -07:00
David Gardiner
f80f566ab2
Merge pull request #6358 from dmgardiner25/dmgardiner25/grpc-client
Implement gRPC client and `GetRunningServer` method
2022-10-11 10:45:50 -07:00
Caleb Brose
a937b278b2
Merge pull request #6404 from jungaretti/jungaretti/add-rebuild-command
Add cs rebuild command
2022-10-11 10:11:09 -05:00
Jose Garcia
9e13f6ba6b cleanup connect 2022-10-11 09:14:23 -04:00
Jose Garcia
e11b43f8f6 Fixes for handling the grpc client lifecyle 2022-10-11 08:55:14 -04:00
David Gardiner
f89b1b6a45 Create timeout context in caller 2022-10-10 14:39:12 -07:00
David Gardiner
0f41ccc472 Have cilents call port connection function 2022-10-10 11:56:44 -07:00
David Gardiner
a090b17e38 Ensure port is forwarded and server is shared 2022-10-07 15:37:04 -07:00
JP Ungaretti
4a81e46c1a Add rebuilding state 2022-10-07 22:05:16 +00:00
Nate Smith
c13eb9e792
Merge pull request #6320 from cli/label-prompter
add and use ConfirmDeletion in {label,repo} delete
2022-10-04 14:49:59 -05:00
David Gardiner
341fc6c3f7 Mock session/channel for grpc tests 2022-10-03 20:29:31 -07:00
David Gardiner
f947020fa5 Add grpc mock server + tests 2022-09-30 11:55:57 -07:00
David Gardiner
d02ff315e4 Fix linting errors 2022-09-29 10:27:17 -07:00
David Gardiner
766e6a2314 Use existing context 2022-09-29 09:58:44 -07:00
David Gardiner
3f34d6d95e Make suggested gRPC client changes 2022-09-28 10:39:26 -07:00
David Gardiner
93f033fe87 Address comments 2022-09-27 16:01:10 -07:00
Mislav Marohnić
acb61072cd Respect GH_HOST in auth login, repo delete
Bonus fix: respect fallback host argument to `FromFullNameWithHost()`
2022-09-26 13:32:54 +02:00
Sam Coe
ebc681be05
Replace os.Setenv with t.Setenv (#6345) 2022-09-26 13:37:34 +04:00
Eng Zer Jun
471cbea4fa
test: use t.Setenv to set env vars in tests (#6333)
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-26 08:46:02 +00:00
vilmibm
d8a276e83b add and use ConfirmDeletion in {label,repo} delete 2022-09-21 17:19:13 -07:00
Caleb Brose
83c67d3b57 Merge remote-tracking branch 'origin/trunk' into cmbrose/no-ssh-api-call 2022-09-20 15:22:27 +00:00
Mislav Marohnić
6e9974c2ef Escape liquid tags in site docs
It is good practice to wrap all dynamic content in `{% raw %}..{% endraw %}`
Liquid tags so that no syntax within can mistakenly get interpreted as
Liquid tags. Fixes rendering of `gh auth login` help page.
2022-09-19 15:50:51 +02:00
Caleb Brose
0c00ca911e Clean up API interface 2022-09-16 22:25:11 +00:00
Nate Smith
6ab61a085b
Merge pull request #6251 from cli/fix-prompter-default
Do not set default for survey prompt if empty string passed
2022-09-14 12:17:04 -05:00
Sam Coe
e14d14cef2
Add support for issue state reason (#6245) 2022-09-14 12:39:15 +04:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
vilmibm
c2f4bbac6b Do not set default for survey prompt if empty string passed 2022-09-12 17:43:57 -07:00
Mislav Marohnić
436d9ef859
Fix "missing method Fd" crash on Windows (#6200)
This ensures that `IOStreams.Out` always keeps the original `Fd()` value even if it's wrapped as a Colorable stream for Windows in cases when enabling virtual terminal processing has failed.
2022-09-06 17:29:06 +02:00