STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1437 commits 87 branches 0 tags 160 MiB
Commit graph

783 commits

Author SHA1 Message Date
vilmibm
c159d41fc2 manually colorize 2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f working with gross colorize hack + no pager 2020-05-18 16:49:51 -05:00
vilmibm
b94860bae7 add command file with pr resolution 2020-05-18 15:43:27 -05:00
vilmibm
228d01a037 reenable skipping body prompt for pr/issue 2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug 
pass apiClient to determineBaseRepo
 2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919) 
Fixes #882
 2020-05-18 11:13:48 +02:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo 
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
 2020-05-15 15:29:33 -05:00
Mislav Marohnić
e28e6097ce
Merge pull request #891 from victorhsn/master 
add description default private for repo create
 2020-05-13 21:03:59 +02:00
Mislav Marohnić
57e60ab8a1 Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids 2020-05-13 17:20:37 +02:00
Mislav Marohnić
1ff37be361 Fix assigning multiple user reviewers 
This was due to a typo. Fixes #913
 2020-05-13 17:16:12 +02:00
Mislav Marohnić
c225d379a9 Preserve CODEOWNERS reviewers in pr create 
When reviewers were requested on a PR, they would apparently
overwrite the current set of reviewers. A fresh PR will already have
reviewers if it was assigned some by CODEOWNERS rules.

The fix is to only ever add additional reviewers and not overwrite the
entire set.
 2020-05-13 12:09:59 +02:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai 
Add support for `gh pr merge`
 2020-05-12 10:18:54 -07:00
Mislav Marohnić
b75c4a812d Guard against leaked parameters in issue/pr create tests 2020-05-12 16:54:54 +02:00
Mislav Marohnić
386a53c34a Fix metadata resolver query 2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00
Mislav Marohnić
00f23b8d86 Store milestones as slice for consistency with other metadata 
This is for code simplicity. Only 1 milestone per issue or PR is
allowed, like before.
 2020-05-12 15:48:59 +02:00
Mislav Marohnić
6d57f2a91e Faster resolve GraphQL node IDs for assignees, reviewers, and labels 2020-05-12 15:33:51 +02:00
vilmibm
79ad1ed5d3 tyop fix + stricter switch 2020-05-11 17:39:52 -05:00
vilmibm
7009321314 review feedback 2020-05-11 17:06:18 -05:00
vilmibm
c8e9768bf5 slopwip on interactive review 2020-05-11 15:28:12 -05:00
vilmibm
569595894f skip review tests for now 2020-05-11 12:09:21 -05:00
vilmibm
1675a677d6 hide credits from main help 2020-05-11 12:04:24 -05:00
vilmibm
9f0a19911a de-register review until it's ready to ship 2020-05-11 12:04:05 -05:00
Corey Johnson
a7cef60aae
Merge pull request #889 from cli/hacky-help 
Fix the help docs on subcommands
 2020-05-11 09:39:53 -07:00
Mislav Marohnić
1f0db96f2a Avoid relying on Cobra help internals 2020-05-11 12:38:22 +02:00
Nate Smith
c7f7bfc328
Merge pull request #787 from cli/issue-pr-create-metadata 
Add flags to add additional metadata to `issue/pr create`
 2020-05-08 15:04:15 -05:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view 
Add Reviewers to pr view in CLI
 2020-05-08 14:46:08 -05:00
Nate Smith
07dc617566
Merge pull request #840 from cli/credits 
hackday: gh credits
 2020-05-08 14:37:35 -05:00
vilmibm
b15692fab3 review feedback 2020-05-08 14:29:50 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash 
Fix `pr status -R` crash with closed PR on the default branch
 2020-05-08 14:23:51 -05:00
Victor Hugo
8f67ad44e0 add description default private for repo create 2020-05-08 15:04:02 -04:00
Corey Johnson
43e15130f1 Use a var 2020-05-08 11:37:45 -07:00
Mislav Marohnić
c682d90466 Add tests for issue/pr create with metadata 2020-05-08 20:32:46 +02:00
Corey Johnson
b9c4a76687 Update usage docs 2020-05-08 11:20:00 -07:00
Mislav Marohnić
8c84d6881e Avoid aborting survey if reviewers/assignees/labels/projects/milestones are empty 2020-05-08 18:49:43 +02:00
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Corey Johnson
ba1b3424c1 Remove unused funcs 
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
 2020-05-08 09:22:50 -07:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Corey Johnson
70223d1e32 Don't always use the root command help 
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
 2020-05-08 09:19:19 -07:00
Mislav Marohnić
1f774b4158 Add spinner while loading metadata 2020-05-08 18:11:57 +02:00
Mislav Marohnić
34fc3457d6 Skip interactive mode in pr create if title & body were passed 
This matches `issue create` behavior 4b32e3f215
 2020-05-08 18:06:05 +02:00
Mislav Marohnić
cedf94f450 Name some values for readability 2020-05-08 17:58:33 +02:00
Mislav Marohnić
df144926b8 Rename data variable to something more descriptive 2020-05-08 17:56:47 +02:00
Mislav Marohnić
716036161b Rename titleBody (now a misnomer) to something more descriptive 2020-05-08 17:55:46 +02:00
Mislav Marohnić
72e99e9530 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-08 17:46:47 +02:00
Mislav Marohnić
d0f168f4c3 Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-08 17:46:17 +02:00
Mislav Marohnić
3000847bb2
Merge pull request #874 from cli/httpmock 
Parallelism-safe mechanism for stubbing HTTP responses
 2020-05-08 17:34:57 +02:00
vilmibm
6538cca693 switch to using body flag. small TODOs 2020-05-08 10:07:20 -05:00
vilmibm
46522a2add fix current branch tests 2020-05-07 14:51:17 -05:00
vilmibm
8a5290d2b4 clarify error msg 2020-05-07 14:51:08 -05:00