Commit graph

540 commits

Author SHA1 Message Date
Mislav Marohnić
c39dc28fa1 Rename auth/client to auth/shared 2020-12-07 17:08:42 +01:00
Mislav Marohnić
d56d92c908 If git credential helper is non-defined, set gh as credential helper 2020-11-23 20:20:05 +01:00
Mislav Marohnić
e36c9029d3 Fix broken tests 2020-11-20 20:33:08 +01:00
Mislav Marohnić
91d2adc134 Avoid re-requesting username if we already have it 2020-11-20 19:36:26 +01:00
Mislav Marohnić
67672fa88c Prime user's git HTTPS credentials on auth login 2020-11-20 19:36:04 +01:00
Nate Smith
c7eb57d443
respect GH_HOST when resolving remotes (#2301)
* vim to gitignore

* respect GH_HOST in Resolver

* slight restructure, add a test

* grammar fix
2020-11-19 12:59:18 -06:00
Nikola Ristić
e87b5bcaff
Add "reference" help topic (#2223)
* Add "reference" help topic

* Only print reference as a help topic

* fix for color fns, slightly generalize

* WIP for switching to markdown

* escape gt/lt

* minor

* higher wrap point

* detect terminal theme

* futz with angle brackets once more

* minor cleanup

* prepend parent commands

* rename help topic fns and add test

* Simplify reference help generation

- the `<...>` characters from command usage line are now preserved by enclosing the entire usage synopsis in a code span
- hard breaks in flag usage lines are preserved by enclosing flag usage in a code block
- TTY detection and Markdown rendering are now delayed until the user explicitly requests `gh help reference`
- `gh help reference` output is now pager-enabled

Co-authored-by: vilmibm <vilmibm@github.com>
Co-authored-by: vilmibm <vilmibm@neongrid.space>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-18 12:31:36 -06:00
Jakub Warczarek
b205faa941
Implement --web for gh pr checks (#2146) 2020-11-17 12:27:07 -06:00
vilmibm
00617216b8 fix missing import 2020-11-16 14:03:52 -08:00
Christopher Oswald
0bb44c9ced
Support for --web when using gist create (#2263)
* Support for --web when using gist create

Proposal to close #2071

I have not worked with Go prior to this so please smite me down with the
wisdom of a million Golang gods if I'm doing something terribly wrong.

I also added a test to gist/create for the added web arg.

Pretty much referenced the implementation from pr/create.

* Fix for Tests / build (windows-latest)

I believe this fixes it as it stopped failing on a local vm. Otherwise I
will try and tackle it tomorrow.

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 16:01:30 -06:00
Alex Johnson
99574f85a3
Add a command to delete a gist (#2265)
* Add a command to delete a gist

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 15:47:55 -06:00
Sam
116d5815b5
Merge pull request #2388 from cli/gh-token
Add support for GH_TOKEN and GH_ENTERPRISE_TOKEN
2020-11-16 08:27:50 +03:00
vilmibm
ef52376fe0 fix survey invocation 2020-11-13 10:35:32 -08:00
Nate Smith
9a20719ec4
Merge pull request #2386 from cli/create-refactor
Refactor pr/issue creation code
2020-11-13 11:37:15 -06:00
Mislav Marohnić
fed4df2afa
Merge pull request #2405 from cristiand391/fix-usage-help
Minor fix in USAGE help info for some commands
2020-11-13 16:13:51 +01:00
Cristian Dominguez
867f38970f Fix USAGE help for some commands 2020-11-13 10:10:53 -03:00
Mislav Marohnić
6a0d38df44
Merge pull request #2404 from alissonbrunosa/fix-repo-view-command-with-branch
Generate correct URL when branch option is passed in
2020-11-13 13:05:56 +01:00
Alisson Santos
62e560d6ee add empty line between functions 2020-11-13 10:24:17 +01:00
Alisson Santos
9ecc902959 Generate correct URL when branch option is passed in 2020-11-13 10:20:30 +01:00
vilmibm
a686455fb6 add Draft to issue state 2020-11-12 12:17:37 -08:00
vilmibm
b231e6c2cf use NewIssueState 2020-11-12 12:15:48 -08:00
vilmibm
f5277e452e get everything working 2020-11-12 12:03:32 -08:00
vilmibm
0ed7879329 stop using Defaults struct 2020-11-12 12:03:20 -08:00
vilmibm
1c280d4341 stop using string pointer 2020-11-12 12:03:20 -08:00
vilmibm
6671106448 WIP works, probably some title/body input edge cases 2020-11-12 12:03:20 -08:00
vilmibm
6fde02df1c use named output param 2020-11-12 12:02:17 -08:00
boonhong
57ec879aea Fix typos 2020-11-12 22:32:36 +08:00
Sam Coe
414de332fb
cleanup 2020-11-12 09:52:14 +03:00
Sam Coe
a79a0bbfd7
Add support for GH_TOKEN and GH_ENTERPRISE_TOKEN 2020-11-12 09:52:10 +03:00
Mislav Marohnić
fc3f517419
Merge pull request from GHSA-fqfh-778m-2v32
Ensure that only PATH is searched when shelling out to external commands
2020-11-11 16:36:50 +01:00
Mislav Marohnić
5b4a08dcb9 Ensure that only PATH is searched when shelling out to external commands
Works around https://github.com/golang/go/issues/38736 for Windows.
2020-11-11 16:33:13 +01:00
Mislav Marohnić
feec114bb6 Fix truncateLabels for empty values 2020-11-11 15:29:40 +01:00
Mislav Marohnić
8d054486a3 Merge remote-tracking branch 'origin' into jan25/issue-2042 2020-11-11 15:23:46 +01:00
Mislav Marohnić
62e4c536ce Ensure parentheses are preserved after truncating labels in table view 2020-11-11 15:22:34 +01:00
Cristian Dominguez
fa8674386b
Render links as absolute URLs in repo view (#2363)
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2020-11-11 13:13:19 +01:00
Sam Coe
86906c6769
Small cleanup 2020-11-04 12:40:40 +03:00
Sam Coe
241e90aa9b
Make markdown:generate annotation a markdown generation override for hidden commands 2020-11-04 12:35:58 +03:00
Sam Coe
f770c6481c
Generate markdown for help topics 2020-11-04 12:35:58 +03:00
Sam
c7ede29779
Refactor help topics to include short message 2020-11-04 12:35:58 +03:00
Alisson Santos
cf617e88f4 Extract repeated code to util function 2020-11-03 22:05:04 +01:00
Nate Smith
910063336d
Merge pull request #2351 from alissonbrunosa/improve-release-create-message
Improve error message for "gh release create" command
2020-11-03 13:36:31 -06:00
Nate Smith
441f40b427
Merge pull request #2319 from cli/cleanup-duplicate-config
Refactor config command to improve testability
2020-11-03 12:54:16 -06:00
Nate Smith
24d863eccc
Merge pull request #2316 from cli/colors-1624
migrate off of utils color functions
2020-11-03 12:49:02 -06:00
Alisson Santos
7a106e2ded improve error message 2020-11-03 18:46:07 +01:00
Sam
d79eb494d9
Merge pull request #2279 from malaDev/1818-pr-checks-empty
add message on `pr checks` returns no CI with non-empty PR
2020-11-03 10:14:31 +03:00
Sam Coe
9acbf8aae4
Refactor regexp writer 2020-11-03 09:59:40 +03:00
Sam Coe
bf46b870cb
Add multiple writes test 2020-11-03 09:59:39 +03:00
Sam Coe
eaa685ac9b
Use custom scanLines function for RegexWriter 2020-11-03 09:59:38 +03:00
Sam Coe
212993632b
Fix up regex to escape dot in URL 2020-11-03 09:59:11 +03:00
Sam Coe
28b3b2c9e7
Address PR comments 2020-11-03 09:59:09 +03:00