Commit graph

397 commits

Author SHA1 Message Date
Nate Smith
3d7733870e
Merge branch 'master' into repo-fork 2020-03-03 15:40:54 -06:00
vilmibm
44c0d115fc usage 2020-03-03 15:40:19 -06:00
vilmibm
90d2f99d2a this fetch was redundant since AddRemote fetches 2020-03-03 15:38:05 -06:00
Mislav Marohnić
a73880f5dd
Merge pull request #567 from cli/pr-selector-base
Fix detecting PR for current branch pushed to fork
2020-03-03 22:02:21 +01:00
Mislav Marohnić
232453173c
Merge pull request #574 from cli/help-flag
Ensure that `gh <command> -h` is equivalent to `--help`
2020-03-03 21:57:07 +01:00
Mislav Marohnić
371d4f5c6a Ensure that gh <command> -h is equivalent to --help
This compensates for what appears to be a bug in Cobra, which only
handles `pflag.ErrHelp` unless the error is wrapped. It also might be
that Cobra doesn't recognize Go 1.13-style error wrapping.
2020-03-03 20:05:44 +01:00
Nate Smith
fdf940eeba
Merge pull request #530 from doi-t/issue-467
Ability to differentiate pull requests by their state
2020-03-02 16:12:55 -06:00
vilmibm
ce8f3418eb remove short versions of repo/clone to reduce usage clutter 2020-03-02 14:41:51 -06:00
vilmibm
48a6bbf043 minor golfing 2020-03-02 14:38:49 -06:00
vilmibm
6a57f04285 allow continuing if already forked 2020-03-02 14:37:08 -06:00
Mislav Marohnić
201217d88a Fix detecting PR for current branch pushed to fork
Now passing base repo as reference to `prSelectorForCurrentBranch()` so
that it doesn't have to (inexactly) determine the base repo itself and
risk it being different than the base repo determined during `pr
status/view`.
2020-03-02 11:35:20 +01:00
vilmibm
bb65bda62f escape codes in errors render v poorly in windows 2020-02-28 10:28:36 -06:00
vilmibm
5d44d9f483 tweak flag settings 2020-02-27 16:55:31 -06:00
vilmibm
8c473a2779 shorten some english 2020-02-27 16:44:02 -06:00
vilmibm
7fad2d05fb switch to alternate method for determining if repo already forked 2020-02-27 16:43:44 -06:00
Billy Griffin
8340591ad3
Number is more readable 2020-02-27 11:23:37 -07:00
Billy Griffin
b18ea98436
Improve error message for issue URL with no args 2020-02-27 11:22:39 -07:00
Mislav Marohnić
adf2177a24
Merge pull request #474 from politas/fix/StripHash
Handle properly passed #<num> as equivalent to <num> for PRs and Issues
2020-02-27 12:15:00 +01:00
Mislav Marohnić
f5b0354ae3 Fix tests 2020-02-27 12:11:49 +01:00
Myk
038e5e5342 Accept #<num> syntax as issue/PR number 2020-02-27 12:11:49 +01:00
vilmibm
115bf37bbd switch to --clone/--remote 2020-02-26 17:08:48 -06:00
vilmibm
256bdabf03 slight refactor
I didn't initially use GitHubRepo because it had the weird error
wrapping. I poked around and I think this function is leftover from a
vestigial GitHubRepoID function that used to be more single-purpose. I
took out the weird error handling so it could be reused and then used it
from the new GitHubRepoExists.
2020-02-26 16:48:29 -06:00
Mislav Marohnić
55b66feb42
Merge pull request #542 from Dasio/slice-initialization
Slice initialization
2020-02-26 20:02:06 +01:00
vilmibm
e38c15e2c9 fix ellipsis color 2020-02-26 11:56:00 -06:00
vilmibm
6371864835 spruce up UX 2020-02-26 11:48:11 -06:00
Toshiya Doi
5f152a349d Print merged and closed PRs of the current branch along with an opening PR 2020-02-27 00:07:48 +09:00
Dasio
19cc79cac8 Removed explicit capacity in slice initialization 2020-02-26 15:44:52 +01:00
Toshiya Doi
8b31b283f5 Merge branch 'master' into issue-467 2020-02-26 15:37:32 +09:00
Nate Smith
39bdeee13b
Merge pull request #550 from rista404/draft-pr-212
Use gray color for PR number if PR is a draft
2020-02-25 16:51:59 -06:00
vilmibm
8a3337ca66 switch default to Y 2020-02-25 16:26:51 -06:00
vilmibm
4f25d06c1e add repo fork tests 2020-02-25 16:26:51 -06:00
vilmibm
6eaab2562f add repo fork command 2020-02-25 16:26:51 -06:00
rista404
2a42f61d8d Use gray color for PR number if PR is a draft 2020-02-25 18:47:44 +01:00
Mislav Marohnić
d25ec726ad Add repo clone <repo> command 2020-02-25 16:47:42 +01:00
Toshiya Doi
957adc1cff Change a PR number's color based on its PR status 2020-02-25 14:33:39 +09:00
Dasio
9289ab99f2 Use var syntax when empty struct is initialized 2020-02-24 22:33:22 +01:00
Dasio
8aa46c236e Init slice with provided capacity if it's known in advance 2020-02-24 22:16:41 +01:00
Nate Smith
7a222d8f93
Merge pull request #337 from spenrose/repo-view
Add repo view command
2020-02-24 13:28:05 -06:00
vilmibm
1bf8beb96d fix baseRepo type 2020-02-24 13:22:43 -06:00
vilmibm
cb20e9939f Merge remote-tracking branch 'origin/master' into repo-view 2020-02-24 13:19:59 -06:00
Mislav Marohnić
980a5a39eb
Merge pull request #539 from cli/push-output
Show `git push` output during `pr create`
2020-02-24 20:19:11 +01:00
Mislav Marohnić
c10f2ff945 Communicate to the user that we're waiting before retrying git push
When the user has just created a fork, it might not yet be ready for
writing. This ensures that the wait period between retries is
communicated to the user on stderr.
2020-02-24 19:36:54 +01:00
Toshiya Doi
28460e4b7e Change a PR state color 2020-02-25 01:26:07 +09:00
Mislav Marohnić
6eba80a8b4 Merge remote-tracking branch 'origin/master' into repo-view 2020-02-24 17:20:02 +01:00
Mislav Marohnić
e87467d21f Allow repo view OWNER/REPO format for owners starting with "http" 2020-02-24 17:17:14 +01:00
Mislav Marohnić
398a5defb8 Use displayURL helper for consistency 2020-02-24 17:17:00 +01:00
Mislav Marohnić
20fc0dfcb7 Avoid API requests in repo view when repo argument is given 2020-02-24 17:14:46 +01:00
Mislav Marohnić
f6eb710462 Fix test expectation on Windows
On Windows, `&` characters in URLs need to be escaped with `^`, but that
messes up the test expectation for other platforms, so this normalizes it.
2020-02-24 13:53:37 +01:00
Mislav Marohnić
38b58a4914 Respect explicit title & body with issue create --web 2020-02-24 13:41:46 +01:00
Mislav Marohnić
ac94ae5872 Return interface from determineBaseRepo(), not pointer to interface
It's sufficient to return a value of type `ghrepo.Interface` instead of
a pointer to an interface. This avoids having to use `*` whenever we are
passing the result of `determineBaseRepo()` into another function that
accepts a `ghrepo.Interface`.
2020-02-24 13:40:58 +01:00